| Message ID | 20241010111822.345-3-alireza.sanaee@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Specifying cache topology on ARM | expand |
Hi Alireze, On Thu, Oct 10, 2024 at 12:18:18PM +0100, Alireza Sanaee wrote: > Date: Thu, 10 Oct 2024 12:18:18 +0100 > From: Alireza Sanaee <alireza.sanaee@huawei.com> > Subject: [PATCH v3 2/6] i386/cpu: add IsDefined flag to smp-cache property > X-Mailer: git-send-email 2.34.1 > > This commit adds IsDefined flag to the object and this helps in avoiding > extra checks for every single layer of caches in both x86 and ARM. > > Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com> > --- > hw/core/machine-smp.c | 2 ++ > include/hw/boards.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c > index 9a28194676..5a02bbf584 100644 > --- a/hw/core/machine-smp.c > +++ b/hw/core/machine-smp.c > @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms, > return false; > } > > + ms->smp_cache.IsDefined = true; > + > return true; > } > > diff --git a/include/hw/boards.h b/include/hw/boards.h > index db2aa2b706..2883a57084 100644 > --- a/include/hw/boards.h > +++ b/include/hw/boards.h > @@ -373,6 +373,7 @@ typedef struct CpuTopology { > > typedef struct SmpCache { > SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX]; > + bool IsDefined; > } SmpCache; > > /** Thanks for your patch, now I've added this commit in my series to resolve my TODO, which can also help your series be more ARM-focused :). I will post my next version soon. Thanks, Zhao
diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c index 9a28194676..5a02bbf584 100644 --- a/hw/core/machine-smp.c +++ b/hw/core/machine-smp.c @@ -371,6 +371,8 @@ bool machine_parse_smp_cache(MachineState *ms, return false; } + ms->smp_cache.IsDefined = true; + return true; } diff --git a/include/hw/boards.h b/include/hw/boards.h index db2aa2b706..2883a57084 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -373,6 +373,7 @@ typedef struct CpuTopology { typedef struct SmpCache { SmpCacheProperties props[CACHE_LEVEL_AND_TYPE__MAX]; + bool IsDefined; } SmpCache; /**
This commit adds IsDefined flag to the object and this helps in avoiding extra checks for every single layer of caches in both x86 and ARM. Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com> --- hw/core/machine-smp.c | 2 ++ include/hw/boards.h | 1 + 2 files changed, 3 insertions(+)