| Message ID | 20241013155225.26259-1-cenk.uluisik@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5b | expand |
Hi, Am Sonntag, 13. Oktober 2024, 17:52:18 CEST schrieb Cenk Uluisik: > Add initial support for OPi5b that includes support for USB2, PCIe2, Sata, > Sdmmc, SPI Flash, PMIC. Please describe in a better way what actually makes this board different from the original OrangePi 5. I.e. it does look like the 5b does have an emmc where the 5 does not. You also need a separate second patch to update Documentation/devicetree/bindings/arm/rockchip.yaml You need to update the Xunlong Orange Pi 5 entry with an enum. Please see for example the orange-pi-3 entry on how that should look. > Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com> > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 26 +++++++++++++++++++ > > 2 files changed, 27 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 09423070c992..45249ce15175 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -154,3 +154,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts > new file mode 100644 > index 000000000000..107b65a5e7ea > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts > @@ -0,0 +1,26 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > + > +#include "rk3588s-orangepi-5.dts" Please don't include the board dts. Take a look for example at the rk3566-orangepi-3b on how to do this. I.e. you want a rk3588s-orangepi-5.dtsi which then gets included into both the original-5 as well as your 5b . > + > +/ { > + model = "Xunlong Orange Pi 5B"; > + compatible = "rockchip,rk3588s-orangepi-5", "rockchip,rk3588"; > +}; > + > +&sdhci { > + status = "okay"; > +}; > + > +&sfc { > + status = "disabled"; > +}; > + > +&wireless_bluetooth { > + status = "okay"; > +}; > + > +&wireless_wlan { > + status = "okay"; > +}; both the wireless_bluetooth as well as the wireless_wlan phandles are not part of the orange pi 5 in mainline. So this probably doesn't even compile? Heiko
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile index 09423070c992..45249ce15175 100644 --- a/arch/arm64/boot/dts/rockchip/Makefile +++ b/arch/arm64/boot/dts/rockchip/Makefile @@ -154,3 +154,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts new file mode 100644 index 000000000000..107b65a5e7ea --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts @@ -0,0 +1,26 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +/dts-v1/; + +#include "rk3588s-orangepi-5.dts" + +/ { + model = "Xunlong Orange Pi 5B"; + compatible = "rockchip,rk3588s-orangepi-5", "rockchip,rk3588"; +}; + +&sdhci { + status = "okay"; +}; + +&sfc { + status = "disabled"; +}; + +&wireless_bluetooth { + status = "okay"; +}; + +&wireless_wlan { + status = "okay"; +};
Add initial support for OPi5b that includes support for USB2, PCIe2, Sata, Sdmmc, SPI Flash, PMIC. Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com> --- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 26 +++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts