mbox series

[bpf-next,0/2] security.bpf xattr name prefix

Message ID 20241002214637.3625277-1-song@kernel.org (mailing list archive)
Headers show
Series security.bpf xattr name prefix | expand

Message

Song Liu Oct. 2, 2024, 9:46 p.m. UTC
Follow up discussion in LPC 2024 [1], that we need security.bpf xattr
prefix. This set adds "security.bpf" xattr name prefix, and allows
bpf kfuncs bpf_get_[file|dentry]_xattr() to read these xattrs.


[1] https://lpc.events/event/18/contributions/1940/

Song Liu (2):
  fs/xattr: bpf: Introduce security.bpf xattr name prefix
  selftests/bpf: Extend test fs_kfuncs to cover security.bpf xattr names

 fs/bpf_fs_kfuncs.c                            | 19 ++++++++-
 include/uapi/linux/xattr.h                    |  4 ++
 .../selftests/bpf/prog_tests/fs_kfuncs.c      | 40 ++++++++++++++-----
 .../selftests/bpf/progs/test_get_xattr.c      | 30 ++++++++++++--
 4 files changed, 78 insertions(+), 15 deletions(-)

--
2.43.5

Comments

Song Liu Oct. 11, 2024, 5:40 p.m. UTC | #1
Hi Christian, Al, and Jan,

Could you please review and share your comments on this set?

Thanks,
Song

On Wed, Oct 2, 2024 at 2:47 PM Song Liu <song@kernel.org> wrote:
>
> Follow up discussion in LPC 2024 [1], that we need security.bpf xattr
> prefix. This set adds "security.bpf" xattr name prefix, and allows
> bpf kfuncs bpf_get_[file|dentry]_xattr() to read these xattrs.
>
>
> [1] https://lpc.events/event/18/contributions/1940/
>
> Song Liu (2):
>   fs/xattr: bpf: Introduce security.bpf xattr name prefix
>   selftests/bpf: Extend test fs_kfuncs to cover security.bpf xattr names
>
>  fs/bpf_fs_kfuncs.c                            | 19 ++++++++-
>  include/uapi/linux/xattr.h                    |  4 ++
>  .../selftests/bpf/prog_tests/fs_kfuncs.c      | 40 ++++++++++++++-----
>  .../selftests/bpf/progs/test_get_xattr.c      | 30 ++++++++++++--
>  4 files changed, 78 insertions(+), 15 deletions(-)
>
> --
> 2.43.5
Christian Brauner Oct. 14, 2024, 10:18 a.m. UTC | #2
On Fri, Oct 11, 2024 at 10:40:02AM -0700, Song Liu wrote:
> Hi Christian, Al, and Jan,
> 
> Could you please review and share your comments on this set?

Yes, as I said in-person, I think adding security.bpf is fine.