diff mbox series

[2/7] linux-kbuild: fix: missing variable operator

Message ID 20240913171205.22126-3-david.hunter.linux@gmail.com (mailing list archive)
State New
Headers show
Series [1/7] linux-kbuild: fix: config option can be bool | expand

Commit Message

David Hunter Sept. 13, 2024, 5:11 p.m. UTC 
Put in the dollar sign for the variable '$config'. That way, the debug
message has more meaning.

Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
 scripts/kconfig/streamline_config.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Masahiro Yamada Sept. 24, 2024, 3:04 a.m. UTC | #1 
Good catch, but please fix the subject prefix.

For example,

streamline_config.pl: fix missing variable operator in debug print





On Sat, Sep 14, 2024 at 2:12 AM David Hunter
<david.hunter.linux@gmail.com> wrote:
>
> Put in the dollar sign for the variable '$config'. That way, the debug
> message has more meaning.
>
> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
> ---
>  scripts/kconfig/streamline_config.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> index a828d7ab7e26..ddc630f2264a 100755
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -503,7 +503,7 @@ sub parse_config_selects
>
>             # Check if something other than a module selects this config
>             if (defined($orig_configs{$conf}) && $orig_configs{$conf} ne "m") {
> -               dprint "$conf (non module) selects config, we are good\n";
> +               dprint "$conf (non module) selects $config, we are good\n";
>                 # we are good with this
>                 return;
>             }
> --
> 2.43.0
>
David Hunter Oct. 14, 2024, 2:26 p.m. UTC | #2 
https://lore.kernel.org/all/20241014141345.5680-2-david.hunter.linux@gmail.com/
diff mbox series

Patch

diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index a828d7ab7e26..ddc630f2264a 100755
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -503,7 +503,7 @@  sub parse_config_selects
 
 	    # Check if something other than a module selects this config
 	    if (defined($orig_configs{$conf}) && $orig_configs{$conf} ne "m") {
-		dprint "$conf (non module) selects config, we are good\n";
+		dprint "$conf (non module) selects $config, we are good\n";
 		# we are good with this
 		return;
 	    }