diff mbox series

resource: Remove dependency on SPARSEMEM from GET_FREE_REGION

Message ID 20241015051554.294734-1-ying.huang@intel.com (mailing list archive)
State New
Headers show
Series resource: Remove dependency on SPARSEMEM from GET_FREE_REGION | expand

Commit Message

Huang, Ying Oct. 15, 2024, 5:15 a.m. UTC 
We want to use the functions configured via GET_FREE_REGION in
resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
This makes resource kunit tests cannot be built on some architectures
lacking SPARSEMEM.  In fact, these functions doesn't depend on
SPARSEMEM now.  So, remove dependency on SPARSEMEM from
GET_FREE_REGION.

Link: https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
---
 mm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

David Hildenbrand Oct. 15, 2024, 7:07 a.m. UTC | #1 
On 15.10.24 07:15, Huang Ying wrote:
> We want to use the functions configured via GET_FREE_REGION in
> resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
> This makes resource kunit tests cannot be built on some architectures
> lacking SPARSEMEM.  In fact, these functions doesn't depend on
> SPARSEMEM now.  So, remove dependency on SPARSEMEM from
> GET_FREE_REGION.
> 
> Link: https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
>   mm/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 4c9f5ea13271..33fa51d608dc 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
>   	depends on MMU
>   
>   config GET_FREE_REGION
> -	depends on SPARSEMEM
>   	bool
>   
>   config DEVICE_PRIVATE

Added by

commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
Author: Dan Williams <dan.j.williams@intel.com>
Date:   Fri May 20 13:41:24 2022 -0700

     resource: Introduce alloc_free_mem_region()

@Dan, any insight why that dependency was added?
Huang, Ying Oct. 15, 2024, 8:03 a.m. UTC | #2 
Hi, David,

David Hildenbrand <david@redhat.com> writes:

> On 15.10.24 07:15, Huang Ying wrote:
>> We want to use the functions configured via GET_FREE_REGION in
>> resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
>> This makes resource kunit tests cannot be built on some architectures
>> lacking SPARSEMEM.  In fact, these functions doesn't depend on
>> SPARSEMEM now.  So, remove dependency on SPARSEMEM from
>> GET_FREE_REGION.
>> Link:
>> https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>> Cc: Nathan Chancellor <nathan@kernel.org>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> Cc: David Hildenbrand <david@redhat.com>
>> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
>> ---
>>   mm/Kconfig | 1 -
>>   1 file changed, 1 deletion(-)
>> diff --git a/mm/Kconfig b/mm/Kconfig
>> index 4c9f5ea13271..33fa51d608dc 100644
>> --- a/mm/Kconfig
>> +++ b/mm/Kconfig
>> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
>>   	depends on MMU
>>     config GET_FREE_REGION
>> -	depends on SPARSEMEM
>>   	bool
>>     config DEVICE_PRIVATE
>
> Added by
>
> commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
> Author: Dan Williams <dan.j.williams@intel.com>
> Date:   Fri May 20 13:41:24 2022 -0700
>
>     resource: Introduce alloc_free_mem_region()
>
> @Dan, any insight why that dependency was added?

Dan has explain it some what in the following email,

https://lore.kernel.org/lkml/66f5abd431dce_964f2294b9@dwillia2-xfh.jf.intel.com.notmuch/

This is reachable from the "Link:" tag in the patch.

--
Best Regards,
Huang, Ying
David Hildenbrand Oct. 15, 2024, 10:33 a.m. UTC | #3 
On 15.10.24 10:03, Huang, Ying wrote:
> Hi, David,
> 
> David Hildenbrand <david@redhat.com> writes:
> 
>> On 15.10.24 07:15, Huang Ying wrote:
>>> We want to use the functions configured via GET_FREE_REGION in
>>> resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
>>> This makes resource kunit tests cannot be built on some architectures
>>> lacking SPARSEMEM.  In fact, these functions doesn't depend on
>>> SPARSEMEM now.  So, remove dependency on SPARSEMEM from
>>> GET_FREE_REGION.
>>> Link:
>>> https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
>>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>>> Cc: Nathan Chancellor <nathan@kernel.org>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Cc: Dan Williams <dan.j.williams@intel.com>
>>> Cc: David Hildenbrand <david@redhat.com>
>>> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
>>> ---
>>>    mm/Kconfig | 1 -
>>>    1 file changed, 1 deletion(-)
>>> diff --git a/mm/Kconfig b/mm/Kconfig
>>> index 4c9f5ea13271..33fa51d608dc 100644
>>> --- a/mm/Kconfig
>>> +++ b/mm/Kconfig
>>> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
>>>    	depends on MMU
>>>      config GET_FREE_REGION
>>> -	depends on SPARSEMEM
>>>    	bool
>>>      config DEVICE_PRIVATE
>>
>> Added by
>>
>> commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
>> Author: Dan Williams <dan.j.williams@intel.com>
>> Date:   Fri May 20 13:41:24 2022 -0700
>>
>>      resource: Introduce alloc_free_mem_region()
>>
>> @Dan, any insight why that dependency was added?
> 
> Dan has explain it some what in the following email,
> 
> https://lore.kernel.org/lkml/66f5abd431dce_964f2294b9@dwillia2-xfh.jf.intel.com.notmuch/
> 
> This is reachable from the "Link:" tag in the patch.

That should be part of the patch description then :)
Dan Williams Oct. 16, 2024, midnight UTC | #4 
David Hildenbrand wrote:
> On 15.10.24 10:03, Huang, Ying wrote:
> > Hi, David,
> > 
> > David Hildenbrand <david@redhat.com> writes:
> > 
> >> On 15.10.24 07:15, Huang Ying wrote:
> >>> We want to use the functions configured via GET_FREE_REGION in
> >>> resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
> >>> This makes resource kunit tests cannot be built on some architectures
> >>> lacking SPARSEMEM.  In fact, these functions doesn't depend on
> >>> SPARSEMEM now.  So, remove dependency on SPARSEMEM from
> >>> GET_FREE_REGION.
> >>> Link:
> >>> https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
> >>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> >>> Tested-by: Guenter Roeck <linux@roeck-us.net>
> >>> Cc: Nathan Chancellor <nathan@kernel.org>
> >>> Cc: Arnd Bergmann <arnd@arndb.de>
> >>> Cc: Dan Williams <dan.j.williams@intel.com>
> >>> Cc: David Hildenbrand <david@redhat.com>
> >>> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> >>> ---
> >>>    mm/Kconfig | 1 -
> >>>    1 file changed, 1 deletion(-)
> >>> diff --git a/mm/Kconfig b/mm/Kconfig
> >>> index 4c9f5ea13271..33fa51d608dc 100644
> >>> --- a/mm/Kconfig
> >>> +++ b/mm/Kconfig
> >>> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
> >>>    	depends on MMU
> >>>      config GET_FREE_REGION
> >>> -	depends on SPARSEMEM
> >>>    	bool
> >>>      config DEVICE_PRIVATE
> >>
> >> Added by
> >>
> >> commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
> >> Author: Dan Williams <dan.j.williams@intel.com>
> >> Date:   Fri May 20 13:41:24 2022 -0700
> >>
> >>      resource: Introduce alloc_free_mem_region()
> >>
> >> @Dan, any insight why that dependency was added?
> > 
> > Dan has explain it some what in the following email,
> > 
> > https://lore.kernel.org/lkml/66f5abd431dce_964f2294b9@dwillia2-xfh.jf.intel.com.notmuch/
> > 
> > This is reachable from the "Link:" tag in the patch.
> 
> That should be part of the patch description then :)

That Link: does not really describe the history though...

The description I would add is:

---

When get_free_mem_region() was introduced the only consumers were those
looking to pass the address range to memremap_pages(). That address
range needed to be mindful of the maximum addressable platform physical
address which at the time only SPARSMEM defined via MAX_PHYSMEM_BITS.

Given that memremap_pages() also depended on SPARSEMEM via ZONE_DEVICE,
it was easier to just depend on that definition than invent a general
MAX_PHYSMEM_BITS concept outside of SPARSEMEM.

Turns out that decision was buggy and did not account for KASAN
consumption of physical address space. That problem was resolved
recently with commit ea72ce5da228 ("x86/kaslr: Expose and use the end of
the physical memory address space"), and GET_FREE_REGION dropped its
MAX_PHYSMEM_BITS dependency.

Then commit 99185c10d5d9 ("resource, kunit: add test case for
region_intersects()"), went ahead and fixed up the only remaining
dependency on SPARSEMEM which was usage of the PA_SECTION_SHIFT macro
for setting the default alignment. A PAGE_SIZE fallback is fine in the
SPARSEMEM=n case.

With those build dependencies gone GET_FREE_REGION no longer depends on
SPARSEMEM.
Huang, Ying Oct. 16, 2024, 12:37 a.m. UTC | #5 
Hi, Dan,

Dan Williams <dan.j.williams@intel.com> writes:

> David Hildenbrand wrote:
>> On 15.10.24 10:03, Huang, Ying wrote:
>> > Hi, David,
>> > 
>> > David Hildenbrand <david@redhat.com> writes:
>> > 
>> >> On 15.10.24 07:15, Huang Ying wrote:
>> >>> We want to use the functions configured via GET_FREE_REGION in
>> >>> resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
>> >>> This makes resource kunit tests cannot be built on some architectures
>> >>> lacking SPARSEMEM.  In fact, these functions doesn't depend on
>> >>> SPARSEMEM now.  So, remove dependency on SPARSEMEM from
>> >>> GET_FREE_REGION.
>> >>> Link:
>> >>> https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
>> >>> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
>> >>> Tested-by: Guenter Roeck <linux@roeck-us.net>
>> >>> Cc: Nathan Chancellor <nathan@kernel.org>
>> >>> Cc: Arnd Bergmann <arnd@arndb.de>
>> >>> Cc: Dan Williams <dan.j.williams@intel.com>
>> >>> Cc: David Hildenbrand <david@redhat.com>
>> >>> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
>> >>> ---
>> >>>    mm/Kconfig | 1 -
>> >>>    1 file changed, 1 deletion(-)
>> >>> diff --git a/mm/Kconfig b/mm/Kconfig
>> >>> index 4c9f5ea13271..33fa51d608dc 100644
>> >>> --- a/mm/Kconfig
>> >>> +++ b/mm/Kconfig
>> >>> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
>> >>>    	depends on MMU
>> >>>      config GET_FREE_REGION
>> >>> -	depends on SPARSEMEM
>> >>>    	bool
>> >>>      config DEVICE_PRIVATE
>> >>
>> >> Added by
>> >>
>> >> commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
>> >> Author: Dan Williams <dan.j.williams@intel.com>
>> >> Date:   Fri May 20 13:41:24 2022 -0700
>> >>
>> >>      resource: Introduce alloc_free_mem_region()
>> >>
>> >> @Dan, any insight why that dependency was added?
>> > 
>> > Dan has explain it some what in the following email,
>> > 
>> > https://lore.kernel.org/lkml/66f5abd431dce_964f2294b9@dwillia2-xfh.jf.intel.com.notmuch/
>> > 
>> > This is reachable from the "Link:" tag in the patch.
>> 
>> That should be part of the patch description then :)
>
> That Link: does not really describe the history though...

Sorry.  I made a mistake here.

> The description I would add is:
>
> ---
>
> When get_free_mem_region() was introduced the only consumers were those
> looking to pass the address range to memremap_pages(). That address
> range needed to be mindful of the maximum addressable platform physical
> address which at the time only SPARSMEM defined via MAX_PHYSMEM_BITS.
>
> Given that memremap_pages() also depended on SPARSEMEM via ZONE_DEVICE,
> it was easier to just depend on that definition than invent a general
> MAX_PHYSMEM_BITS concept outside of SPARSEMEM.
>
> Turns out that decision was buggy and did not account for KASAN
> consumption of physical address space. That problem was resolved
> recently with commit ea72ce5da228 ("x86/kaslr: Expose and use the end of
> the physical memory address space"), and GET_FREE_REGION dropped its
> MAX_PHYSMEM_BITS dependency.
>
> Then commit 99185c10d5d9 ("resource, kunit: add test case for
> region_intersects()"), went ahead and fixed up the only remaining
> dependency on SPARSEMEM which was usage of the PA_SECTION_SHIFT macro
> for setting the default alignment. A PAGE_SIZE fallback is fine in the
> SPARSEMEM=n case.
>
> With those build dependencies gone GET_FREE_REGION no longer depends on
> SPARSEMEM.

This looks great!  Will use this in the patch description in the next
version.

--
Best Regards,
Huang, Ying
diff mbox series

Patch

diff --git a/mm/Kconfig b/mm/Kconfig
index 4c9f5ea13271..33fa51d608dc 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -1085,7 +1085,6 @@  config HMM_MIRROR
 	depends on MMU
 
 config GET_FREE_REGION
-	depends on SPARSEMEM
 	bool
 
 config DEVICE_PRIVATE