| Message ID | 20241014064951.1221095-1-lizhijian@fujitsu.com |
|---|---|
| State | New |
| Headers | show |
| Series | [ndctl] test/security.sh: add missing jq requirement check | expand |
On 14/10/2024 14:49, Li Zhijian wrote: > Add jd requirement check explicitly like others so that the test can > be skipped when no jd is installed. Fix a typo s/jd/jq > > Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> > --- > test/security.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/security.sh b/test/security.sh > index f954aec3e25a..d3a840c23276 100755 > --- a/test/security.sh > +++ b/test/security.sh > @@ -220,6 +220,7 @@ else > fi > > check_prereq "keyctl" > +check_prereq "jq" > > uid="$(keyctl show | grep -Eo "_uid.[0-9]+" | head -1 | cut -d. -f2-)" > if [ "$uid" -ne 0 ]; then
On Mon, Oct 14, 2024 at 06:56:12AM +0000, Zhijian Li (Fujitsu) wrote: > > > On 14/10/2024 14:49, Li Zhijian wrote: > > Add jd requirement check explicitly like others so that the test can > > be skipped when no jd is installed. > > Fix a typo > s/jd/jq > Thanks! I'll fix up the typo when I apply it. Reviewed-by: Alison Schofield <alison.schofield@intel.com>
diff --git a/test/security.sh b/test/security.sh index f954aec3e25a..d3a840c23276 100755 --- a/test/security.sh +++ b/test/security.sh @@ -220,6 +220,7 @@ else fi check_prereq "keyctl" +check_prereq "jq" uid="$(keyctl show | grep -Eo "_uid.[0-9]+" | head -1 | cut -d. -f2-)" if [ "$uid" -ne 0 ]; then
Add jd requirement check explicitly like others so that the test can be skipped when no jd is installed. Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- test/security.sh | 1 + 1 file changed, 1 insertion(+)