| Message ID | 20241015010817.453539-2-lizhijian@fujitsu.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | None | expand |
On Tue, 15 Oct 2024 09:08:16 +0800 Li Zhijian wrote: > ``` > readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" > readonly BASE=`basename $STATS` > ``` > It would be a mistake to write to $BASE rather than $STATS, where $STATS > is used to save the NSTAT_HISTORY and it will be cleaned up before exit. Shuah already mentioned this, this patch needs to be posted separately as it would go via the networking tree.
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh index 4f1edbafb946..457312ef135a 100755 --- a/tools/testing/selftests/net/veth.sh +++ b/tools/testing/selftests/net/veth.sh @@ -46,8 +46,8 @@ create_ns() { ip -n $BASE$ns addr add dev veth$ns $BM_NET_V4$ns/24 ip -n $BASE$ns addr add dev veth$ns $BM_NET_V6$ns/64 nodad done - echo "#kernel" > $BASE - chmod go-rw $BASE + echo "#kernel" > $STATS + chmod go-rw $STATS } __chk_flag() {
``` readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS` ``` It would be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit. Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- Cc: netdev@vger.kernel.org --- tools/testing/selftests/net/veth.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)