| Message ID | 20241015172458.673241-2-florian.fainelli@broadcom.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: systemport: Minor IO macros changes | expand |
On Tue, Oct 15, 2024 at 10:24:57AM -0700, Florian Fainelli wrote: > Vladimir reported the following warning with clang-16 and W=1: > > warning: unused function 'txchk_readl' [-Wunused-function] > BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET); > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > warning: unused function 'txchk_writel' [-Wunused-function] > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > warning: unused function 'tbuf_readl' [-Wunused-function] > BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET); > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > warning: unused function 'tbuf_writel' [-Wunused-function] > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' I mean the warnings do say that the tbuf macros are unused too, yet you only remove txchk? I did ask yesterday if that should also be deleted, and with it the other unused transmit buffer macros? https://lore.kernel.org/netdev/20241014174056.sxcgikf4hhw2olp7@skbuf/ > > The TXCHK block is not being accessed, remove the IO macros used to > access this block. No functional impact. > > Reported-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> > --- > drivers/net/ethernet/broadcom/bcmsysport.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c > index 9332a9390f0d..05c83cb3871c 100644 > --- a/drivers/net/ethernet/broadcom/bcmsysport.c > +++ b/drivers/net/ethernet/broadcom/bcmsysport.c > @@ -46,7 +46,6 @@ BCM_SYSPORT_IO_MACRO(umac, SYS_PORT_UMAC_OFFSET); > BCM_SYSPORT_IO_MACRO(gib, SYS_PORT_GIB_OFFSET); > BCM_SYSPORT_IO_MACRO(tdma, SYS_PORT_TDMA_OFFSET); > BCM_SYSPORT_IO_MACRO(rxchk, SYS_PORT_RXCHK_OFFSET); > -BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET); > BCM_SYSPORT_IO_MACRO(rbuf, SYS_PORT_RBUF_OFFSET); > BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET); > BCM_SYSPORT_IO_MACRO(topctrl, SYS_PORT_TOPCTRL_OFFSET); > -- > 2.43.0 >
On 10/15/24 10:24, Florian Fainelli wrote: > Vladimir reported the following warning with clang-16 and W=1: > > warning: unused function 'txchk_readl' [-Wunused-function] > BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET); > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > warning: unused function 'txchk_writel' [-Wunused-function] > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > warning: unused function 'tbuf_readl' [-Wunused-function] > BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET); > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > warning: unused function 'tbuf_writel' [-Wunused-function] > note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > The TXCHK block is not being accessed, remove the IO macros used to > access this block. No functional impact. > > Reported-by: Vladimir Oltean <vladimir.oltean@nxp.com> > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Forgot to remove the tbuf accessor here as well, will post again in 24hrs.
On 10/15/24 10:29, Vladimir Oltean wrote: > On Tue, Oct 15, 2024 at 10:24:57AM -0700, Florian Fainelli wrote: >> Vladimir reported the following warning with clang-16 and W=1: >> >> warning: unused function 'txchk_readl' [-Wunused-function] >> BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET); >> note: expanded from macro 'BCM_SYSPORT_IO_MACRO' >> >> warning: unused function 'txchk_writel' [-Wunused-function] >> note: expanded from macro 'BCM_SYSPORT_IO_MACRO' >> >> warning: unused function 'tbuf_readl' [-Wunused-function] >> BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET); >> note: expanded from macro 'BCM_SYSPORT_IO_MACRO' >> >> warning: unused function 'tbuf_writel' [-Wunused-function] >> note: expanded from macro 'BCM_SYSPORT_IO_MACRO' > > I mean the warnings do say that the tbuf macros are unused too, yet you > only remove txchk? I did ask yesterday if that should also be deleted, > and with it the other unused transmit buffer macros? > https://lore.kernel.org/netdev/20241014174056.sxcgikf4hhw2olp7@skbuf/ See my response to my own posting. -- Florian
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 9332a9390f0d..05c83cb3871c 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -46,7 +46,6 @@ BCM_SYSPORT_IO_MACRO(umac, SYS_PORT_UMAC_OFFSET); BCM_SYSPORT_IO_MACRO(gib, SYS_PORT_GIB_OFFSET); BCM_SYSPORT_IO_MACRO(tdma, SYS_PORT_TDMA_OFFSET); BCM_SYSPORT_IO_MACRO(rxchk, SYS_PORT_RXCHK_OFFSET); -BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET); BCM_SYSPORT_IO_MACRO(rbuf, SYS_PORT_RBUF_OFFSET); BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET); BCM_SYSPORT_IO_MACRO(topctrl, SYS_PORT_TOPCTRL_OFFSET);
Vladimir reported the following warning with clang-16 and W=1: warning: unused function 'txchk_readl' [-Wunused-function] BCM_SYSPORT_IO_MACRO(txchk, SYS_PORT_TXCHK_OFFSET); note: expanded from macro 'BCM_SYSPORT_IO_MACRO' warning: unused function 'txchk_writel' [-Wunused-function] note: expanded from macro 'BCM_SYSPORT_IO_MACRO' warning: unused function 'tbuf_readl' [-Wunused-function] BCM_SYSPORT_IO_MACRO(tbuf, SYS_PORT_TBUF_OFFSET); note: expanded from macro 'BCM_SYSPORT_IO_MACRO' warning: unused function 'tbuf_writel' [-Wunused-function] note: expanded from macro 'BCM_SYSPORT_IO_MACRO' The TXCHK block is not being accessed, remove the IO macros used to access this block. No functional impact. Reported-by: Vladimir Oltean <vladimir.oltean@nxp.com> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/net/ethernet/broadcom/bcmsysport.c | 1 - 1 file changed, 1 deletion(-)