diff mbox series

scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif

Message ID 20240930201347.1837690-1-bvanassche@acm.org (mailing list archive)
State Accepted
Headers show
Series scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif | expand

Commit Message

Bart Van Assche Sept. 30, 2024, 8:13 p.m. UTC
Except for preventing build errors, there shouldn't be any conditionals in
kernel drivers on __GENKSYMS__. Hence remove an #ifndef __GENKSYMS__ / #endif
pair from the MPT Fusion driver.

Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: MPT-FusionLinux.pdl@broadcom.com
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/message/fusion/mptlan.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Martin K. Petersen Oct. 4, 2024, 1:46 a.m. UTC | #1
Bart,

> Except for preventing build errors, there shouldn't be any conditionals in
> kernel drivers on __GENKSYMS__. Hence remove an #ifndef __GENKSYMS__ / #endif
> pair from the MPT Fusion driver.

Applied to 6.13/scsi-staging, thanks!
Martin K. Petersen Oct. 16, 2024, 2:40 a.m. UTC | #2
On Mon, 30 Sep 2024 13:13:47 -0700, Bart Van Assche wrote:

> Except for preventing build errors, there shouldn't be any conditionals in
> kernel drivers on __GENKSYMS__. Hence remove an #ifndef __GENKSYMS__ / #endif
> pair from the MPT Fusion driver.
> 
> 

Applied to 6.13/scsi-queue, thanks!

[1/1] scsi: mptfusion: Remove #ifndef __GENKSYMS__ / #endif
      https://git.kernel.org/mkp/scsi/c/09822c231ae6
diff mbox series

Patch

diff --git a/drivers/message/fusion/mptlan.h b/drivers/message/fusion/mptlan.h
index a1ec7e84d6fe..40b34f670065 100644
--- a/drivers/message/fusion/mptlan.h
+++ b/drivers/message/fusion/mptlan.h
@@ -51,10 +51,7 @@ 
 #define LINUX_MPTLAN_H_INCLUDED
 /*****************************************************************************/
 
-#if !defined(__GENKSYMS__)
 #include <linux/module.h>
-#endif
-
 #include <linux/netdevice.h>
 #include <linux/errno.h>
 // #include <linux/etherdevice.h>