| Message ID | 58691dd652b23f2c630eba71bb9b93700ab66a09.1728992306.git.ps@pks.im (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Platform compatibility fixes | expand |
On Tue Oct 15, 2024 at 10:45 PM AEDT, Patrick Steinhardt wrote: > Windows nowadays provides a tar(1) binary in "C:\Windows\system32". This > version of tar(1) doesn't seem to handle the case where directory paths > end with a trailing forward slash. And as we do that in t1401 the result > is that the test fails. Native explorer.exe support for .tar (and a bunch of other archive formats) was added as part of KB5031455 [1] not too long ago. It just uses libarchive under the hood, and was a huge QoL improvement for me when I was running Windows full-time at home! [1] https://support.microsoft.com/en-us/topic/october-31-2023-kb5031455-os-builds-22621-2506-and-22631-2506-preview-6513c5ec-c5a2-4aaf-97f5-44c13d29e0d4
diff --git a/t/t1401-symbolic-ref.sh b/t/t1401-symbolic-ref.sh index 5c60d6f812d..90af3f955c0 100755 --- a/t/t1401-symbolic-ref.sh +++ b/t/t1401-symbolic-ref.sh @@ -16,7 +16,7 @@ reset_to_sane() { test_expect_success 'setup' ' git symbolic-ref HEAD refs/heads/foo && test_commit file && - "$TAR" cf .git.tar .git/ + "$TAR" cf .git.tar .git ' test_expect_success 'symbolic-ref read/write roundtrip' '
Windows nowadays provides a tar(1) binary in "C:\Windows\system32". This version of tar(1) doesn't seem to handle the case where directory paths end with a trailing forward slash. And as we do that in t1401 the result is that the test fails. Drop the trailing slash. Other tests that use tar(1) work alright, this is the only instance where it has been failing. Signed-off-by: Patrick Steinhardt <ps@pks.im> --- t/t1401-symbolic-ref.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)