mbox series

[0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch

Message ID 20241016145112.24785-1-johan+linaro@kernel.org (mailing list archive)
Headers show
Series arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch | expand

Message

Johan Hovold Oct. 16, 2024, 2:51 p.m. UTC
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.

Johan


Johan Hovold (6):
  arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
  arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
  arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
    glitch
  arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
  arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
    glitch
  arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch

 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 2 ++
 arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts    | 2 ++
 arch/arm64/boot/dts/qcom/x1e80100-crd.dts                  | 2 ++
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 2 ++
 arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi   | 2 ++
 arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                  | 2 ++
 6 files changed, 12 insertions(+)

Comments

Stephan Gerhold Oct. 16, 2024, 3:44 p.m. UTC | #1
On Wed, Oct 16, 2024 at 04:51:06PM +0200, Johan Hovold wrote:
> The NVMe regulator has been left enabled by the boot firmware. Mark it
> as such to avoid disabling the regulator temporarily during boot.
> 
> Johan

These look good to me, thanks!

Can you or Aleksandrs send another one for the x1e80100-dell-xps13-9345
that was applied by Bjorn yesterday?

FWIW, for these patches:

Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>

> 
> 
> Johan Hovold (6):
>   arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
>   arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
>   arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
>     glitch
>   arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
>   arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
>     glitch
>   arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
> 
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 2 ++
>  arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts    | 2 ++
>  arch/arm64/boot/dts/qcom/x1e80100-crd.dts                  | 2 ++
>  arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 2 ++
>  arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi   | 2 ++
>  arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                  | 2 ++
>  6 files changed, 12 insertions(+)
> 
> -- 
> 2.45.2
>
Aleksandrs Vinarskis Oct. 16, 2024, 3:52 p.m. UTC | #2
On Wed, 16 Oct 2024 at 17:45, Stephan Gerhold
<stephan.gerhold@linaro.org> wrote:
>
> On Wed, Oct 16, 2024 at 04:51:06PM +0200, Johan Hovold wrote:
> > The NVMe regulator has been left enabled by the boot firmware. Mark it
> > as such to avoid disabling the regulator temporarily during boot.
> >
> > Johan
>
> These look good to me, thanks!
>
> Can you or Aleksandrs send another one for the x1e80100-dell-xps13-9345
> that was applied by Bjorn yesterday?

Hi,

Sure, will give it a quick test and mail it later tonight (along with
a few other fixes).

Alex

>
> FWIW, for these patches:
>
> Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>
>
> >
> >
> > Johan Hovold (6):
> >   arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
> >   arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
> >   arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
> >     glitch
> >   arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
> >   arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
> >     glitch
> >   arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
> >
> >  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 2 ++
> >  arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts    | 2 ++
> >  arch/arm64/boot/dts/qcom/x1e80100-crd.dts                  | 2 ++
> >  arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts   | 2 ++
> >  arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi   | 2 ++
> >  arch/arm64/boot/dts/qcom/x1e80100-qcp.dts                  | 2 ++
> >  6 files changed, 12 insertions(+)
> >
> > --
> > 2.45.2
> >
Konrad Dybcio Oct. 18, 2024, 12:33 a.m. UTC | #3
On 16.10.2024 4:51 PM, Johan Hovold wrote:
> The NVMe regulator has been left enabled by the boot firmware. Mark it
> as such to avoid disabling the regulator temporarily during boot.
> 
> Johan

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Bjorn Andersson Oct. 24, 2024, 2:59 p.m. UTC | #4
On Wed, 16 Oct 2024 16:51:06 +0200, Johan Hovold wrote:
> The NVMe regulator has been left enabled by the boot firmware. Mark it
> as such to avoid disabling the regulator temporarily during boot.
> 
> Johan
> 
> 
> Johan Hovold (6):
>   arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
>   arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
>   arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
>     glitch
>   arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
>   arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
>     glitch
>   arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
> 
> [...]

Applied, thanks!

[1/6] arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
      commit: dec19f1406fc5d73512cacdcf612e7bb161c2101
[2/6] arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
      commit: 37f9477ce9d07ed87f6efe9b99de580bc9d27df5
[3/6] arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot glitch
      commit: c6d151f61b6703124e14bc0eae98d05206e36e02
[4/6] arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
      commit: 1badd07e4c0e1ecfb187dcba05357c0f3e70e797
[5/6] arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot glitch
      commit: 5462190b11aa62a945dc2fd74e1531b9c1bc9952
[6/6] arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
      commit: 717f0637ffc6a6a59f838df94a7d61e643c98d62

Best regards,