mbox series

[v2,0/9] ARM: dts: Add some BCM6846 device tree

Message ID 20241016-genexis-xg6846b-base-v2-0-6a7cc2ee57eb@linaro.org (mailing list archive)
Headers show
Series ARM: dts: Add some BCM6846 device tree | expand

Message

Linus Walleij Oct. 16, 2024, 6:41 a.m. UTC
This adds some silicon blocks to the BCM6846 DTSI file and
adds a device tree for the Genexis XG6846B device that
make use of it.

This is mainly so as to get this off my hard drive and
share the basics with others who want to work on the
BCM6846.

I think most of the DTSI changes can be just copied verbatim
to the rest of the BCMBCA family (maybe extracted into a
common bcbca.dtsi?) but let's think about that later.
This will do for now.

The XG6846B device tree uses the new shift register bits
property of the BCM63138 LEDs, which is ACKed by the
DT maintainers albeit not yet merged in the LED tree.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Use the new "brcm,bcm6846-mdio" compatible for the MDIO block. (Merged
  to the netdev tree).
- Add the ARM PrimeCell PL081 DMA controller block.
- Link to v1: https://lore.kernel.org/r/20241011-genexis-xg6846b-base-v1-0-f04d6f6f93ce@linaro.org

---
Linus Walleij (9):
      ARM: dts: bcm6846: Add iproc rng
      ARM: dts: bcm6846: Enable watchdog
      ARM: dts: bcm6846: Add GPIO blocks
      ARM: dts: bcm6846: Add MDIO control block
      ARM: dts: bcm6846: Add LED controller
      ARM: dts: bcm6846: Add ARM PL081 DMA block
      dt-bindings: vendor-prefixes: Add Genexis
      dt-bindings: arm: bcmbca: Add Genexis XG6846B
      ARM: dts: broadcom: Add Genexis XG6846B DTS file

 .../devicetree/bindings/arm/bcm/brcm,bcmbca.yaml   |   1 +
 .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
 arch/arm/boot/dts/broadcom/Makefile                |   1 +
 .../boot/dts/broadcom/bcm6846-genexis-xg6846b.dts  | 244 +++++++++++++++++++++
 arch/arm/boot/dts/broadcom/bcm6846.dtsi            | 120 ++++++++++
 5 files changed, 368 insertions(+)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20241010-genexis-xg6846b-base-ef3fbec0be01

Best regards,

Comments

Linus Walleij Oct. 16, 2024, 7:49 a.m. UTC | #1
On Wed, Oct 16, 2024 at 8:41 AM Linus Walleij <linus.walleij@linaro.org> wrote:

> This adds some silicon blocks to the BCM6846 DTSI file and
> adds a device tree for the Genexis XG6846B device that
> make use of it.

Oh there were more warnings I hadn't seen, too big inbox.

OK rinse and repeat, adding ngpios to the gpio-mmio bindings
and fix up the MDIO address-cells.

Will send v3 when the GPIO binding has been accepted.

Yours,
Linus Walleij
Rob Herring (Arm) Oct. 16, 2024, 3:38 p.m. UTC | #2
On Wed, 16 Oct 2024 08:41:00 +0200, Linus Walleij wrote:
> This adds some silicon blocks to the BCM6846 DTSI file and
> adds a device tree for the Genexis XG6846B device that
> make use of it.
> 
> This is mainly so as to get this off my hard drive and
> share the basics with others who want to work on the
> BCM6846.
> 
> I think most of the DTSI changes can be just copied verbatim
> to the rest of the BCMBCA family (maybe extracted into a
> common bcbca.dtsi?) but let's think about that later.
> This will do for now.
> 
> The XG6846B device tree uses the new shift register bits
> property of the BCM63138 LEDs, which is ACKed by the
> DT maintainers albeit not yet merged in the LED tree.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes in v2:
> - Use the new "brcm,bcm6846-mdio" compatible for the MDIO block. (Merged
>   to the netdev tree).
> - Add the ARM PrimeCell PL081 DMA controller block.
> - Link to v1: https://lore.kernel.org/r/20241011-genexis-xg6846b-base-v1-0-f04d6f6f93ce@linaro.org
> 
> ---
> Linus Walleij (9):
>       ARM: dts: bcm6846: Add iproc rng
>       ARM: dts: bcm6846: Enable watchdog
>       ARM: dts: bcm6846: Add GPIO blocks
>       ARM: dts: bcm6846: Add MDIO control block
>       ARM: dts: bcm6846: Add LED controller
>       ARM: dts: bcm6846: Add ARM PL081 DMA block
>       dt-bindings: vendor-prefixes: Add Genexis
>       dt-bindings: arm: bcmbca: Add Genexis XG6846B
>       ARM: dts: broadcom: Add Genexis XG6846B DTS file
> 
>  .../devicetree/bindings/arm/bcm/brcm,bcmbca.yaml   |   1 +
>  .../devicetree/bindings/vendor-prefixes.yaml       |   2 +
>  arch/arm/boot/dts/broadcom/Makefile                |   1 +
>  .../boot/dts/broadcom/bcm6846-genexis-xg6846b.dts  | 244 +++++++++++++++++++++
>  arch/arm/boot/dts/broadcom/bcm6846.dtsi            | 120 ++++++++++
>  5 files changed, 368 insertions(+)
> ---
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> change-id: 20241010-genexis-xg6846b-base-ef3fbec0be01
> 
> Best regards,
> --
> Linus Walleij <linus.walleij@linaro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y broadcom/bcm6846-genexis-xg6846b.dtb' for 20241016-genexis-xg6846b-base-v2-0-6a7cc2ee57eb@linaro.org:

arch/arm/boot/dts/broadcom/bcm6846-genexis-xg6846b.dtb: gpio@508: 'ngpios' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/gpio/gpio-mmio.yaml#
arch/arm/boot/dts/broadcom/bcm6846-genexis-xg6846b.dtb: mdio@2060: #address-cells: 1 was expected
	from schema $id: http://devicetree.org/schemas/net/mdio.yaml#
arch/arm/boot/dts/broadcom/bcm6846-genexis-xg6846b.dtb: mdio@2060: #size-cells: 0 was expected
	from schema $id: http://devicetree.org/schemas/net/mdio.yaml#
arch/arm/boot/dts/broadcom/bcm6846-genexis-xg6846b.dtb: /bus@ff800000/mdio@2060: failed to match any schema with compatible: ['brcm,bcm6846-mdio']