[00/12] Module Validation Refactor

Message ID	20241015231651.3851138-1-mmaurer@google.com (mailing list archive)
Headers	show Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C3621E3DB for <linux-modules@vger.kernel.org>; Tue, 15 Oct 2024 23:16:59 +0000 (UTC) Date: Tue, 15 Oct 2024 23:16:34 +0000 Precedence: bulk Mime-Version: 1.0 Message-ID: <20241015231651.3851138-1-mmaurer@google.com> Subject: [PATCH 00/12] Module Validation Refactor From: Matthew Maurer <mmaurer@google.com> To: mcgrof@kernel.org Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, samitolvanen@google.com, Matthew Maurer <mmaurer@google.com> Content-Type: text/plain; charset="UTF-8"
Series	Module Validation Refactor \| expand [00/12] Module Validation Refactor [01/12] module: Take const arg in validate_section_offset [02/12] module: Factor out elf_validity_ehdr [03/12] module: Factor out elf_validity_cache_sechdrs [04/12] module: Factor out elf_validity_cache_secstrings [05/12] module: Factor out elf_validity_cache_index_info [06/12] module: Factor out elf_validity_cache_index_mod [07/12] module: Factor out elf_validity_cache_index_sym [08/12] module: Factor out elf_validity_cache_index_str [09/12] module: Group section index calculations together [10/12] module: Factor out elf_validity_cache_strtab [11/12] module: Additional validation in elf_validity_cache_strtab [12/12] module: Reformat struct for code style

Message ID

20241015231651.3851138-1-mmaurer@google.com (mailing list archive)

Headers

Date: Tue, 15 Oct 2024 23:16:34 +0000
Precedence: bulk
Mime-Version: 1.0
Message-ID: <20241015231651.3851138-1-mmaurer@google.com>
Subject: [PATCH 00/12] Module Validation Refactor
From: Matthew Maurer <mmaurer@google.com>
To: mcgrof@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	samitolvanen@google.com, Matthew Maurer <mmaurer@google.com>
Content-Type: text/plain; charset="UTF-8"

Series

Module Validation Refactor | expand

Message

Matthew Maurer Oct. 15, 2024, 11:16 p.m. UTC

Split out from Extended MODVERSIONS Support [1]

This series refactors module validation during loading to ensure that
everything is checked on its way in. This is intended to make the code
robust enough that we can more confidently add new pieces like extended
MODVERSIONS.

[1] https://lore.kernel.org/all/20240925233854.90072-1-mmaurer@google.com/

Matthew Maurer (12):
  module: Take const arg in validate_section_offset
  module: Factor out elf_validity_ehdr
  module: Factor out elf_validity_cache_sechdrs
  module: Factor out elf_validity_cache_secstrings
  module: Factor out elf_validity_cache_index_info
  module: Factor out elf_validity_cache_index_mod
  module: Factor out elf_validity_cache_index_sym
  module: Factor out elf_validity_cache_index_str
  module: Group section index calculations together
  module: Factor out elf_validity_cache_strtab
  module: Additional validation in elf_validity_cache_strtab
  module: Reformat struct for code style

 kernel/module/internal.h |   7 +-
 kernel/module/main.c     | 569 +++++++++++++++++++++++++++++----------
 2 files changed, 428 insertions(+), 148 deletions(-)

Comments

Sami Tolvanen Oct. 17, 2024, 12:44 a.m. UTC | #1

Hi,

On Tue, Oct 15, 2024 at 4:16 PM Matthew Maurer <mmaurer@google.com> wrote:
>
> Split out from Extended MODVERSIONS Support [1]
>
> This series refactors module validation during loading to ensure that
> everything is checked on its way in. This is intended to make the code
> robust enough that we can more confidently add new pieces like extended
> MODVERSIONS.
>
> [1] https://lore.kernel.org/all/20240925233854.90072-1-mmaurer@google.com/
>
> Matthew Maurer (12):
>   module: Take const arg in validate_section_offset
>   module: Factor out elf_validity_ehdr
>   module: Factor out elf_validity_cache_sechdrs
>   module: Factor out elf_validity_cache_secstrings
>   module: Factor out elf_validity_cache_index_info
>   module: Factor out elf_validity_cache_index_mod
>   module: Factor out elf_validity_cache_index_sym
>   module: Factor out elf_validity_cache_index_str
>   module: Group section index calculations together
>   module: Factor out elf_validity_cache_strtab
>   module: Additional validation in elf_validity_cache_strtab
>   module: Reformat struct for code style
>
>  kernel/module/internal.h |   7 +-
>  kernel/module/main.c     | 569 +++++++++++++++++++++++++++++----------
>  2 files changed, 428 insertions(+), 148 deletions(-)

Looks like these patches are unchanged from the pre-split version[1].
For the series:

Reviewed-by: Sami Tolvanen <samitolvanen@google.com>

[1] https://lore.kernel.org/linux-modules/20240925233854.90072-1-mmaurer@google.com/

Sami

Luis Chamberlain Oct. 19, 2024, 10:10 p.m. UTC | #2

On Tue, Oct 15, 2024 at 11:16:34PM +0000, Matthew Maurer wrote:
> Split out from Extended MODVERSIONS Support [1]
> 
> This series refactors module validation during loading to ensure that
> everything is checked on its way in. This is intended to make the code
> robust enough that we can more confidently add new pieces like extended
> MODVERSIONS.
> 
> [1] https://lore.kernel.org/all/20240925233854.90072-1-mmaurer@google.com/

Thanks! KPD [0] picked this up and ran automated tests for us using kdevops,
and the tests passed [1], I've included that into the last commit log and
pushed to modules-next [2].

[0] https://github.com/facebookincubator/kernel-patches-daemon
[1] https://github.com/linux-kdevops/linux-modules-kpd/actions/runs/11420095343
[2] git://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git

  Luis