| Message ID | 20240926024026.2539-2-hunter.yu@hj-micro.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | i2c: Add ACPI support for HJMC01 | expand |
On Thu, Sep 26, 2024 at 10:40:05AM GMT, hunter.yu wrote: > I2C clock frequency for HJMC01 is 200M, define a new ACPI > HID for it. > > Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> Do you want your name to be hunter.yu or Hunter Yu? I prefer the second and if you browse the git log, you can see that everyone uses Name Surnmae. Andi
On Thu, Oct 3, 2024 at 12:13 AM Andi Shyti <andi.shyti@kernel.org> wrote: > > On Thu, Sep 26, 2024 at 10:40:05AM GMT, hunter.yu wrote: > > I2C clock frequency for HJMC01 is 200M, define a new ACPI > > HID for it. > > > > Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> > > Do you want your name to be hunter.yu or Hunter Yu? I prefer the > second and if you browse the git log, you can see that everyone > uses Name Surname. It must be a real name as per submitting-patches.rst The S-o-b is meaningless otherwise.
On Wed, Oct 16, 2024 at 10:45:26PM +0200, Rafael J. Wysocki wrote: > On Thu, Oct 3, 2024 at 12:13 AM Andi Shyti <andi.shyti@kernel.org> wrote: > > On Thu, Sep 26, 2024 at 10:40:05AM GMT, hunter.yu wrote: > > > I2C clock frequency for HJMC01 is 200M, define a new ACPI > > > HID for it. > > > > > > Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> > > > > Do you want your name to be hunter.yu or Hunter Yu? I prefer the > > second and if you browse the git log, you can see that everyone > > uses Name Surname. > > It must be a real name as per submitting-patches.rst Hasn't this been relaxed last year by the d4563201f33a ("Documentation: simplify and clarify DCO contribution example language")? > The S-o-b is meaningless otherwise.
On Thu, Oct 17, 2024 at 12:26:18PM +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2024 at 10:45:26PM +0200, Rafael J. Wysocki wrote: > > On Thu, Oct 3, 2024 at 12:13 AM Andi Shyti <andi.shyti@kernel.org> wrote: > > > On Thu, Sep 26, 2024 at 10:40:05AM GMT, hunter.yu wrote: > > > > I2C clock frequency for HJMC01 is 200M, define a new ACPI > > > > HID for it. > > > > > > > > Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> > > > > > > Do you want your name to be hunter.yu or Hunter Yu? I prefer the > > > second and if you browse the git log, you can see that everyone > > > uses Name Surname. > > > > It must be a real name as per submitting-patches.rst > > Hasn't this been relaxed last year by the d4563201f33a ("Documentation: > simplify and clarify DCO contribution example language")? Note, I do not imply that the existing variant in this patch is ideal, I also, as Andi, prefer the proper spellings on the "name" parts. > > The S-o-b is meaningless otherwise.
On Thu, Oct 17, 2024 at 11:29 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Oct 17, 2024 at 12:26:18PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 16, 2024 at 10:45:26PM +0200, Rafael J. Wysocki wrote: > > > On Thu, Oct 3, 2024 at 12:13 AM Andi Shyti <andi.shyti@kernel.org> wrote: > > > > On Thu, Sep 26, 2024 at 10:40:05AM GMT, hunter.yu wrote: > > > > > I2C clock frequency for HJMC01 is 200M, define a new ACPI > > > > > HID for it. > > > > > > > > > > Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> > > > > > > > > Do you want your name to be hunter.yu or Hunter Yu? I prefer the > > > > second and if you browse the git log, you can see that everyone > > > > uses Name Surname. > > > > > > It must be a real name as per submitting-patches.rst > > > > Hasn't this been relaxed last year by the d4563201f33a ("Documentation: > > simplify and clarify DCO contribution example language")? > > Note, I do not imply that the existing variant in this patch is ideal, I also, > as Andi, prefer the proper spellings on the "name" parts. Good. Now, the way I understand the "known identity" part of the document is that a misspelled name is not sufficient.
On 2024/10/17 4:45, Rafael J. Wysocki wrote: > On Thu, Oct 3, 2024 at 12:13 AM Andi Shyti <andi.shyti@kernel.org> wrote: >> >> On Thu, Sep 26, 2024 at 10:40:05AM GMT, hunter.yu wrote: >>> I2C clock frequency for HJMC01 is 200M, define a new ACPI >>> HID for it. >>> >>> Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> >> >> Do you want your name to be hunter.yu or Hunter Yu? I prefer the >> second and if you browse the git log, you can see that everyone >> uses Name Surname. > > It must be a real name as per submitting-patches.rst > > The S-o-b is meaningless otherwise. > Thanks for your help and advice. In our team, everyone have an alias name, which is the same as email address. I feel sorry for not noticing kernel community's requirement for real name. My real name is Xiangyang Yu, I will use the following format to send v3 patch later. Signed-off-by: Xiangyang Yu <hunter.yu@hj-micro.com>
diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 800f97868448..229e80a19664 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -181,6 +181,11 @@ static const struct apd_device_desc hip08_spi_desc = { .setup = acpi_apd_setup, .fixed_clk_rate = 250000000, }; + +static const struct apd_device_desc hjmc_i2c_desc = { + .setup = acpi_apd_setup, + .fixed_clk_rate = 200000000, +}; #endif /* CONFIG_ARM64 */ #endif @@ -251,6 +256,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = { { "HISI02A2", APD_ADDR(hip08_i2c_desc) }, { "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) }, { "HISI0173", APD_ADDR(hip08_spi_desc) }, + { "HJMC3001", APD_ADDR(hjmc_i2c_desc) }, { "NXP0001", APD_ADDR(nxp_i2c_desc) }, #endif { }
I2C clock frequency for HJMC01 is 200M, define a new ACPI HID for it. Signed-off-by: hunter.yu <hunter.yu@hj-micro.com> --- drivers/acpi/acpi_apd.c | 6 ++++++ 1 file changed, 6 insertions(+)