| Message ID | 20241017101144.1654085-1-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b8e6d7ce50673c39514921ac61f7af00bbb58b87 |
| Delegated to: | Ira Weiny |
| Headers | show |
| Series | dax: delete a stale directory pmem | expand |
Harshit Mogalapalli wrote: > After commit: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") the pmem/ > directory is not needed anymore and Makefile changes were made > accordingly in this commit, but there is a Makefile and pmem.c in pmem/ > which are now stale and pmem.c is empty, remove them. > > Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") > Suggested-by: Vegard Nossum <vegard.nossum@oracle.com> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- > drivers/dax/pmem/Makefile | 7 ------- > drivers/dax/pmem/pmem.c | 10 ---------- > 2 files changed, 17 deletions(-) > delete mode 100644 drivers/dax/pmem/Makefile > delete mode 100644 drivers/dax/pmem/pmem.c Oh, indeed, good catch. Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Harshit Mogalapalli wrote: > After commit: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") the pmem/ > directory is not needed anymore and Makefile changes were made > accordingly in this commit, but there is a Makefile and pmem.c in pmem/ > which are now stale and pmem.c is empty, remove them. > > Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") > Suggested-by: Vegard Nossum <vegard.nossum@oracle.com> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Marked for nvdimm-next Thanks! Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > drivers/dax/pmem/Makefile | 7 ------- > drivers/dax/pmem/pmem.c | 10 ---------- > 2 files changed, 17 deletions(-) > delete mode 100644 drivers/dax/pmem/Makefile > delete mode 100644 drivers/dax/pmem/pmem.c > > diff --git a/drivers/dax/pmem/Makefile b/drivers/dax/pmem/Makefile > deleted file mode 100644 > index 191c31f0d4f0..000000000000 > --- a/drivers/dax/pmem/Makefile > +++ /dev/null > @@ -1,7 +0,0 @@ > -# SPDX-License-Identifier: GPL-2.0-only > -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem.o > -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem_core.o > - > -dax_pmem-y := pmem.o > -dax_pmem_core-y := core.o > -dax_pmem_compat-y := compat.o > diff --git a/drivers/dax/pmem/pmem.c b/drivers/dax/pmem/pmem.c > deleted file mode 100644 > index dfe91a2990fe..000000000000 > --- a/drivers/dax/pmem/pmem.c > +++ /dev/null > @@ -1,10 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 > -/* Copyright(c) 2016 - 2018 Intel Corporation. All rights reserved. */ > -#include <linux/percpu-refcount.h> > -#include <linux/memremap.h> > -#include <linux/module.h> > -#include <linux/pfn_t.h> > -#include <linux/nd.h> > -#include "../bus.h" > - > - > -- > 2.46.0 > >
diff --git a/drivers/dax/pmem/Makefile b/drivers/dax/pmem/Makefile deleted file mode 100644 index 191c31f0d4f0..000000000000 --- a/drivers/dax/pmem/Makefile +++ /dev/null @@ -1,7 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem.o -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem_core.o - -dax_pmem-y := pmem.o -dax_pmem_core-y := core.o -dax_pmem_compat-y := compat.o diff --git a/drivers/dax/pmem/pmem.c b/drivers/dax/pmem/pmem.c deleted file mode 100644 index dfe91a2990fe..000000000000 --- a/drivers/dax/pmem/pmem.c +++ /dev/null @@ -1,10 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright(c) 2016 - 2018 Intel Corporation. All rights reserved. */ -#include <linux/percpu-refcount.h> -#include <linux/memremap.h> -#include <linux/module.h> -#include <linux/pfn_t.h> -#include <linux/nd.h> -#include "../bus.h" - -
After commit: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") the pmem/ directory is not needed anymore and Makefile changes were made accordingly in this commit, but there is a Makefile and pmem.c in pmem/ which are now stale and pmem.c is empty, remove them. Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") Suggested-by: Vegard Nossum <vegard.nossum@oracle.com> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- drivers/dax/pmem/Makefile | 7 ------- drivers/dax/pmem/pmem.c | 10 ---------- 2 files changed, 17 deletions(-) delete mode 100644 drivers/dax/pmem/Makefile delete mode 100644 drivers/dax/pmem/pmem.c