| Message ID | b168d5c7-704b-4452-84f9-1c1762b1f4ce@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ff1d3484d6d29dda92421b9a753e4ca54f91aa8a |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable | expand |
On 16/10/2024 17:41, Dan Carpenter wrote: > The *ndev pointer needs to be set or it leads to an uninitialized variable > bug in the caller. > > Fixes: 4a7b2ba94a59 ("net: ethernet: ti: am65-cpsw: Use tstats instead of open coded version") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Thanks Dan for this fix! Reviewed-by: Roger Quadros <rogerq@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Andrew Lunn <andrew@lunn.ch>: On Wed, 16 Oct 2024 17:41:44 +0300 you wrote: > The *ndev pointer needs to be set or it leads to an uninitialized variable > bug in the caller. > > Fixes: 4a7b2ba94a59 ("net: ethernet: ti: am65-cpsw: Use tstats instead of open coded version") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 + > 1 files changed, 1 insertion(+) Here is the summary with links: - [net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable https://git.kernel.org/netdev/net-next/c/ff1d3484d6d2 You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index cda7ddfe6845..fe1f2fa0ff9c 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -1341,6 +1341,7 @@ am65_cpsw_nuss_tx_compl_packet_xdp(struct am65_cpsw_common *common, port = am65_common_get_port(common, port_id); dev_sw_netstats_tx_add(port->ndev, 1, xdpf->len); + *ndev = port->ndev; return xdpf; }
The *ndev pointer needs to be set or it leads to an uninitialized variable bug in the caller. Fixes: 4a7b2ba94a59 ("net: ethernet: ti: am65-cpsw: Use tstats instead of open coded version") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 + 1 files changed, 1 insertion(+)