| Message ID | 20241018064813.2750016-4-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm: lcdif: Use drm_bridge_connector | expand |
Am Freitag, 18. Oktober 2024, 08:48:11 CEST schrieb Liu Ying: > Add a HDMI connector to connect with i.MX8MP HDMI TX output. > This is a preparation for making the i.MX8MP LCDIF driver use > drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag. With that flag, the DW HDMI bridge core driver would > try to attach the next bridge which is the HDMI connector. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> Looks similar to imx8mp-tqma8mpql-mba8mpxl.dts, so: Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > index 83194ea7cb81..b776646a258a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > @@ -15,6 +15,17 @@ / { > "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", > "fsl,imx8mp"; > > + hdmi-connector { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_in: endpoint { > + remote-endpoint = <&hdmi_tx_out>; > + }; > + }; > + }; > + > reg_vcc_3v3_audio: 3v3-audio-regulator { > compatible = "regulator-fixed"; > regulator-name = "VCC_3V3_AUD"; > @@ -54,6 +65,14 @@ &hdmi_tx { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_hdmi>; > status = "okay"; > + > + ports { > + port@1 { > + hdmi_tx_out: endpoint { > + remote-endpoint = <&hdmi_in>; > + }; > + }; > + }; > }; > > &hdmi_tx_phy { >
On 10/18/24 8:48 AM, Liu Ying wrote: > Add a HDMI connector to connect with i.MX8MP HDMI TX output. > This is a preparation for making the i.MX8MP LCDIF driver use > drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag. With that flag, the DW HDMI bridge core driver would > try to attach the next bridge which is the HDMI connector. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > index 83194ea7cb81..b776646a258a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts > @@ -15,6 +15,17 @@ / { > "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", > "fsl,imx8mp"; > > + hdmi-connector { > + compatible = "hdmi-connector"; > + type = "a"; Shouldn't this also have a 'label' property ?
On 10/18/2024, Marek Vasut wrote: > On 10/18/24 8:48 AM, Liu Ying wrote: >> Add a HDMI connector to connect with i.MX8MP HDMI TX output. >> This is a preparation for making the i.MX8MP LCDIF driver use >> drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR >> flag. With that flag, the DW HDMI bridge core driver would >> try to attach the next bridge which is the HDMI connector. >> >> Signed-off-by: Liu Ying <victor.liu@nxp.com> >> --- >> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >> index 83194ea7cb81..b776646a258a 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >> @@ -15,6 +15,17 @@ / { >> "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", >> "fsl,imx8mp"; >> + hdmi-connector { >> + compatible = "hdmi-connector"; >> + type = "a"; > Shouldn't this also have a 'label' property ? 'label' property is not required by hdmi-connector.yaml and there are in-tree hdmi-connector nodes that haven't got it. I tried to find schematics for the board online, but failed. I don't have the board to see the label printed in silk layer, either. If anyone can provide a valid label name, I may add it.
On 10/18/24 11:00 AM, Liu Ying wrote: > On 10/18/2024, Marek Vasut wrote: >> On 10/18/24 8:48 AM, Liu Ying wrote: >>> Add a HDMI connector to connect with i.MX8MP HDMI TX output. >>> This is a preparation for making the i.MX8MP LCDIF driver use >>> drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR >>> flag. With that flag, the DW HDMI bridge core driver would >>> try to attach the next bridge which is the HDMI connector. >>> >>> Signed-off-by: Liu Ying <victor.liu@nxp.com> >>> --- >>> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>> index 83194ea7cb81..b776646a258a 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>> @@ -15,6 +15,17 @@ / { >>> "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", >>> "fsl,imx8mp"; >>> + hdmi-connector { >>> + compatible = "hdmi-connector"; >>> + type = "a"; >> Shouldn't this also have a 'label' property ? > > 'label' property is not required by hdmi-connector.yaml and there > are in-tree hdmi-connector nodes that haven't got it. > I tried to find schematics for the board online, but failed. > I don't have the board to see the label printed in silk layer, either. > > If anyone can provide a valid label name, I may add it. For the Kontron board, Frieder might be able to look it up for you ? For the MSC one, hmmm, I am not sure. Anyone ?
On 18.10.24 11:35 AM, Marek Vasut wrote: > On 10/18/24 11:00 AM, Liu Ying wrote: >> On 10/18/2024, Marek Vasut wrote: >>> On 10/18/24 8:48 AM, Liu Ying wrote: >>>> Add a HDMI connector to connect with i.MX8MP HDMI TX output. >>>> This is a preparation for making the i.MX8MP LCDIF driver use >>>> drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR >>>> flag. With that flag, the DW HDMI bridge core driver would >>>> try to attach the next bridge which is the HDMI connector. >>>> >>>> Signed-off-by: Liu Ying <victor.liu@nxp.com> >>>> --- >>>> .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 19 ++++++++++++++ >>>> +++++ >>>> 1 file changed, 19 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>>> b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>>> index 83194ea7cb81..b776646a258a 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts >>>> @@ -15,6 +15,17 @@ / { >>>> "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", >>>> "fsl,imx8mp"; >>>> + hdmi-connector { >>>> + compatible = "hdmi-connector"; >>>> + type = "a"; >>> Shouldn't this also have a 'label' property ? >> >> 'label' property is not required by hdmi-connector.yaml and there >> are in-tree hdmi-connector nodes that haven't got it. >> I tried to find schematics for the board online, but failed. >> I don't have the board to see the label printed in silk layer, either. >> >> If anyone can provide a valid label name, I may add it. > For the Kontron board, Frieder might be able to look it up for you ? The Kontron PCB doesn't have a silkscreen label for the connector. The schematic has the label "X801" for the part and the signals on the connector are prefixed with "HDMI_CON".
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts index 83194ea7cb81..b776646a258a 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-msc-sm2s-ep1.dts @@ -15,6 +15,17 @@ / { "avnet,sm2s-imx8mp-14N0600E", "avnet,sm2s-imx8mp", "fsl,imx8mp"; + hdmi-connector { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_in: endpoint { + remote-endpoint = <&hdmi_tx_out>; + }; + }; + }; + reg_vcc_3v3_audio: 3v3-audio-regulator { compatible = "regulator-fixed"; regulator-name = "VCC_3V3_AUD"; @@ -54,6 +65,14 @@ &hdmi_tx { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_hdmi>; status = "okay"; + + ports { + port@1 { + hdmi_tx_out: endpoint { + remote-endpoint = <&hdmi_in>; + }; + }; + }; }; &hdmi_tx_phy {
Add a HDMI connector to connect with i.MX8MP HDMI TX output. This is a preparation for making the i.MX8MP LCDIF driver use drm_bridge_connector which requires the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. With that flag, the DW HDMI bridge core driver would try to attach the next bridge which is the HDMI connector. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- .../dts/freescale/imx8mp-msc-sm2s-ep1.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)