| Message ID | 20240929100750.860329-7-ryan@testtoast.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ASoC: add Allwinner H616 audio codec support | expand |
On Sun, 29 Sep 2024 23:06:07 +1300 Ryan Walklin <ryan@testtoast.com> wrote: Hi Ryan, > Now that the sun4i codec driver supports the H616, add a node in the > device tree for it. Can you please add another patch that actually enables the codec for at least one board? Is that really just status = "okay";? Or do we need simple-soundcard nodes still? I will try to give it a test on the H61* boards I have, and would then like those boards to be enabled as well, as part of this series. Otherwise it's somewhat of a dead feature, isn't it? Cheers, Andre > Signed-off-by: Ryan Walklin <ryan@testtoast.com> > --- > arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > index e88c1fbac6acc..006fdb7e7e0ae 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > @@ -645,6 +645,21 @@ spdif: spdif@5093000 { > status = "disabled"; > }; > > + codec: codec@05096000 { > + #sound-dai-cells = <0>; > + compatible = "allwinner,sun50i-h616-codec"; > + reg = <0x05096000 0x31c>; > + interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ccu CLK_BUS_AUDIO_CODEC>, > + <&ccu CLK_AUDIO_CODEC_1X>, > + <&ccu CLK_AUDIO_CODEC_4X>; > + clock-names = "apb", "codec", "audio-codec-4x"; > + resets = <&ccu RST_BUS_AUDIO_CODEC>; > + dmas = <&dma 6>; > + dma-names = "tx"; > + status = "disabled"; > + }; > + > gpadc: adc@5070000 { > compatible = "allwinner,sun50i-h616-gpadc", > "allwinner,sun20i-d1-gpadc";
On Tue, 8 Oct 2024 13:37:18 +0100 Andre Przywara <andre.przywara@arm.com> wrote: Hi, > On Sun, 29 Sep 2024 23:06:07 +1300 > Ryan Walklin <ryan@testtoast.com> wrote: > > Hi Ryan, > > > Now that the sun4i codec driver supports the H616, add a node in the > > device tree for it. > > Can you please add another patch that actually enables the codec for at > least one board? Is that really just status = "okay";? Or do we need > simple-soundcard nodes still? For the records: We don't need simple-soundcard, but we seem to need an audio routing entry. So I tested this successfully on the X96 Mate with: &codec { allwinner,audio-routing = "Line Out", "LINEOUT"; status = "okay"; }; So can you add a patch adding those properties to the boards with a 3.5mm jack? The OrangePi Zero2 and Zero3 do not have such a jack, but route the LINEOUT signals to dedicated pins on the 13-pin header. Not sure that counts? Cheers, Andre > I will try to give it a test on the H61* boards I have, and would then > like those boards to be enabled as well, as part of this series. Otherwise > it's somewhat of a dead feature, isn't it? > > Cheers, > Andre > > > Signed-off-by: Ryan Walklin <ryan@testtoast.com> > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > > index e88c1fbac6acc..006fdb7e7e0ae 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi > > @@ -645,6 +645,21 @@ spdif: spdif@5093000 { > > status = "disabled"; > > }; > > > > + codec: codec@05096000 { > > + #sound-dai-cells = <0>; > > + compatible = "allwinner,sun50i-h616-codec"; > > + reg = <0x05096000 0x31c>; > > + interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ccu CLK_BUS_AUDIO_CODEC>, > > + <&ccu CLK_AUDIO_CODEC_1X>, > > + <&ccu CLK_AUDIO_CODEC_4X>; > > + clock-names = "apb", "codec", "audio-codec-4x"; > > + resets = <&ccu RST_BUS_AUDIO_CODEC>; > > + dmas = <&dma 6>; > > + dma-names = "tx"; > > + status = "disabled"; > > + }; > > + > > gpadc: adc@5070000 { > > compatible = "allwinner,sun50i-h616-gpadc", > > "allwinner,sun20i-d1-gpadc"; >
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi index e88c1fbac6acc..006fdb7e7e0ae 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi @@ -645,6 +645,21 @@ spdif: spdif@5093000 { status = "disabled"; }; + codec: codec@05096000 { + #sound-dai-cells = <0>; + compatible = "allwinner,sun50i-h616-codec"; + reg = <0x05096000 0x31c>; + interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_AUDIO_CODEC>, + <&ccu CLK_AUDIO_CODEC_1X>, + <&ccu CLK_AUDIO_CODEC_4X>; + clock-names = "apb", "codec", "audio-codec-4x"; + resets = <&ccu RST_BUS_AUDIO_CODEC>; + dmas = <&dma 6>; + dma-names = "tx"; + status = "disabled"; + }; + gpadc: adc@5070000 { compatible = "allwinner,sun50i-h616-gpadc", "allwinner,sun20i-d1-gpadc";
Now that the sun4i codec driver supports the H616, add a node in the device tree for it. Signed-off-by: Ryan Walklin <ryan@testtoast.com> --- arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)