mbox series

[v2,0/3] arm64: dts: mediatek: Add MT8186 Chinchou

Message ID 20241018091135.17075-1-xiazhengqiao@huaqin.corp-partner.google.com (mailing list archive)
Headers show
Series arm64: dts: mediatek: Add MT8186 Chinchou | expand

Message

Zhengqiao Xia Oct. 18, 2024, 9:11 a.m. UTC
This is v2 of the MT8186 Chromebook device tree series to support
MT8186 chinchou platform. It is based on the "corsola" design.
It includes chinchou and chinchou360, including LTE, stylus,
touchscreen combinations.

Changes in v2:
- Modify location of "const: google,chinchou-sku17" in mediatek.yaml
- rename "pin-report" to "pin-report-pins"
- add "vcc33-supply" and "vcc33-supply" 
- rename "cbj-sleeve-gpio" to "cbj-sleeve-gpios"
- modify subnode of sound 
- Link to v1: https://lore.kernel.org/all/172900161180.733089.8963543745385219831.robh@kernel.org/

Zhengqiao Xia (3):
  dt-bindings: arm: mediatek: Add MT8186 Chinchou Chromebook
  arm64: dts: mediatek: Add MT8186 Chinchou Chromebooks
  arm64: dts: mediatek: Add exton node for DP bridge

 .../devicetree/bindings/arm/mediatek.yaml     |  29 ++
 arch/arm64/boot/dts/mediatek/Makefile         |   3 +
 .../mediatek/mt8186-corsola-chinchou-sku0.dts |  18 +
 .../mediatek/mt8186-corsola-chinchou-sku1.dts |  35 ++
 .../mt8186-corsola-chinchou-sku16.dts         |  29 ++
 .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 321 ++++++++++++++++++
 .../boot/dts/mediatek/mt8186-corsola.dtsi     |   6 +
 7 files changed, 441 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi

Comments

Rob Herring (Arm) Oct. 18, 2024, 12:52 p.m. UTC | #1
On Fri, 18 Oct 2024 17:11:32 +0800, Zhengqiao Xia wrote:
> This is v2 of the MT8186 Chromebook device tree series to support
> MT8186 chinchou platform. It is based on the "corsola" design.
> It includes chinchou and chinchou360, including LTE, stylus,
> touchscreen combinations.
> 
> Changes in v2:
> - Modify location of "const: google,chinchou-sku17" in mediatek.yaml
> - rename "pin-report" to "pin-report-pins"
> - add "vcc33-supply" and "vcc33-supply"
> - rename "cbj-sleeve-gpio" to "cbj-sleeve-gpios"
> - modify subnode of sound
> - Link to v1: https://lore.kernel.org/all/172900161180.733089.8963543745385219831.robh@kernel.org/
> 
> Zhengqiao Xia (3):
>   dt-bindings: arm: mediatek: Add MT8186 Chinchou Chromebook
>   arm64: dts: mediatek: Add MT8186 Chinchou Chromebooks
>   arm64: dts: mediatek: Add exton node for DP bridge
> 
>  .../devicetree/bindings/arm/mediatek.yaml     |  29 ++
>  arch/arm64/boot/dts/mediatek/Makefile         |   3 +
>  .../mediatek/mt8186-corsola-chinchou-sku0.dts |  18 +
>  .../mediatek/mt8186-corsola-chinchou-sku1.dts |  35 ++
>  .../mt8186-corsola-chinchou-sku16.dts         |  29 ++
>  .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 321 ++++++++++++++++++
>  .../boot/dts/mediatek/mt8186-corsola.dtsi     |   6 +
>  7 files changed, 441 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> 
> --
> 2.17.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-chinchou-sku0.dtb mediatek/mt8186-corsola-chinchou-sku1.dtb mediatek/mt8186-corsola-chinchou-sku16.dtb' for 20241018091135.17075-1-xiazhengqiao@huaqin.corp-partner.google.com:

arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
Hsin-Yi Wang Oct. 19, 2024, 1:18 a.m. UTC | #2
On Fri, Oct 18, 2024 at 5:52 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Fri, 18 Oct 2024 17:11:32 +0800, Zhengqiao Xia wrote:
> > This is v2 of the MT8186 Chromebook device tree series to support
> > MT8186 chinchou platform. It is based on the "corsola" design.
> > It includes chinchou and chinchou360, including LTE, stylus,
> > touchscreen combinations.
> >
> > Changes in v2:
> > - Modify location of "const: google,chinchou-sku17" in mediatek.yaml
> > - rename "pin-report" to "pin-report-pins"
> > - add "vcc33-supply" and "vcc33-supply"
> > - rename "cbj-sleeve-gpio" to "cbj-sleeve-gpios"
> > - modify subnode of sound
> > - Link to v1: https://lore.kernel.org/all/172900161180.733089.8963543745385219831.robh@kernel.org/
> >
> > Zhengqiao Xia (3):
> >   dt-bindings: arm: mediatek: Add MT8186 Chinchou Chromebook
> >   arm64: dts: mediatek: Add MT8186 Chinchou Chromebooks
> >   arm64: dts: mediatek: Add exton node for DP bridge
> >
> >  .../devicetree/bindings/arm/mediatek.yaml     |  29 ++
> >  arch/arm64/boot/dts/mediatek/Makefile         |   3 +
> >  .../mediatek/mt8186-corsola-chinchou-sku0.dts |  18 +
> >  .../mediatek/mt8186-corsola-chinchou-sku1.dts |  35 ++
> >  .../mt8186-corsola-chinchou-sku16.dts         |  29 ++
> >  .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 321 ++++++++++++++++++
> >  .../boot/dts/mediatek/mt8186-corsola.dtsi     |   6 +
> >  7 files changed, 441 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> >
> > --
> > 2.17.1
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>   pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-chinchou-sku0.dtb mediatek/mt8186-corsola-chinchou-sku1.dtb mediatek/mt8186-corsola-chinchou-sku16.dtb' for 20241018091135.17075-1-xiazhengqiao@huaqin.corp-partner.google.com:
>
> arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
> arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
> arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: pmic: 'codec' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml#
>

hi Zhengqiao,

This appears after
https://patchwork.kernel.org/project/linux-mediatek/patch/20241001104145.24054-3-macpaul.lin@mediatek.com/.
To avoid this warning, change `codec` in pmic (in mt8186-corsola.dtsi)
to `audio-codec`, though this is not caused by this series.

>
>
>
>