| Message ID | 20241017-airoha-en7581-reset-bql-v1-1-08c0c9888de5@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] net: airoha: Reset BQL stopping the netdevice | expand |
On 2024-10-17 at 19:31:41, Lorenzo Bianconi (lorenzo@kernel.org) wrote: > Run airoha_qdma_cleanup_tx_queue() in ndo_stop callback in order to > unmap pending skbs. Moreover, reset BQL txq state stopping the netdevice, > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>
Hello: This patch was applied to netdev/net-next.git (main) by Andrew Lunn <andrew@lunn.ch>: On Thu, 17 Oct 2024 16:01:41 +0200 you wrote: > Run airoha_qdma_cleanup_tx_queue() in ndo_stop callback in order to > unmap pending skbs. Moreover, reset BQL txq state stopping the netdevice, > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > drivers/net/ethernet/mediatek/airoha_eth.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > [...] Here is the summary with links: - [net-next] net: airoha: Reset BQL stopping the netdevice https://git.kernel.org/netdev/net-next/c/c9f947769b77 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c index 836a957aad77bec972c536567a4ee7d304ac7b52..23905f54f991fc8062542b890fbf002154676612 100644 --- a/drivers/net/ethernet/mediatek/airoha_eth.c +++ b/drivers/net/ethernet/mediatek/airoha_eth.c @@ -2341,7 +2341,7 @@ static int airoha_dev_stop(struct net_device *dev) { struct airoha_gdm_port *port = netdev_priv(dev); struct airoha_qdma *qdma = port->qdma; - int err; + int i, err; netif_tx_disable(dev); err = airoha_set_gdm_ports(qdma->eth, false); @@ -2352,6 +2352,14 @@ static int airoha_dev_stop(struct net_device *dev) GLOBAL_CFG_TX_DMA_EN_MASK | GLOBAL_CFG_RX_DMA_EN_MASK); + for (i = 0; i < ARRAY_SIZE(qdma->q_tx); i++) { + if (!qdma->q_tx[i].ndesc) + continue; + + airoha_qdma_cleanup_tx_queue(&qdma->q_tx[i]); + netdev_tx_reset_subqueue(dev, i); + } + return 0; }
Run airoha_qdma_cleanup_tx_queue() in ndo_stop callback in order to unmap pending skbs. Moreover, reset BQL txq state stopping the netdevice, Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- drivers/net/ethernet/mediatek/airoha_eth.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) --- base-commit: e60fa8ebc2af54c2f62cc4ed63b85894dabf9101 change-id: 20241017-airoha-en7581-reset-bql-45e4bd5c20d1 Best regards,