| Message ID | 20241010-input_automate_of_node_put-v1-9-ebc62138fbf8@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | input: automate of_node_put() calls for device_node | expand |
On Thu, Oct 10, 2024 at 11:25:59PM +0200, Javier Carrasco wrote: > Use the '__free(device_node)' macro to automatically free the device > node, removing the need for explicit calls to 'of_node_put()' to > decrement its refcount. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Applied, thank you.
diff --git a/drivers/input/touchscreen/raspberrypi-ts.c b/drivers/input/touchscreen/raspberrypi-ts.c index 45c575df994e..841d39a449b3 100644 --- a/drivers/input/touchscreen/raspberrypi-ts.c +++ b/drivers/input/touchscreen/raspberrypi-ts.c @@ -122,20 +122,18 @@ static int rpi_ts_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; struct input_dev *input; - struct device_node *fw_node; struct rpi_firmware *fw; struct rpi_ts *ts; u32 touchbuf; int error; - fw_node = of_get_parent(np); + struct device_node *fw_node __free(device_node) = of_get_parent(np); if (!fw_node) { dev_err(dev, "Missing firmware node\n"); return -ENOENT; } fw = devm_rpi_firmware_get(&pdev->dev, fw_node); - of_node_put(fw_node); if (!fw) return -EPROBE_DEFER;
Use the '__free(device_node)' macro to automatically free the device node, removing the need for explicit calls to 'of_node_put()' to decrement its refcount. Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- drivers/input/touchscreen/raspberrypi-ts.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)