| Message ID | 20241018160658.781564-1-tharvey@gateworks.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ee76eb24343bdd5450eb87572865a4d7fffd335b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v4] net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x | expand |
On Fri, Oct 18, 2024 at 09:06:58AM -0700, Tim Harvey wrote: > The well-known errata regarding EEE not being functional on various KSZ > switches has been refactored a few times. Recently the refactoring has > excluded several switches that the errata should also apply to. > > Disable EEE for additional switches with this errata and provide > additional comments referring to the public errata document. > > The original workaround for the errata was applied with a register > write to manually disable the EEE feature in MMD 7:60 which was being > applied for KSZ9477/KSZ9897/KSZ9567 switch ID's. > > Then came commit 26dd2974c5b5 ("net: phy: micrel: Move KSZ9477 errata > fixes to PHY driver") and commit 6068e6d7ba50 ("net: dsa: microchip: > remove KSZ9477 PHY errata handling") which moved the errata from the > switch driver to the PHY driver but only for PHY_ID_KSZ9477 (PHY ID) > however that PHY code was dead code because an entry was never added > for PHY_ID_KSZ9477 via MODULE_DEVICE_TABLE. > > This was apparently realized much later and commit 54a4e5c16382 ("net: > phy: micrel: add Microchip KSZ 9477 to the device table") added the > PHY_ID_KSZ9477 to the PHY driver but as the errata was only being > applied to PHY_ID_KSZ9477 it's not completely clear what switches > that relates to. > > Later commit 6149db4997f5 ("net: phy: micrel: fix KSZ9477 PHY issues > after suspend/resume") breaks this again for all but KSZ9897 by only > applying the errata for that PHY ID. > > Following that this was affected with commit 08c6d8bae48c("net: phy: > Provide Module 4 KSZ9477 errata (DS80000754C)") which removes > the blatant register write to MMD 7:60 and replaces it by > setting phydev->eee_broken_modes = -1 so that the generic phy-c45 code > disables EEE but this is only done for the KSZ9477_CHIP_ID (Switch ID). > > Lastly commit 0411f73c13af ("net: dsa: microchip: disable EEE for > KSZ8567/KSZ9567/KSZ9896/KSZ9897.") adds some additional switches > that were missing to the errata due to the previous changes. > > This commit adds an additional set of switches. > > Fixes: 0411f73c13af ("net: dsa: microchip: disable EEE for KSZ8567/KSZ9567/KSZ9896/KSZ9897.") > Signed-off-by: Tim Harvey <tharvey@gateworks.com> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you!
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 18 Oct 2024 09:06:58 -0700 you wrote: > The well-known errata regarding EEE not being functional on various KSZ > switches has been refactored a few times. Recently the refactoring has > excluded several switches that the errata should also apply to. > > Disable EEE for additional switches with this errata and provide > additional comments referring to the public errata document. > > [...] Here is the summary with links: - [net,v4] net: dsa: microchip: disable EEE for KSZ879x/KSZ877x/KSZ876x https://git.kernel.org/netdev/net/c/ee76eb24343b You are awesome, thank you!
From: Pieter Van Trappen <pieter.van.trappen@cern.ch>
Hi Tim, all,
Sorry I'm a bit late to the party but I think this patch is not doing
much since most if not all KSZ8 switches don't have MMD
registers. They do have EEE registers but these require indirect
access that's not compatible with PHY MMD (indirect) registers as far
as I understand. So your patch does no harm but is not doing anything
useful either I reckon.
For the KSZ8 devices, the EEE errata is handled from the DSA switch
driver ksz8.c, ksz8_handle_global_errata.
Cheers, Pieter
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 4e8710c7cb7b..5290f5ad98f3 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -2733,26 +2733,27 @@ static u32 ksz_get_phy_flags(struct dsa_switch *ds, int port) return MICREL_KSZ8_P1_ERRATA; break; case KSZ8567_CHIP_ID: + /* KSZ8567R Errata DS80000752C Module 4 */ + case KSZ8765_CHIP_ID: + case KSZ8794_CHIP_ID: + case KSZ8795_CHIP_ID: + /* KSZ879x/KSZ877x/KSZ876x Errata DS80000687C Module 2 */ case KSZ9477_CHIP_ID: + /* KSZ9477S Errata DS80000754A Module 4 */ case KSZ9567_CHIP_ID: + /* KSZ9567S Errata DS80000756A Module 4 */ case KSZ9896_CHIP_ID: + /* KSZ9896C Errata DS80000757A Module 3 */ case KSZ9897_CHIP_ID: - /* KSZ9477 Errata DS80000754C - * - * Module 4: Energy Efficient Ethernet (EEE) feature select must - * be manually disabled + /* KSZ9897R Errata DS80000758C Module 4 */ + /* Energy Efficient Ethernet (EEE) feature select must be manually disabled * The EEE feature is enabled by default, but it is not fully * operational. It must be manually disabled through register * controls. If not disabled, the PHY ports can auto-negotiate * to enable EEE, and this feature can cause link drops when * linked to another device supporting EEE. * - * The same item appears in the errata for the KSZ9567, KSZ9896, - * and KSZ9897. - * - * A similar item appears in the errata for the KSZ8567, but - * provides an alternative workaround. For now, use the simple - * workaround of disabling the EEE feature for this device too. + * The same item appears in the errata for all switches above. */ return MICREL_NO_EEE; }
The well-known errata regarding EEE not being functional on various KSZ switches has been refactored a few times. Recently the refactoring has excluded several switches that the errata should also apply to. Disable EEE for additional switches with this errata and provide additional comments referring to the public errata document. The original workaround for the errata was applied with a register write to manually disable the EEE feature in MMD 7:60 which was being applied for KSZ9477/KSZ9897/KSZ9567 switch ID's. Then came commit 26dd2974c5b5 ("net: phy: micrel: Move KSZ9477 errata fixes to PHY driver") and commit 6068e6d7ba50 ("net: dsa: microchip: remove KSZ9477 PHY errata handling") which moved the errata from the switch driver to the PHY driver but only for PHY_ID_KSZ9477 (PHY ID) however that PHY code was dead code because an entry was never added for PHY_ID_KSZ9477 via MODULE_DEVICE_TABLE. This was apparently realized much later and commit 54a4e5c16382 ("net: phy: micrel: add Microchip KSZ 9477 to the device table") added the PHY_ID_KSZ9477 to the PHY driver but as the errata was only being applied to PHY_ID_KSZ9477 it's not completely clear what switches that relates to. Later commit 6149db4997f5 ("net: phy: micrel: fix KSZ9477 PHY issues after suspend/resume") breaks this again for all but KSZ9897 by only applying the errata for that PHY ID. Following that this was affected with commit 08c6d8bae48c("net: phy: Provide Module 4 KSZ9477 errata (DS80000754C)") which removes the blatant register write to MMD 7:60 and replaces it by setting phydev->eee_broken_modes = -1 so that the generic phy-c45 code disables EEE but this is only done for the KSZ9477_CHIP_ID (Switch ID). Lastly commit 0411f73c13af ("net: dsa: microchip: disable EEE for KSZ8567/KSZ9567/KSZ9896/KSZ9897.") adds some additional switches that were missing to the errata due to the previous changes. This commit adds an additional set of switches. Fixes: 0411f73c13af ("net: dsa: microchip: disable EEE for KSZ8567/KSZ9567/KSZ9896/KSZ9897.") Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- v4: rebase on top of latest v3: added missing fixes tag v2: added fixes tag and history of issue --- drivers/net/dsa/microchip/ksz_common.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-)