| Message ID | 20241004121235.1916273-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: imx6qdl-tx6: Remove 'turn-on-delay-ms' | expand |
On Fri, 04 Oct 2024 09:12:35 -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The 'turn-on-delay-ms' property is not documented nor used anywhere else. > > Remove this invalid property to fix the following dt-schema warning: > > Unevaluated properties are not allowed ('turn-on-delay-ms' was unexpected) > > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts | 1 - > arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts | 1 - > arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts | 1 - > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi | 1 - > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi | 2 -- > 5 files changed, 6 deletions(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y nxp/imx/imx6dl-tx6dl-comtft.dtb nxp/imx/imx6q-tx6q-1010-comtft.dtb nxp/imx/imx6q-tx6q-1020-comtft.dtb' for 20241004121235.1916273-1-festevam@gmail.com: arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dtb: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml#
On Fri, Oct 4, 2024 at 9:45 PM Rob Herring (Arm) <robh@kernel.org> wrote: > New warnings running 'make CHECK_DTBS=y nxp/imx/imx6dl-tx6dl-comtft.dtb nxp/imx/imx6q-tx6q-1010-comtft.dtb nxp/imx/imx6q-tx6q-1020-comtft.dtb' for 20241004121235.1916273-1-festevam@gmail.com: > > arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dtb: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# This is unrelated. I have sent a separate fix for this warning.
Hi, > From: Fabio Estevam <festevam@denx.de> > > The 'turn-on-delay-ms' property is not documented nor used anywhere else. > > Remove this invalid property to fix the following dt-schema warning: > > Unevaluated properties are not allowed ('turn-on-delay-ms' was unexpected) > > Signed-off-by: Fabio Estevam <festevam@denx.de> Acked-by: Lothar Waßmann <LW@KARO-electronics.de> > --- > arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts | 1 - > arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts | 1 - > arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts | 1 - > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi | 1 - > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi | 2 -- > 5 files changed, 6 deletions(-) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts > index 51a9bb9d6bc2..7436626673fc 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts > +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts > @@ -51,7 +51,6 @@ / { > > &backlight { > pwms = <&pwm2 0 500000 0>; > - /delete-property/ turn-on-delay-ms; > }; > > &can1 { > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts > index ac3050a835e5..393bfec58e2f 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts > +++ b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts > @@ -51,7 +51,6 @@ / { > > &backlight { > pwms = <&pwm2 0 500000 0>; > - /delete-property/ turn-on-delay-ms; > }; > > &can1 { > diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts > index a773f252816c..1ab175ffa238 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts > +++ b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts > @@ -51,7 +51,6 @@ / { > > &backlight { > pwms = <&pwm2 0 500000 0>; > - /delete-property/ turn-on-delay-ms; > }; > > &can1 { > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi > index ded241a39906..77594546ef37 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi > @@ -51,7 +51,6 @@ backlight: backlight { > pinctrl-0 = <&pinctrl_lcd1_pwr>; > enable-gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>; > power-supply = <®_3v3>; > - turn-on-delay-ms = <35>; > /* > * a poor man's way to create a 1:1 relationship between > * the PWM value and the actual duty cycle > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi > index 99ec7a838f8d..bae7313d729d 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi > @@ -42,13 +42,11 @@ > / { > backlight0 { > pwms = <&pwm1 0 500000 PWM_POLARITY_INVERTED>; > - turn-on-delay-ms = <35>; > power-supply = <®_lcd1_pwr>; > }; > > backlight1 { > pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>; > - turn-on-delay-ms = <35>; > power-supply = <®_lcd1_pwr>; > }; > Lothar Waßmann
On Fri, Oct 04, 2024 at 09:12:35AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The 'turn-on-delay-ms' property is not documented nor used anywhere else. > > Remove this invalid property to fix the following dt-schema warning: > > Unevaluated properties are not allowed ('turn-on-delay-ms' was unexpected) > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts index 51a9bb9d6bc2..7436626673fc 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-tx6dl-comtft.dts @@ -51,7 +51,6 @@ / { &backlight { pwms = <&pwm2 0 500000 0>; - /delete-property/ turn-on-delay-ms; }; &can1 { diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts index ac3050a835e5..393bfec58e2f 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1010-comtft.dts @@ -51,7 +51,6 @@ / { &backlight { pwms = <&pwm2 0 500000 0>; - /delete-property/ turn-on-delay-ms; }; &can1 { diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts index a773f252816c..1ab175ffa238 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6q-tx6q-1020-comtft.dts @@ -51,7 +51,6 @@ / { &backlight { pwms = <&pwm2 0 500000 0>; - /delete-property/ turn-on-delay-ms; }; &can1 { diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi index ded241a39906..77594546ef37 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-lcd.dtsi @@ -51,7 +51,6 @@ backlight: backlight { pinctrl-0 = <&pinctrl_lcd1_pwr>; enable-gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>; power-supply = <®_3v3>; - turn-on-delay-ms = <35>; /* * a poor man's way to create a 1:1 relationship between * the PWM value and the actual duty cycle diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi index 99ec7a838f8d..bae7313d729d 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6-mb7.dtsi @@ -42,13 +42,11 @@ / { backlight0 { pwms = <&pwm1 0 500000 PWM_POLARITY_INVERTED>; - turn-on-delay-ms = <35>; power-supply = <®_lcd1_pwr>; }; backlight1 { pwms = <&pwm2 0 500000 PWM_POLARITY_INVERTED>; - turn-on-delay-ms = <35>; power-supply = <®_lcd1_pwr>; };