| Message ID | 20241016173617.217736-1-tariqt@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net/mlx5: Refactor esw QoS to support generalized operations | expand |
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Wed, 16 Oct 2024 20:36:02 +0300 you wrote: > Hi, > > This patch series from the team to mlx5 core driver consists of one main > QoS part followed by small misc patches. > > This main part (patches 1 to 11) by Carolina refactors the QoS handling > to generalize operations on scheduling groups and vports. These changes > are necessary to support new features that will extend group > functionality, introduce new group types, and support deeper > hierarchies. > > [...] Here is the summary with links: - [net-next,V3,01/15] net/mlx5: Refactor QoS group scheduling element creation https://git.kernel.org/netdev/net-next/c/700814fa41ce - [net-next,V3,02/15] net/mlx5: Introduce node type to rate group structure https://git.kernel.org/netdev/net-next/c/4235fe2cb8e9 - [net-next,V3,03/15] net/mlx5: Add parent group support in rate group structure https://git.kernel.org/netdev/net-next/c/54200dbc685c - [net-next,V3,04/15] net/mlx5: Restrict domain list insertion to root TSAR ancestors https://git.kernel.org/netdev/net-next/c/24e54e870d11 - [net-next,V3,05/15] net/mlx5: Rename vport QoS group reference to parent https://git.kernel.org/netdev/net-next/c/72a1d121fa6b - [net-next,V3,06/15] net/mlx5: Introduce node struct and rename group terminology to node https://git.kernel.org/netdev/net-next/c/1c25d4388ba6 - [net-next,V3,07/15] net/mlx5: Refactor vport scheduling element creation function https://git.kernel.org/netdev/net-next/c/88d5fbcb7ba0 - [net-next,V3,08/15] net/mlx5: Refactor vport QoS to use scheduling node structure https://git.kernel.org/netdev/net-next/c/045815fe329a - [net-next,V3,09/15] net/mlx5: Remove vport QoS enabled flag https://git.kernel.org/netdev/net-next/c/ebecc37befb1 - [net-next,V3,10/15] net/mlx5: Simplify QoS scheduling element configuration https://git.kernel.org/netdev/net-next/c/70744a46aabf - [net-next,V3,11/15] net/mlx5: Generalize QoS operations for nodes and vports https://git.kernel.org/netdev/net-next/c/a1903bf50f2e - [net-next,V3,12/15] net/mlx5: Add sync reset drop mode support https://git.kernel.org/netdev/net-next/c/b37f3f2be0f4 - [net-next,V3,13/15] net/mlx5: Only create VEPA flow table when in VEPA mode https://git.kernel.org/netdev/net-next/c/f0ac6209460e - [net-next,V3,14/15] net/mlx5: fs, rename packet reformat struct member action https://git.kernel.org/netdev/net-next/c/1715f0a73233 - [net-next,V3,15/15] net/mlx5: fs, rename modify header struct member action https://git.kernel.org/netdev/net-next/c/7b919caaeb18 You are awesome, thank you!
Hi, This patch series from the team to mlx5 core driver consists of one main QoS part followed by small misc patches. This main part (patches 1 to 11) by Carolina refactors the QoS handling to generalize operations on scheduling groups and vports. These changes are necessary to support new features that will extend group functionality, introduce new group types, and support deeper hierarchies. Additionally, this refactor updates the terminology from "group" to "node" to better reflect the hardware’s rate hierarchy and its use of scheduling element nodes. Simplify group scheduling element creation: - net/mlx5: Refactor QoS group scheduling element creation Refactor to support generalized operations for QoS: - net/mlx5: Introduce node type to rate group structure - net/mlx5: Add parent group support in rate group structure - net/mlx5: Restrict domain list insertion to root TSAR ancestors - net/mlx5: Rename vport QoS group reference to parent - net/mlx5: Introduce node struct and rename group terminology to node - net/mlx5: Refactor vport scheduling element creation function - net/mlx5: Refactor vport QoS to use scheduling node structure - net/mlx5: Remove vport QoS enabled flag Support generalized operations for QoS elements: - net/mlx5: Simplify QoS scheduling element configuration - net/mlx5: Generalize QoS operations for nodes and vports On top, patch 12 by Moshe handles FW request to move to drop mode. In patch 13, Benjamin Poirier removes an empty eswitch flow table when not used, which improves packet processing performance. Patches 14 and 15 by Moshe are small field renamings as preparation for future fields addition to these structures. Series generated against: commit c531f2269a53 ("net: bcmasp: enable SW timestamping") Regards, Tariq V3: - Fixed potential NULL dereference for vport sched_node. - Updated the check in esw_qos_normalize_min_rate to stop on leafs. V2: - Declared int err separately to fix the type mismatch with u32. - Fixed potential NULL dereference in the node allocation error path. - Removed "rate_node" renamings, as it referred to the old "rate_group". - Replaced 0 with NULL in mlx5_esw_qos_vport_get_parent. - Fixed vport node allocation error path. - Initialized dev in mlx5_esw_qos_vport_disable. - Access vport_node->esw directly where possible. Benjamin Poirier (1): net/mlx5: Only create VEPA flow table when in VEPA mode Carolina Jubran (11): net/mlx5: Refactor QoS group scheduling element creation net/mlx5: Introduce node type to rate group structure net/mlx5: Add parent group support in rate group structure net/mlx5: Restrict domain list insertion to root TSAR ancestors net/mlx5: Rename vport QoS group reference to parent net/mlx5: Introduce node struct and rename group terminology to node net/mlx5: Refactor vport scheduling element creation function net/mlx5: Refactor vport QoS to use scheduling node structure net/mlx5: Remove vport QoS enabled flag net/mlx5: Simplify QoS scheduling element configuration net/mlx5: Generalize QoS operations for nodes and vports Moshe Shemesh (3): net/mlx5: Add sync reset drop mode support net/mlx5: fs, rename packet reformat struct member action net/mlx5: fs, rename modify header struct member action .../mellanox/mlx5/core/en/tc/ct_fs_smfs.c | 4 +- .../mellanox/mlx5/core/esw/devlink_port.c | 2 +- .../mlx5/core/esw/diag/qos_tracepoint.h | 53 +- .../ethernet/mellanox/mlx5/core/esw/legacy.c | 27 +- .../net/ethernet/mellanox/mlx5/core/esw/qos.c | 669 +++++++++--------- .../net/ethernet/mellanox/mlx5/core/esw/qos.h | 3 + .../net/ethernet/mellanox/mlx5/core/eswitch.c | 2 + .../net/ethernet/mellanox/mlx5/core/eswitch.h | 25 +- .../net/ethernet/mellanox/mlx5/core/fs_core.h | 4 +- .../ethernet/mellanox/mlx5/core/fw_reset.c | 9 +- .../mellanox/mlx5/core/steering/fs_dr.c | 35 +- 11 files changed, 435 insertions(+), 398 deletions(-)