| Message ID | 20241019163439.274656-1-kuforiji98@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 91687cd13f91ac04ce1ba91e5716e178543cf3fa |
| Headers | show |
| Series | [v2,Outreachy] t7011: ensure no whitespace after redirect | expand |
On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote: > This change updates the script to conform to the coding standards > outlined in the Git project's documentation. According to the guidelines > in Documentation/CodingGuidelines under "Redirection operators", there > should be no whitespace after redirection operators. > > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com> > --- > t/t7011-skip-worktree-reading.sh | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) I can confirm that there are no changes in this version to the patch itself. Which was expected since the change was good. The difference in this version is that the commit message has been improved. At least according to my taste. Thanks
On Sat, Oct 19, 2024 at 07:54:30PM +0200, Kristoffer Haugsbakk wrote: > On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote: > > This change updates the script to conform to the coding standards > > outlined in the Git project's documentation. According to the guidelines > > in Documentation/CodingGuidelines under "Redirection operators", there > > should be no whitespace after redirection operators. > > > > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com> > > --- > > t/t7011-skip-worktree-reading.sh | 22 +++++++++++----------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > I can confirm that there are no changes in this version to the patch > itself. Which was expected since the change was good. > > The difference in this version is that the commit message has been > improved. At least according to my taste. Agreed, this patch looks good to me, too. Thanks! Patrick
On Mon, 21 Oct 2024 at 13:03, Patrick Steinhardt <ps@pks.im> wrote: > > On Sat, Oct 19, 2024 at 07:54:30PM +0200, Kristoffer Haugsbakk wrote: > > On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote: > > > This change updates the script to conform to the coding standards > > > outlined in the Git project's documentation. According to the guidelines > > > in Documentation/CodingGuidelines under "Redirection operators", there > > > should be no whitespace after redirection operators. > > > > > > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com> > > > --- > > > t/t7011-skip-worktree-reading.sh | 22 +++++++++++----------- > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > I can confirm that there are no changes in this version to the patch > > itself. Which was expected since the change was good. > > > > The difference in this version is that the commit message has been > > improved. At least according to my taste. > > Agreed, this patch looks good to me, too. Thanks! > > Patrick Yay! Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk Regards Seyi
On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote: > Yay! > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk Thanks, all. Let's start merging this one down. Thanks, Taylor
On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote: > > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote: > > Yay! > > > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk > > Thanks, all. Let's start merging this one down. > > Thanks, > Taylor Thanks, Taylor! I've also discovered that the test script t9101-git-svn-props.sh also requires the same update done in this patch. Is this test script currently being worked on? @Patrick Steinhardt Thanks Seyi
On Tue, Oct 22, 2024 at 06:11:17PM +0100, Seyi Chamber wrote: > On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote: > > > > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote: > > > Yay! > > > > > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk > > > > Thanks, all. Let's start merging this one down. > > > > Thanks, > > Taylor > > Thanks, Taylor! > > I've also discovered that the test script t9101-git-svn-props.sh also > requires the same update done in this patch. > Is this test script currently being worked on? @Patrick Steinhardt Not that I'd know of. I typically double check via lore by searching for the relevant subsystem [1]. This only surfaces your mail and the Meson patch series, so at least nobody else has communicated intent to work on it. Patrick [1]: https://lore.kernel.org/git/?q=t9101
On Wed, 23 Oct 2024 at 06:00, Patrick Steinhardt <ps@pks.im> wrote: > > On Tue, Oct 22, 2024 at 06:11:17PM +0100, Seyi Chamber wrote: > > On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote: > > > > > > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote: > > > > Yay! > > > > > > > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk > > > > > > Thanks, all. Let's start merging this one down. > > > > > > Thanks, > > > Taylor > > > > Thanks, Taylor! > > > > I've also discovered that the test script t9101-git-svn-props.sh also > > requires the same update done in this patch. > > Is this test script currently being worked on? @Patrick Steinhardt > > Not that I'd know of. I typically double check via lore by searching for > the relevant subsystem [1]. This only surfaces your mail and the Meson > patch series, so at least nobody else has communicated intent to work on > it. > > Patrick > > [1]: https://lore.kernel.org/git/?q=t9101 Thanks, Patrick. In the future, would you prefer I still run it by you before working on a test script, or should I apply the same strategy you mentioned in your reply? Regards Seyi
On Wed, Oct 23, 2024 at 08:24:18AM +0100, Seyi Chamber wrote: > On Wed, 23 Oct 2024 at 06:00, Patrick Steinhardt <ps@pks.im> wrote: > > > > On Tue, Oct 22, 2024 at 06:11:17PM +0100, Seyi Chamber wrote: > > > On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote: > > > > > > > > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote: > > > > > Yay! > > > > > > > > > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk > > > > > > > > Thanks, all. Let's start merging this one down. > > > > > > > > Thanks, > > > > Taylor > > > > > > Thanks, Taylor! > > > > > > I've also discovered that the test script t9101-git-svn-props.sh also > > > requires the same update done in this patch. > > > Is this test script currently being worked on? @Patrick Steinhardt > > > > Not that I'd know of. I typically double check via lore by searching for > > the relevant subsystem [1]. This only surfaces your mail and the Meson > > patch series, so at least nobody else has communicated intent to work on > > it. > > > > Patrick > > > > [1]: https://lore.kernel.org/git/?q=t9101 > > Thanks, Patrick. > > In the future, would you prefer I still run it by you before working > on a test script, > or should I apply the same strategy you mentioned in your reply? There's no need to run it by anybody, so please feel free to use the same strategy. Patrick
diff --git a/t/t7011-skip-worktree-reading.sh b/t/t7011-skip-worktree-reading.sh index 4adac5acd5..c86abd99bf 100755 --- a/t/t7011-skip-worktree-reading.sh +++ b/t/t7011-skip-worktree-reading.sh @@ -32,24 +32,24 @@ setup_absent() { } test_absent() { - echo "100644 $EMPTY_BLOB 0 1" > expected && - git ls-files --stage 1 > result && + echo "100644 $EMPTY_BLOB 0 1" >expected && + git ls-files --stage 1 >result && test_cmp expected result && test ! -f 1 } setup_dirty() { git update-index --force-remove 1 && - echo dirty > 1 && + echo dirty >1 && git update-index --add --cacheinfo 100644 $EMPTY_BLOB 1 && git update-index --skip-worktree 1 } test_dirty() { - echo "100644 $EMPTY_BLOB 0 1" > expected && - git ls-files --stage 1 > result && + echo "100644 $EMPTY_BLOB 0 1" >expected && + git ls-files --stage 1 >result && test_cmp expected result && - echo dirty > expected + echo dirty >expected test_cmp expected 1 } @@ -59,7 +59,7 @@ test_expect_success 'setup' ' touch ./1 ./2 sub/1 sub/2 && git add 1 2 sub/1 sub/2 && git update-index --skip-worktree 1 sub/1 && - git ls-files -t > result && + git ls-files -t >result && test_cmp expect.skip result ' @@ -86,7 +86,7 @@ test_expect_success 'update-index --remove' ' setup_dirty && git update-index --remove 1 && test -z "$(git ls-files 1)" && - echo dirty > expected && + echo dirty >expected && test_cmp expected 1 ' @@ -110,16 +110,16 @@ test_expect_success 'ls-files --modified' ' test -z "$(git ls-files -m)" ' -echo ":000000 100644 $ZERO_OID $EMPTY_BLOB A 1" > expected +echo ":000000 100644 $ZERO_OID $EMPTY_BLOB A 1" >expected test_expect_success 'diff-index does not examine skip-worktree absent entries' ' setup_absent && - git diff-index HEAD -- 1 > result && + git diff-index HEAD -- 1 >result && test_cmp expected result ' test_expect_success 'diff-index does not examine skip-worktree dirty entries' ' setup_dirty && - git diff-index HEAD -- 1 > result && + git diff-index HEAD -- 1 >result && test_cmp expected result '
This change updates the script to conform to the coding standards outlined in the Git project's documentation. According to the guidelines in Documentation/CodingGuidelines under "Redirection operators", there should be no whitespace after redirection operators. Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com> --- t/t7011-skip-worktree-reading.sh | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)