diff mbox series

[2/6] dt-bindings: mfd: mediatek: mt6397: Add bindings for MT6328

Message ID 20241018081050.23592-3-y.oudjana@protonmail.com (mailing list archive)
State New, archived
Headers show
Series MediaTek MT6735+MT6328 SoC/PMIC pair base support | expand

Commit Message

Yassine Oudjana Oct. 18, 2024, 8:10 a.m. UTC 
From: Yassine Oudjana <y.oudjana@protonmail.com>

Add compatible strings for the MT6328 PMIC.

Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
---
 Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml | 1 +
 Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml      | 2 ++
 2 files changed, 3 insertions(+)

Comments

Rob Herring (Arm) Oct. 18, 2024, 1:38 p.m. UTC | #1 
On Fri, 18 Oct 2024 11:10:44 +0300, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
> 
> Add compatible strings for the MT6328 PMIC.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
>  Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml | 1 +
>  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml      | 2 ++
>  2 files changed, 3 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
AngeloGioacchino Del Regno Oct. 21, 2024, 1:25 p.m. UTC | #2 
Il 18/10/24 10:10, Yassine Oudjana ha scritto:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
> 
> Add compatible strings for the MT6328 PMIC.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Lee Jones Oct. 31, 2024, 4:19 p.m. UTC | #3 
On Fri, 18 Oct 2024, Yassine Oudjana wrote:

> From: Yassine Oudjana <y.oudjana@protonmail.com>
> 
> Add compatible strings for the MT6328 PMIC.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
>  Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml | 1 +
>  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml      | 2 ++

Doesn't seem to apply cleanly.

Please rebase and resubmit.
Rob Herring (Arm) Nov. 19, 2024, 1:50 p.m. UTC | #4 
On Thu, Oct 31, 2024 at 11:19 AM Lee Jones <lee@kernel.org> wrote:
>
> On Fri, 18 Oct 2024, Yassine Oudjana wrote:
>
> > From: Yassine Oudjana <y.oudjana@protonmail.com>
> >
> > Add compatible strings for the MT6328 PMIC.
> >
> > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> > ---
> >  Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml | 1 +
> >  Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml      | 2 ++
>
> Doesn't seem to apply cleanly.
>
> Please rebase and resubmit.

mediatek,mt6328 is now flagged as undocumented. Please resend this.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
index 466566ae7f103..6a0e66fba53c4 100644
--- a/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
+++ b/Documentation/devicetree/bindings/input/mediatek,pmic-keys.yaml
@@ -25,6 +25,7 @@  properties:
   compatible:
     enum:
       - mediatek,mt6323-keys
+      - mediatek,mt6328-keys
       - mediatek,mt6331-keys
       - mediatek,mt6357-keys
       - mediatek,mt6358-keys
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
index 95e9566fc535d..224b9b1bd629d 100644
--- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
+++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
@@ -35,6 +35,7 @@  properties:
       - enum:
           - mediatek,mt6323
           - mediatek,mt6331 # "mediatek,mt6331" for PMIC MT6331 and MT6332.
+          - mediatek,mt6328
           - mediatek,mt6358
           - mediatek,mt6359
           - mediatek,mt6397
@@ -85,6 +86,7 @@  properties:
         oneOf:
           - enum:
               - mediatek,mt6323-regulator
+              - mediatek,mt6328-regulator
               - mediatek,mt6358-regulator
               - mediatek,mt6397-regulator
           - items: