diff mbox series

[PATCH/RFC] MAINTAINERS: Re-add cancelled Renesas driver sections

Message ID 0a189e2c4090a1b308e18005d2552e335bac354f.1729511337.git.geert+renesas@glider.be (mailing list archive)
State Superseded
Headers show
Series [PATCH/RFC] MAINTAINERS: Re-add cancelled Renesas driver sections | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Geert Uytterhoeven Oct. 21, 2024, 11:56 a.m. UTC
Removing full driver sections also removed mailing list entries, causing
submitters of future patches to forget CCing these mailing lists.

Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Anyone who wants to take over maintenance for these drivers?
Thanks in advance!
---
 MAINTAINERS | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

Comments

Greg Kroah-Hartman Oct. 21, 2024, 12:13 p.m. UTC | #1
On Mon, Oct 21, 2024 at 01:56:51PM +0200, Geert Uytterhoeven wrote:
> Removing full driver sections also removed mailing list entries, causing
> submitters of future patches to forget CCing these mailing lists.
> 
> Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Simon Horman Oct. 21, 2024, 1:40 p.m. UTC | #2
On Mon, Oct 21, 2024 at 01:56:51PM +0200, Geert Uytterhoeven wrote:
> Removing full driver sections also removed mailing list entries, causing
> submitters of future patches to forget CCing these mailing lists.
> 
> Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms@kernel.org>
Sergey Shtylyov Oct. 21, 2024, 2:10 p.m. UTC | #3
On 10/21/24 2:56 PM, Geert Uytterhoeven wrote:

> Removing full driver sections also removed mailing list entries, causing
> submitters of future patches to forget CCing these mailing lists.
> 
> Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")

   It looks like nobody had seen this one before merging... :-/

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

   Thank you for informing me of the situation and fixing up Greg's patch!

> ---
> Anyone who wants to take over maintenance for these drivers?

   I could use my Gmail address again (I did use it back in 2020 for some time)
but looking at the removed Baikal entries, this probably is not going to fly...
   BTW, OMP is not interested in the Renesas drivers or the PATA drivers
themselves; they were interested in hiring an official maintainer/reviewer
like me... :-)

[...]
MBR, Sergey
Niklas Söderlund Oct. 21, 2024, 3:04 p.m. UTC | #4
Hello Geert,

On 2024-10-21 13:56:51 +0200, Geert Uytterhoeven wrote:
> Removing full driver sections also removed mailing list entries, causing
> submitters of future patches to forget CCing these mailing lists.
> 
> Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Anyone who wants to take over maintenance for these drivers?

In case Sergei is not interested to keep looking after the RAVB and/or 
SUPERH Ethernet drivers I would be happy to do so.

In either case should not the maintainer entry in the bindings documents
also be updated?

> Thanks in advance!
> ---
>  MAINTAINERS | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f04cba42a59301fa..97a23cea2729942e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19521,6 +19521,14 @@ S:	Supported
>  F:	Documentation/devicetree/bindings/i2c/renesas,iic-emev2.yaml
>  F:	drivers/i2c/busses/i2c-emev2.c
>  
> +RENESAS ETHERNET AVB DRIVER
> +L:	netdev@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +F:	Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +F:	drivers/net/ethernet/renesas/Kconfig
> +F:	drivers/net/ethernet/renesas/Makefile
> +F:	drivers/net/ethernet/renesas/ravb*
> +
>  RENESAS ETHERNET SWITCH DRIVER
>  R:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>  L:	netdev@vger.kernel.org
> @@ -19570,6 +19578,13 @@ F:	Documentation/devicetree/bindings/i2c/renesas,rmobile-iic.yaml
>  F:	drivers/i2c/busses/i2c-rcar.c
>  F:	drivers/i2c/busses/i2c-sh_mobile.c
>  
> +RENESAS R-CAR SATA DRIVER
> +L:	linux-ide@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +S:	Supported
> +F:	Documentation/devicetree/bindings/ata/renesas,rcar-sata.yaml
> +F:	drivers/ata/sata_rcar.c
> +
>  RENESAS R-CAR THERMAL DRIVERS
>  M:	Niklas Söderlund <niklas.soderlund@ragnatech.se>
>  L:	linux-renesas-soc@vger.kernel.org
> @@ -19645,6 +19660,15 @@ S:	Supported
>  F:	Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
>  F:	drivers/i2c/busses/i2c-rzv2m.c
>  
> +RENESAS SUPERH ETHERNET DRIVER
> +L:	netdev@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +F:	Documentation/devicetree/bindings/net/renesas,ether.yaml
> +F:	drivers/net/ethernet/renesas/Kconfig
> +F:	drivers/net/ethernet/renesas/Makefile
> +F:	drivers/net/ethernet/renesas/sh_eth*
> +F:	include/linux/sh_eth.h
> +
>  RENESAS USB PHY DRIVER
>  M:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>  L:	linux-renesas-soc@vger.kernel.org
> -- 
> 2.34.1
>
Niklas Cassel Oct. 21, 2024, 3:11 p.m. UTC | #5
On Mon, Oct 21, 2024 at 01:56:51PM +0200, Geert Uytterhoeven wrote:
> Removing full driver sections also removed mailing list entries, causing
> submitters of future patches to forget CCing these mailing lists.
> 
> Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Anyone who wants to take over maintenance for these drivers?
> Thanks in advance!
> ---
>  MAINTAINERS | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f04cba42a59301fa..97a23cea2729942e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19521,6 +19521,14 @@ S:	Supported
>  F:	Documentation/devicetree/bindings/i2c/renesas,iic-emev2.yaml
>  F:	drivers/i2c/busses/i2c-emev2.c
>  
> +RENESAS ETHERNET AVB DRIVER
> +L:	netdev@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +F:	Documentation/devicetree/bindings/net/renesas,etheravb.yaml
> +F:	drivers/net/ethernet/renesas/Kconfig
> +F:	drivers/net/ethernet/renesas/Makefile
> +F:	drivers/net/ethernet/renesas/ravb*
> +
>  RENESAS ETHERNET SWITCH DRIVER
>  R:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>  L:	netdev@vger.kernel.org
> @@ -19570,6 +19578,13 @@ F:	Documentation/devicetree/bindings/i2c/renesas,rmobile-iic.yaml
>  F:	drivers/i2c/busses/i2c-rcar.c
>  F:	drivers/i2c/busses/i2c-sh_mobile.c
>  
> +RENESAS R-CAR SATA DRIVER
> +L:	linux-ide@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +S:	Supported

Seems a bit weird to keep the "S: Supported" line, if there is no
"M: " or "R: " entry. I suggest you kill it.

Regardless:
Acked-by: Niklas Cassel <cassel@kernel.org>


> +F:	Documentation/devicetree/bindings/ata/renesas,rcar-sata.yaml
> +F:	drivers/ata/sata_rcar.c
> +
>  RENESAS R-CAR THERMAL DRIVERS
>  M:	Niklas Söderlund <niklas.soderlund@ragnatech.se>
>  L:	linux-renesas-soc@vger.kernel.org
> @@ -19645,6 +19660,15 @@ S:	Supported
>  F:	Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
>  F:	drivers/i2c/busses/i2c-rzv2m.c
>  
> +RENESAS SUPERH ETHERNET DRIVER
> +L:	netdev@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +F:	Documentation/devicetree/bindings/net/renesas,ether.yaml
> +F:	drivers/net/ethernet/renesas/Kconfig
> +F:	drivers/net/ethernet/renesas/Makefile
> +F:	drivers/net/ethernet/renesas/sh_eth*
> +F:	include/linux/sh_eth.h
> +
>  RENESAS USB PHY DRIVER
>  M:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>  L:	linux-renesas-soc@vger.kernel.org
> -- 
> 2.34.1
>
Sergey Shtylyov Oct. 21, 2024, 3:40 p.m. UTC | #6
On 10/21/24 6:04 PM, Niklas Söderlund wrote:
[...]

>> Removing full driver sections also removed mailing list entries, causing
>> submitters of future patches to forget CCing these mailing lists.
>>
>> Fixes: 6e90b675cf942e50 ("MAINTAINERS: Remove some entries due to various compliance requirements.")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Anyone who wants to take over maintenance for these drivers?
> 
> In case Sergei is not interested to keep looking after the RAVB and/or 
> SUPERH Ethernet drivers I would be happy to do so.

   I am still interested, of course... but looks like I'm not allowed to anymore. :-/

> In either case should not the maintainer entry in the bindings documents
> also be updated?

   These still have my Gmail address... I'm not sure yet what to do with it...

[...]

MBR, Sergey
Jakub Kicinski Oct. 28, 2024, 10:43 p.m. UTC | #7
On Mon, 21 Oct 2024 17:11:43 +0200 Niklas Cassel wrote:
> > +RENESAS R-CAR SATA DRIVER
> > +L:	linux-ide@vger.kernel.org
> > +L:	linux-renesas-soc@vger.kernel.org
> > +S:	Supported  
> 
> Seems a bit weird to keep the "S: Supported" line, if there is no
> "M: " or "R: " entry. I suggest you kill it.

Agreed, I think they should all be (temporarily?) designated as Orphans.
Greg Kroah-Hartman Nov. 4, 2024, 12:34 a.m. UTC | #8
On Mon, Oct 21, 2024 at 01:56:51PM +0200, Geert Uytterhoeven wrote:
> +RENESAS R-CAR SATA DRIVER
> +L:	linux-ide@vger.kernel.org
> +L:	linux-renesas-soc@vger.kernel.org
> +S:	Supported
> +F:	Documentation/devicetree/bindings/ata/renesas,rcar-sata.yaml
> +F:	drivers/ata/sata_rcar.c

You can't have a "Supported" entry with no person assigned to it :(
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f04cba42a59301fa..97a23cea2729942e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19521,6 +19521,14 @@  S:	Supported
 F:	Documentation/devicetree/bindings/i2c/renesas,iic-emev2.yaml
 F:	drivers/i2c/busses/i2c-emev2.c
 
+RENESAS ETHERNET AVB DRIVER
+L:	netdev@vger.kernel.org
+L:	linux-renesas-soc@vger.kernel.org
+F:	Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+F:	drivers/net/ethernet/renesas/Kconfig
+F:	drivers/net/ethernet/renesas/Makefile
+F:	drivers/net/ethernet/renesas/ravb*
+
 RENESAS ETHERNET SWITCH DRIVER
 R:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 L:	netdev@vger.kernel.org
@@ -19570,6 +19578,13 @@  F:	Documentation/devicetree/bindings/i2c/renesas,rmobile-iic.yaml
 F:	drivers/i2c/busses/i2c-rcar.c
 F:	drivers/i2c/busses/i2c-sh_mobile.c
 
+RENESAS R-CAR SATA DRIVER
+L:	linux-ide@vger.kernel.org
+L:	linux-renesas-soc@vger.kernel.org
+S:	Supported
+F:	Documentation/devicetree/bindings/ata/renesas,rcar-sata.yaml
+F:	drivers/ata/sata_rcar.c
+
 RENESAS R-CAR THERMAL DRIVERS
 M:	Niklas Söderlund <niklas.soderlund@ragnatech.se>
 L:	linux-renesas-soc@vger.kernel.org
@@ -19645,6 +19660,15 @@  S:	Supported
 F:	Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
 F:	drivers/i2c/busses/i2c-rzv2m.c
 
+RENESAS SUPERH ETHERNET DRIVER
+L:	netdev@vger.kernel.org
+L:	linux-renesas-soc@vger.kernel.org
+F:	Documentation/devicetree/bindings/net/renesas,ether.yaml
+F:	drivers/net/ethernet/renesas/Kconfig
+F:	drivers/net/ethernet/renesas/Makefile
+F:	drivers/net/ethernet/renesas/sh_eth*
+F:	include/linux/sh_eth.h
+
 RENESAS USB PHY DRIVER
 M:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 L:	linux-renesas-soc@vger.kernel.org