| Message ID | 20241021195316.58911-2-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | : chemical: bme680: 2nd set of cleanup | expand |
On Mon, Oct 21, 2024 at 09:53:04PM +0200, Vasileios Amoiridis wrote: > Add the linux/regmap.h header since the struct regmap_config is used > in this file. > > Cc: <Stable@vger.kernel.org> > Fixes: 1b3bd8592780 ("iio: chemical: Add support for Bosch BME680 sensor") > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > drivers/iio/chemical/bme680.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h > index b2c547ac8d34..dc9ff477da34 100644 > --- a/drivers/iio/chemical/bme680.h > +++ b/drivers/iio/chemical/bme680.h > @@ -2,6 +2,8 @@ > #ifndef BME680_H_ > #define BME680_H_ > > +#include <linux/regmap.h> > + > #define BME680_REG_CHIP_ID 0xD0 > #define BME680_CHIP_ID_VAL 0x61 > #define BME680_REG_SOFT_RESET 0xE0 Why is this needed in a stable release? Does it fix a bug?
On Mon, 21 Oct 2024 22:13:17 +0200 Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Oct 21, 2024 at 09:53:04PM +0200, Vasileios Amoiridis wrote: > > Add the linux/regmap.h header since the struct regmap_config is used > > in this file. > > > > Cc: <Stable@vger.kernel.org> > > Fixes: 1b3bd8592780 ("iio: chemical: Add support for Bosch BME680 sensor") > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > > --- > > drivers/iio/chemical/bme680.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h > > index b2c547ac8d34..dc9ff477da34 100644 > > --- a/drivers/iio/chemical/bme680.h > > +++ b/drivers/iio/chemical/bme680.h > > @@ -2,6 +2,8 @@ > > #ifndef BME680_H_ > > #define BME680_H_ > > > > +#include <linux/regmap.h> > > + > > #define BME680_REG_CHIP_ID 0xD0 > > #define BME680_CHIP_ID_VAL 0x61 > > #define BME680_REG_SOFT_RESET 0xE0 > > Why is this needed in a stable release? Does it fix a bug? > Indeed this is just tidying up. I've applied but dropped the tag and changed title to Add missing.... as no reason for this to get backported that I know of.
diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h index b2c547ac8d34..dc9ff477da34 100644 --- a/drivers/iio/chemical/bme680.h +++ b/drivers/iio/chemical/bme680.h @@ -2,6 +2,8 @@ #ifndef BME680_H_ #define BME680_H_ +#include <linux/regmap.h> + #define BME680_REG_CHIP_ID 0xD0 #define BME680_CHIP_ID_VAL 0x61 #define BME680_REG_SOFT_RESET 0xE0
Add the linux/regmap.h header since the struct regmap_config is used in this file. Cc: <Stable@vger.kernel.org> Fixes: 1b3bd8592780 ("iio: chemical: Add support for Bosch BME680 sensor") Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- drivers/iio/chemical/bme680.h | 2 ++ 1 file changed, 2 insertions(+)