diff mbox series

ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys

Message ID 20241015224505.94359-1-marex@denx.de (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys | expand

Commit Message

Marek Vasut Oct. 15, 2024, 10:44 p.m. UTC
Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
is not a bus, see dtbs_check warning:

"
arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-cells' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
"

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Christoph Niedermaier Oct. 16, 2024, 8:28 a.m. UTC | #1
From: Marek Vasut <marex@denx.de>
Sent: Wednesday, October 16, 2024 12:45 AM
> Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
> is not a bus, see dtbs_check warning:
> 
> "
> arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-
> cells' do not match any of the regexes:
> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-
> (button|event|key|switch))$', 'pinctrl-[0-9]+'
> "
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> index 6248b126b5578..773fdcfcd0015 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> @@ -56,7 +56,6 @@ lcd_display_out: endpoint {
>         };
> 
>         gpio-keys {
> -               #size-cells = <0>;
>                 compatible = "gpio-keys";
> 
>                 button-0 {

Reviewed-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Shawn Guo Oct. 22, 2024, 1:45 a.m. UTC | #2
On Wed, Oct 16, 2024 at 12:44:52AM +0200, Marek Vasut wrote:
> Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
> is not a bus, see dtbs_check warning:
> 
> "
> arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-cells' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
> "
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
index 6248b126b5578..773fdcfcd0015 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
@@ -56,7 +56,6 @@  lcd_display_out: endpoint {
 	};
 
 	gpio-keys {
-		#size-cells = <0>;
 		compatible = "gpio-keys";
 
 		button-0 {