| Message ID | 20241020230803.247419-1-dmitry.osipenko@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] drm/virtio: Use drm_gem_plane_helper_prepare_fb() | expand |
> Subject: [PATCH v3 1/2] drm/virtio: Use > drm_gem_plane_helper_prepare_fb() > > From: Dongwon Kim <dongwon.kim@intel.com> > > Use drm_gem_plane_helper_prepare_fb() helper for explicit framebuffer > synchronization. We need to wait for explicit fences in a case of > Venus and native contexts when guest user space uses explicit fencing. > > Signed-off-by: Dongwon Kim <dongwon.kim@intel.com> > [dmitry.osipenko@collabora.com>: Edit commit message] > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c > b/drivers/gpu/drm/virtio/virtgpu_plane.c > index a72a2dbda031..ab7232921cb7 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > @@ -26,6 +26,7 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_damage_helper.h> > #include <drm/drm_fourcc.h> > +#include <drm/drm_gem_atomic_helper.h> > > #include "virtgpu_drv.h" > > @@ -254,6 +255,9 @@ static int virtio_gpu_plane_prepare_fb(struct > drm_plane *plane, > > vgfb = to_virtio_gpu_framebuffer(new_state->fb); > bo = gem_to_virtio_gpu_obj(vgfb->base.obj[0]); > + > + drm_gem_plane_helper_prepare_fb(plane, new_state); > + Acked-by: Vivek Kasireddy <vivek.kasireddy@intel.com> > if (!bo || (plane->type == DRM_PLANE_TYPE_PRIMARY && !bo- > >guest_blob)) > return 0; > > -- > 2.47.0
On Sun, Oct 20, 2024 at 4:08 PM Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote: > > From: Dongwon Kim <dongwon.kim@intel.com> > > Use drm_gem_plane_helper_prepare_fb() helper for explicit framebuffer > synchronization. We need to wait for explicit fences in a case of > Venus and native contexts when guest user space uses explicit fencing. > > Signed-off-by: Dongwon Kim <dongwon.kim@intel.com> > [dmitry.osipenko@collabora.com>: Edit commit message] > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Reviewed-by: Rob Clark <robdclark@gmail.com> > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c > index a72a2dbda031..ab7232921cb7 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_plane.c > +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c > @@ -26,6 +26,7 @@ > #include <drm/drm_atomic_helper.h> > #include <drm/drm_damage_helper.h> > #include <drm/drm_fourcc.h> > +#include <drm/drm_gem_atomic_helper.h> > > #include "virtgpu_drv.h" > > @@ -254,6 +255,9 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane *plane, > > vgfb = to_virtio_gpu_framebuffer(new_state->fb); > bo = gem_to_virtio_gpu_obj(vgfb->base.obj[0]); > + > + drm_gem_plane_helper_prepare_fb(plane, new_state); > + > if (!bo || (plane->type == DRM_PLANE_TYPE_PRIMARY && !bo->guest_blob)) > return 0; > > -- > 2.47.0 >
On 10/21/24 02:08, Dmitry Osipenko wrote: > From: Dongwon Kim <dongwon.kim@intel.com> > > Use drm_gem_plane_helper_prepare_fb() helper for explicit framebuffer > synchronization. We need to wait for explicit fences in a case of > Venus and native contexts when guest user space uses explicit fencing. > > Signed-off-by: Dongwon Kim <dongwon.kim@intel.com> > [dmitry.osipenko@collabora.com>: Edit commit message] > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > --- > drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ > 1 file changed, 4 insertions(+) I'll apply this patchset tomorrow if nobody has more comments to add.
On 10/21/24 02:08, Dmitry Osipenko wrote: > From: Dongwon Kim <dongwon.kim@intel.com> > > Use drm_gem_plane_helper_prepare_fb() helper for explicit framebuffer > synchronization. We need to wait for explicit fences in a case of > Venus and native contexts when guest user space uses explicit fencing. > > Signed-off-by: Dongwon Kim <dongwon.kim@intel.com> > [dmitry.osipenko@collabora.com>: Edit commit message] > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Applied patchset to misc-next
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index a72a2dbda031..ab7232921cb7 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -26,6 +26,7 @@ #include <drm/drm_atomic_helper.h> #include <drm/drm_damage_helper.h> #include <drm/drm_fourcc.h> +#include <drm/drm_gem_atomic_helper.h> #include "virtgpu_drv.h" @@ -254,6 +255,9 @@ static int virtio_gpu_plane_prepare_fb(struct drm_plane *plane, vgfb = to_virtio_gpu_framebuffer(new_state->fb); bo = gem_to_virtio_gpu_obj(vgfb->base.obj[0]); + + drm_gem_plane_helper_prepare_fb(plane, new_state); + if (!bo || (plane->type == DRM_PLANE_TYPE_PRIMARY && !bo->guest_blob)) return 0;