| Message ID | 20241017210439.3449324-1-david.e.box@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [V3,1/2] platform/x86/intel/pmc: Refactor platform resume functions to use cnl_resume() | expand |
On Thu, Oct 17, 2024 at 11:04 PM David E. Box <david.e.box@linux.intel.com> wrote: > > Several platform resume functions currently call pmc_core_send_ltr_ignore() > and pmc_core_resume_common(), both of which are already called by > cnl_resume(). Simplify the code by having these functions call cnl_resume() > directly. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > --- > V3 - no change > > V2 - New patch. Split from V1 Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > drivers/platform/x86/intel/pmc/arl.c | 3 +-- > drivers/platform/x86/intel/pmc/lnl.c | 3 +-- > drivers/platform/x86/intel/pmc/mtl.c | 3 +-- > 3 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c > index e10527c4e3e0..05dec4f5019f 100644 > --- a/drivers/platform/x86/intel/pmc/arl.c > +++ b/drivers/platform/x86/intel/pmc/arl.c > @@ -687,9 +687,8 @@ static void arl_d3_fixup(void) > static int arl_resume(struct pmc_dev *pmcdev) > { > arl_d3_fixup(); > - pmc_core_send_ltr_ignore(pmcdev, 3, 0); > > - return pmc_core_resume_common(pmcdev); > + return cnl_resume(pmcdev); > } > > int arl_core_init(struct pmc_dev *pmcdev) > diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c > index e7a8077d1a3e..be029f12cdf4 100644 > --- a/drivers/platform/x86/intel/pmc/lnl.c > +++ b/drivers/platform/x86/intel/pmc/lnl.c > @@ -546,9 +546,8 @@ static void lnl_d3_fixup(void) > static int lnl_resume(struct pmc_dev *pmcdev) > { > lnl_d3_fixup(); > - pmc_core_send_ltr_ignore(pmcdev, 3, 0); > > - return pmc_core_resume_common(pmcdev); > + return cnl_resume(pmcdev); > } > > int lnl_core_init(struct pmc_dev *pmcdev) > diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c > index 91f2fa728f5c..fc6a89b8979f 100644 > --- a/drivers/platform/x86/intel/pmc/mtl.c > +++ b/drivers/platform/x86/intel/pmc/mtl.c > @@ -988,9 +988,8 @@ static void mtl_d3_fixup(void) > static int mtl_resume(struct pmc_dev *pmcdev) > { > mtl_d3_fixup(); > - pmc_core_send_ltr_ignore(pmcdev, 3, 0); > > - return pmc_core_resume_common(pmcdev); > + return cnl_resume(pmcdev); > } > > int mtl_core_init(struct pmc_dev *pmcdev) > > base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc > -- > 2.43.0 > >
On Thu, 17 Oct 2024 14:04:37 -0700, David E. Box wrote: > Several platform resume functions currently call pmc_core_send_ltr_ignore() > and pmc_core_resume_common(), both of which are already called by > cnl_resume(). Simplify the code by having these functions call cnl_resume() > directly. > > Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/2] platform/x86/intel/pmc: Refactor platform resume functions to use cnl_resume() commit: 9fe43c8020a60b9c9ff44c4a9914e7e7df63084e [2/2] platform/x86/intel/pmc: Disable C1 auto-demotion during suspend commit: 7a797cc9f80915cc5f1a5aee46d14880eb444644 -- i.
diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c index e10527c4e3e0..05dec4f5019f 100644 --- a/drivers/platform/x86/intel/pmc/arl.c +++ b/drivers/platform/x86/intel/pmc/arl.c @@ -687,9 +687,8 @@ static void arl_d3_fixup(void) static int arl_resume(struct pmc_dev *pmcdev) { arl_d3_fixup(); - pmc_core_send_ltr_ignore(pmcdev, 3, 0); - return pmc_core_resume_common(pmcdev); + return cnl_resume(pmcdev); } int arl_core_init(struct pmc_dev *pmcdev) diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c index e7a8077d1a3e..be029f12cdf4 100644 --- a/drivers/platform/x86/intel/pmc/lnl.c +++ b/drivers/platform/x86/intel/pmc/lnl.c @@ -546,9 +546,8 @@ static void lnl_d3_fixup(void) static int lnl_resume(struct pmc_dev *pmcdev) { lnl_d3_fixup(); - pmc_core_send_ltr_ignore(pmcdev, 3, 0); - return pmc_core_resume_common(pmcdev); + return cnl_resume(pmcdev); } int lnl_core_init(struct pmc_dev *pmcdev) diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c index 91f2fa728f5c..fc6a89b8979f 100644 --- a/drivers/platform/x86/intel/pmc/mtl.c +++ b/drivers/platform/x86/intel/pmc/mtl.c @@ -988,9 +988,8 @@ static void mtl_d3_fixup(void) static int mtl_resume(struct pmc_dev *pmcdev) { mtl_d3_fixup(); - pmc_core_send_ltr_ignore(pmcdev, 3, 0); - return pmc_core_resume_common(pmcdev); + return cnl_resume(pmcdev); } int mtl_core_init(struct pmc_dev *pmcdev)
Several platform resume functions currently call pmc_core_send_ltr_ignore() and pmc_core_resume_common(), both of which are already called by cnl_resume(). Simplify the code by having these functions call cnl_resume() directly. Signed-off-by: David E. Box <david.e.box@linux.intel.com> --- V3 - no change V2 - New patch. Split from V1 drivers/platform/x86/intel/pmc/arl.c | 3 +-- drivers/platform/x86/intel/pmc/lnl.c | 3 +-- drivers/platform/x86/intel/pmc/mtl.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc