| Message ID | 20241003111851.10453-10-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Increase COMPILE_TEST=y coverage | expand |
Hi, Ville: On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote: > > External email : Please do not click links or open attachments until you have verified the sender or the content. > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Allow mediatek to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. I don't know why need this greater coverage? This driver always execute on ARM. Regards, CK > > Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: linux-mediatek@lists.infradead.org > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/mediatek/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig > index 3d2436272ff2..2e0e7c4079b6 100644 > --- a/drivers/gpu/drm/mediatek/Kconfig > +++ b/drivers/gpu/drm/mediatek/Kconfig > @@ -2,9 +2,9 @@ > config DRM_MEDIATEK > tristate "DRM Support for Mediatek SoCs" > depends on DRM > -depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) > +depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST > depends on COMMON_CLK > -depends on HAVE_ARM_SMCCC > +depends on HAVE_ARM_SMCCC || COMPILE_TEST > depends on OF > depends on MTK_MMSYS > select DRM_CLIENT_SELECTION > -- > 2.45.2 >
On Tue, Oct 22, 2024 at 09:46:24AM +0000, CK Hu (胡俊光) wrote: > Hi, Ville: > > On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote: > > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Allow mediatek to be built with COMPILE_TEST=y for greater > > coverage. Builds fine on x86/x86_64 at least. > > I don't know why need this greater coverage? It allows people to make subsystem wide changes without having to cross compile on every single architecture to see if the code still builds. > This driver always execute on ARM. COMPILE_TEST (as the name suggests) is only about compile testing the code.
Hi, Ville: On Tue, 2024-10-22 at 16:06 +0300, Ville Syrjälä wrote: > > External email : Please do not click links or open attachments until you have verified the sender or the content. > On Tue, Oct 22, 2024 at 09:46:24AM +0000, CK Hu (胡俊光) wrote: > > Hi, Ville: > > > > On Thu, 2024-10-03 at 14:18 +0300, Ville Syrjala wrote: > > > > > > External email : Please do not click links or open attachments until you have verified the sender or the content. > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > Allow mediatek to be built with COMPILE_TEST=y for greater > > > coverage. Builds fine on x86/x86_64 at least. > > > > I don't know why need this greater coverage? > > It allows people to make subsystem wide changes without > having to cross compile on every single architecture to > see if the code still builds. > > > This driver always execute on ARM. > > COMPILE_TEST (as the name suggests) is only about compile > testing the code. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > -- > Ville Syrjälä > Intel >
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 3d2436272ff2..2e0e7c4079b6 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -2,9 +2,9 @@ config DRM_MEDIATEK tristate "DRM Support for Mediatek SoCs" depends on DRM - depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) + depends on (ARCH_MEDIATEK && ARM) || COMPILE_TEST depends on COMMON_CLK - depends on HAVE_ARM_SMCCC + depends on HAVE_ARM_SMCCC || COMPILE_TEST depends on OF depends on MTK_MMSYS select DRM_CLIENT_SELECTION