| Message ID | 20241018090630.22212-1-donald.hunter@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b0b3683419b45e2971b6d413c506cb818b268d35 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v1] netlink: specs: Add missing bitset attrs to ethtool spec | expand |
On Fri, 18 Oct 2024 10:06:30 +0100 Donald Hunter <donald.hunter@gmail.com> wrote: > There are a couple of attributes missing from the 'bitset' attribute-set > in the ethtool netlink spec. Add them to the spec. Reviewed-by: Kory Maincent <kory.maincent@bootlin.com> Tested-by: Kory Maincent <kory.maincent@bootlin.com> Thank you! > Reported-by: Kory Maincent <kory.maincent@bootlin.com> > Closes: > https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/ > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> --- > Documentation/netlink/specs/ethtool.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/netlink/specs/ethtool.yaml > b/Documentation/netlink/specs/ethtool.yaml index 6a050d755b9c..f6c5d8214c7e > 100644 --- a/Documentation/netlink/specs/ethtool.yaml > +++ b/Documentation/netlink/specs/ethtool.yaml > @@ -96,7 +96,12 @@ attribute-sets: > name: bits > type: nest > nested-attributes: bitset-bits > - > + - > + name: value > + type: binary > + - > + name: mask > + type: binary > - > name: string > attributes:
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 18 Oct 2024 10:06:30 +0100 you wrote: > There are a couple of attributes missing from the 'bitset' attribute-set > in the ethtool netlink spec. Add them to the spec. > > Reported-by: Kory Maincent <kory.maincent@bootlin.com> > Closes: https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/ > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > > [...] Here is the summary with links: - [net-next,v1] netlink: specs: Add missing bitset attrs to ethtool spec https://git.kernel.org/netdev/net-next/c/b0b3683419b4 You are awesome, thank you!
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml index 6a050d755b9c..f6c5d8214c7e 100644 --- a/Documentation/netlink/specs/ethtool.yaml +++ b/Documentation/netlink/specs/ethtool.yaml @@ -96,7 +96,12 @@ attribute-sets: name: bits type: nest nested-attributes: bitset-bits - + - + name: value + type: binary + - + name: mask + type: binary - name: string attributes:
There are a couple of attributes missing from the 'bitset' attribute-set in the ethtool netlink spec. Add them to the spec. Reported-by: Kory Maincent <kory.maincent@bootlin.com> Closes: https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/ Signed-off-by: Donald Hunter <donald.hunter@gmail.com> --- Documentation/netlink/specs/ethtool.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)