| Message ID | 20241021-net-mptcp-sched-lock-v1-3-637759cf061c@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5513dc1d8fec929006548dde4acdabdc54379beb |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | mptcp: sched: fix some lock issues | expand |
On Mon, Oct 21, 2024 at 12:25:28PM +0200, Matthieu Baerts (NGI0) wrote: > Listing all the values linked to the MPTCP sysctl knobs was not > exercised in MPTCP test suite. > > Let's do that to avoid any regressions, but also to have a kernel with a > debug kconfig verifying more assumptions. For the moment, we are not > interested by the output, only to avoid crashes and warnings. > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> I am assuming that we are ok with expanding test coverage via net, which FWIIW, does seem reasonable to me. Reviewed-by: Simon Horman <horms@kernel.org> ...
diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index 57325d57e4c6e3653019db2de09620d692143683..b48b4e56826a9cfdb3501242b707ae2ebe29b220 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -259,6 +259,15 @@ check_mptcp_disabled() mptcp_lib_ns_init disabled_ns print_larger_title "New MPTCP socket can be blocked via sysctl" + + # mainly to cover more code + if ! ip netns exec ${disabled_ns} sysctl net.mptcp >/dev/null; then + mptcp_lib_pr_fail "not able to list net.mptcp sysctl knobs" + mptcp_lib_result_fail "not able to list net.mptcp sysctl knobs" + ret=${KSFT_FAIL} + return 1 + fi + # net.mptcp.enabled should be enabled by default if [ "$(ip netns exec ${disabled_ns} sysctl net.mptcp.enabled | awk '{ print $3 }')" -ne 1 ]; then mptcp_lib_pr_fail "net.mptcp.enabled sysctl is not 1 by default"
Listing all the values linked to the MPTCP sysctl knobs was not exercised in MPTCP test suite. Let's do that to avoid any regressions, but also to have a kernel with a debug kconfig verifying more assumptions. For the moment, we are not interested by the output, only to avoid crashes and warnings. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 9 +++++++++ 1 file changed, 9 insertions(+)