diff mbox series

blk-mq: Unexport blk_mq_flush_busy_ctxs()

Message ID 20241023202850.3469279-1-bvanassche@acm.org (mailing list archive)
State New, archived
Headers show
Series blk-mq: Unexport blk_mq_flush_busy_ctxs() | expand

Commit Message

Bart Van Assche Oct. 23, 2024, 8:28 p.m. UTC
Commit a6088845c2bf ("block: kyber: make kyber more friendly with merging")
removed the only blk_mq_flush_busy_ctxs() call from outside the block layer
core. Hence unexport blk_mq_flush_busy_ctxs().

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 block/blk-mq.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Chaitanya Kulkarni Oct. 23, 2024, 9:43 p.m. UTC | #1
On 10/23/24 13:28, Bart Van Assche wrote:
> Commit a6088845c2bf ("block: kyber: make kyber more friendly with merging")
> removed the only blk_mq_flush_busy_ctxs() call from outside the block layer
> core. Hence unexport blk_mq_flush_busy_ctxs().
>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>   block/blk-mq.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 7482e682deca..9abe6b9dd2ea 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1716,7 +1716,6 @@ void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, struct list_head *list)
>   
>   	sbitmap_for_each_set(&hctx->ctx_map, flush_busy_ctx, &data);
>   }
> -EXPORT_SYMBOL_GPL(blk_mq_flush_busy_ctxs);
>   
>   struct dispatch_rq_data {
>   	struct blk_mq_hw_ctx *hctx;
>

Indeed [1], looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

[1]

block/blk-mq-sched.c:   blk_mq_flush_busy_ctxs(hctx, &rq_list);
block/blk-mq.c:void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, 
struct list_head *list)
block/blk-mq.c:EXPORT_SYMBOL_GPL(blk_mq_flush_busy_ctxs);
block/blk-mq.h:void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, 
struct list_head *list);
Jens Axboe Oct. 23, 2024, 10:30 p.m. UTC | #2
On Wed, 23 Oct 2024 13:28:50 -0700, Bart Van Assche wrote:
> Commit a6088845c2bf ("block: kyber: make kyber more friendly with merging")
> removed the only blk_mq_flush_busy_ctxs() call from outside the block layer
> core. Hence unexport blk_mq_flush_busy_ctxs().
> 
> 

Applied, thanks!

[1/1] blk-mq: Unexport blk_mq_flush_busy_ctxs()
      commit: e203e20a8b2b67eb12f87aa3ee625cda5e686434

Best regards,
diff mbox series

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 7482e682deca..9abe6b9dd2ea 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1716,7 +1716,6 @@  void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, struct list_head *list)
 
 	sbitmap_for_each_set(&hctx->ctx_map, flush_busy_ctx, &data);
 }
-EXPORT_SYMBOL_GPL(blk_mq_flush_busy_ctxs);
 
 struct dispatch_rq_data {
 	struct blk_mq_hw_ctx *hctx;