| Message ID | 20241022094110.1574011-1-jamin_lin@aspeedtech.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix write incorrect data into flash in user mode | expand |
Hello Jamin, On 10/22/24 11:40, Jamin Lin wrote: > change from v1: > 1. Fix write incorrect data into flash in user mode. > 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 and > AST1030. > 3. Add ast2700 smc qtest testcase to support AST2700. > > change from v2: > 1. Introduce a new aspeed-smc-utils.c to place common testcases. > 2. Fix hardcode attach flash model of spi controllers > 3. Add reviewers suggestion and fix review issue. I have applied 1-6,8 to aspeed-next and should send a PR with them. I kept the test extensions for later, to take a closer a look and also because I will be on PTO next week. Tests can be merged in the next PR if we have time in this cycle or in QEMU 10.0. Thanks, C.
Hi Cedric, > Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in user mode > > Hello Jamin, > > On 10/22/24 11:40, Jamin Lin wrote: > > change from v1: > > 1. Fix write incorrect data into flash in user mode. > > 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 > > and AST1030. > > 3. Add ast2700 smc qtest testcase to support AST2700. > > > > change from v2: > > 1. Introduce a new aspeed-smc-utils.c to place common testcases. > > 2. Fix hardcode attach flash model of spi controllers 3. Add reviewers > > suggestion and fix review issue. > I have applied 1-6,8 to aspeed-next and should send a PR with them. I kept the > test extensions for later, to take a closer a look and also because I will be on > PTO next week. Tests can be merged in the next PR if we have time in this cycle > or in QEMU 10.0. > Got it and thanks for help. Jamin > Thanks, > > C. >
Hi Cedric, > Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in user mode > > Hi Cedric, > > > Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in > > user mode > > > > Hello Jamin, > > > > On 10/22/24 11:40, Jamin Lin wrote: > > > change from v1: > > > 1. Fix write incorrect data into flash in user mode. > > > 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 > > > and AST1030. > > > 3. Add ast2700 smc qtest testcase to support AST2700. > > > > > > change from v2: > > > 1. Introduce a new aspeed-smc-utils.c to place common testcases. > > > 2. Fix hardcode attach flash model of spi controllers 3. Add > > > reviewers suggestion and fix review issue. > > I have applied 1-6,8 to aspeed-next and should send a PR with them. I > > kept the test extensions for later, to take a closer a look and also > > because I will be on PTO next week. Tests can be merged in the next PR > > if we have time in this cycle or in QEMU 10.0. > > > Got it and thanks for help. > Jamin > > Thanks, Could you please help to review patch 17 and 18 ? Do I need to re-send patch from 9 to 18 of this patch series? Thanks-Jamin > > > > C. > >
Hello Jamin, On 11/14/24 06:30, Jamin Lin wrote: > Hi Cedric, > >> Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in user mode >> >> Hi Cedric, >> >>> Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in >>> user mode >>> >>> Hello Jamin, >>> >>> On 10/22/24 11:40, Jamin Lin wrote: >>>> change from v1: >>>> 1. Fix write incorrect data into flash in user mode. >>>> 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 >>>> and AST1030. >>>> 3. Add ast2700 smc qtest testcase to support AST2700. >>>> >>>> change from v2: >>>> 1. Introduce a new aspeed-smc-utils.c to place common testcases. >>>> 2. Fix hardcode attach flash model of spi controllers 3. Add >>>> reviewers suggestion and fix review issue. >>> I have applied 1-6,8 to aspeed-next and should send a PR with them. I >>> kept the test extensions for later, to take a closer a look and also >>> because I will be on PTO next week. Tests can be merged in the next PR >>> if we have time in this cycle or in QEMU 10.0. >>> >> Got it and thanks for help. >> Jamin >>> Thanks, > > Could you please help to review patch 17 and 18 ? > Do I need to re-send patch from 9 to 18 of this patch series? Not yet. I have some comments to send but I am busy on another topic. We have some time before QEMU 10.0. They are in my aspeed-9.2 branch, so that I don't forget about them. Thanks, C.
Hi Cedric, > Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in user mode > > Hello Jamin, > > On 11/14/24 06:30, Jamin Lin wrote: > > Hi Cedric, > > > >> Subject: RE: [PATCH v2 00/18] Fix write incorrect data into flash in > >> user mode > >> > >> Hi Cedric, > >> > >>> Subject: Re: [PATCH v2 00/18] Fix write incorrect data into flash in > >>> user mode > >>> > >>> Hello Jamin, > >>> > >>> On 10/22/24 11:40, Jamin Lin wrote: > >>>> change from v1: > >>>> 1. Fix write incorrect data into flash in user mode. > >>>> 2. Refactor aspeed smc qtest testcases to support AST2600, > >>>> AST2500 and AST1030. > >>>> 3. Add ast2700 smc qtest testcase to support AST2700. > >>>> > >>>> change from v2: > >>>> 1. Introduce a new aspeed-smc-utils.c to place common testcases. > >>>> 2. Fix hardcode attach flash model of spi controllers 3. Add > >>>> reviewers suggestion and fix review issue. > >>> I have applied 1-6,8 to aspeed-next and should send a PR with them. > >>> I kept the test extensions for later, to take a closer a look and > >>> also because I will be on PTO next week. Tests can be merged in the > >>> next PR if we have time in this cycle or in QEMU 10.0. > >>> > >> Got it and thanks for help. > >> Jamin > >>> Thanks, > > > > Could you please help to review patch 17 and 18 ? > > Do I need to re-send patch from 9 to 18 of this patch series? > > Not yet. I have some comments to send but I am busy on another topic. > Got it. Thanks for your kindly support. Jamin > We have some time before QEMU 10.0. They are in my aspeed-9.2 branch, so > that I don't forget about them. > > Thanks, > > C. >
change from v1: 1. Fix write incorrect data into flash in user mode. 2. Refactor aspeed smc qtest testcases to support AST2600, AST2500 and AST1030. 3. Add ast2700 smc qtest testcase to support AST2700. change from v2: 1. Introduce a new aspeed-smc-utils.c to place common testcases. 2. Fix hardcode attach flash model of spi controllers 3. Add reviewers suggestion and fix review issue. QEMU version: https://github.com/qemu/qemu/commit/95a16ee753d6da651fce8df876333bf7fcf134d9 Depend patch series: To successfully apply this patch series, it is required to apply this patch series first, https://patchwork.kernel.org/project/qemu-devel/list/?series=894520 Jamin Lin (18): aspeed/smc: Fix write incorrect data into flash in user mode hw/block:m25p80: Fix coding style hw/block:m25p80: Support write status register 2 command (0x31) for w25q01jvq hw/block/m25p80: Add SFDP table for w25q80bl flash hw/arm/aspeed: Correct spi_model w25q256 for ast1030-a1 EVB. hw/arm/aspeed: Correct fmc_model w25q80bl for ast1030-a1 EVB aspeed: Fix hardcode attach flash model of spi controllers test/qtest/aspeed_smc-test: Fix coding style test/qtest/aspeed_smc-test: Move testcases to test_palmetto_bmc function test/qtest/aspeed_smc-test: Introduce a new TestData to test different BMC SOCs test/qtest/aspeed_smc-test: Support to test all CE pins test/qtest/aspeed_smc-test: Introducing a "page_addr" data field test/qtest/aspeed_smc-test: Support to test AST2500 test/qtest/aspeed_smc-test: Support to test AST2600 test/qtest/aspeed_smc-test: Support to test AST1030 test/qtest/aspeed_smc-test: Support write page command with QPI mode test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases test/qtest/ast2700-smc-test: Support to test AST2700 hw/arm/aspeed.c | 25 +- hw/block/m25p80.c | 63 ++- hw/block/m25p80_sfdp.c | 36 ++ hw/block/m25p80_sfdp.h | 2 +- hw/ssi/aspeed_smc.c | 40 +- include/hw/ssi/aspeed_smc.h | 1 + tests/qtest/aspeed-smc-utils.c | 681 +++++++++++++++++++++++++++++ tests/qtest/aspeed-smc-utils.h | 95 +++++ tests/qtest/aspeed_smc-test.c | 757 +++++++-------------------------- tests/qtest/ast2700-smc-test.c | 67 +++ tests/qtest/meson.build | 5 +- 11 files changed, 1143 insertions(+), 629 deletions(-) create mode 100644 tests/qtest/aspeed-smc-utils.c create mode 100644 tests/qtest/aspeed-smc-utils.h create mode 100644 tests/qtest/ast2700-smc-test.c