mbox series

[v10,0/4] debugfs to hisilicon migration driver

Message ID 20241016012308.14108-1-liulongfang@huawei.com (mailing list archive)
Headers show
Series debugfs to hisilicon migration driver | expand

Message

liulongfang Oct. 16, 2024, 1:23 a.m. UTC 
Add a debugfs function to the hisilicon migration driver in VFIO to
provide intermediate state values and data during device migration.

When the execution of live migration fails, the user can view the
status and data during the migration process separately from the
source and the destination, which is convenient for users to analyze
and locate problems.

Changes v9 -> v10
	Optimize symmetry processing of mutex

Changes v8 -> v9
	Added device enable mutex

Changes v7 -> v8
	Delete unnecessary information

Changes v6 -> v7
	Remove redundant kernel error log printing and
	remove unrelated bugfix code

Changes v5 -> v6
	Modify log output calling error

Changes v4 -> v5
	Adjust the descriptioniptionbugfs file directory

Changes v3 -> v4
	Rebased on kernel6.9

Changes 2 -> v3
	Solve debugfs serialization problem.

Changes v1 -> v2
	Solve the racy problem of io_base.

Longfang Liu (4):
  hisi_acc_vfio_pci: extract public functions for container_of
  hisi_acc_vfio_pci: create subfunction for data reading
  hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
  Documentation: add debugfs description for hisi migration

 .../ABI/testing/debugfs-hisi-migration        |  25 ++
 .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c    | 278 ++++++++++++++++--
 .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h    |   7 +
 3 files changed, 279 insertions(+), 31 deletions(-)
 create mode 100644 Documentation/ABI/testing/debugfs-hisi-migration

Comments

Shameerali Kolothum Thodi Oct. 24, 2024, 1:18 p.m. UTC | #1 
Hi Alex,

> -----Original Message-----
> From: liulongfang <liulongfang@huawei.com>
> Sent: Wednesday, October 16, 2024 2:23 AM
> To: alex.williamson@redhat.com; jgg@nvidia.com; Shameerali Kolothum
> Thodi <shameerali.kolothum.thodi@huawei.com>; Jonathan Cameron
> <jonathan.cameron@huawei.com>
> Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linuxarm@openeuler.org; liulongfang <liulongfang@huawei.com>
> Subject: [PATCH v10 0/4] debugfs to hisilicon migration driver
> 
> Add a debugfs function to the hisilicon migration driver in VFIO to
> provide intermediate state values and data during device migration.
> 
> When the execution of live migration fails, the user can view the
> status and data during the migration process separately from the
> source and the destination, which is convenient for users to analyze
> and locate problems.

Could you please take another look at this series as it looks like almost there.

Thanks,
Shameer
Jason Gunthorpe Oct. 24, 2024, 3:27 p.m. UTC | #2 
On Thu, Oct 24, 2024 at 01:18:55PM +0000, Shameerali Kolothum Thodi wrote:
> > Add a debugfs function to the hisilicon migration driver in VFIO to
> > provide intermediate state values and data during device migration.
> > 
> > When the execution of live migration fails, the user can view the
> > status and data during the migration process separately from the
> > source and the destination, which is convenient for users to analyze
> > and locate problems.
> 
> Could you please take another look at this series as it looks like almost there.

Why are we so keen to do this? Nobody else needed a complex debugfs
for their live migration?

Jason
Shameerali Kolothum Thodi Oct. 24, 2024, 4:06 p.m. UTC | #3 
> -----Original Message-----
> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Thursday, October 24, 2024 4:28 PM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> Cc: liulongfang <liulongfang@huawei.com>; alex.williamson@redhat.com;
> Jonathan Cameron <jonathan.cameron@huawei.com>;
> kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> linuxarm@openeuler.org
> Subject: Re: [PATCH v10 0/4] debugfs to hisilicon migration driver
> 
> On Thu, Oct 24, 2024 at 01:18:55PM +0000, Shameerali Kolothum Thodi
> wrote:
> > > Add a debugfs function to the hisilicon migration driver in VFIO to
> > > provide intermediate state values and data during device migration.
> > >
> > > When the execution of live migration fails, the user can view the
> > > status and data during the migration process separately from the
> > > source and the destination, which is convenient for users to analyze
> > > and locate problems.
> >
> > Could you please take another look at this series as it looks like almost
> there.
> 
> Why are we so keen to do this? Nobody else needed a complex debugfs for
> their live migration?

I don't think it is that complex debugfs.  Longfang has found this very helpful in
testing and debug with hardware. 

And hopefully this can be expanded in future with different hardware revisions.

Thanks,
Shameer