mbox series

[v2,0/2] soc: qcom: pmic_glink: Resolve failures to bring up pmic_glink

Message ID 20241023-pmic-glink-ecancelled-v2-0-ebc268129407@oss.qualcomm.com (mailing list archive)
Headers show
Series soc: qcom: pmic_glink: Resolve failures to bring up pmic_glink | expand

Message

Bjorn Andersson Oct. 23, 2024, 5:24 p.m. UTC 
With the transition of pd-mapper into the kernel, the timing was altered
such that on some targets the initial rpmsg_send() requests from
pmic_glink clients would be attempted before the firmware had announced
intents, and the firmware reject intent requests.

Fix this

Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
---
Changes in v2:
- Introduced "intents" and fixed a few spelling mistakes in the commit
  message of patch 1
- Cleaned up log snippet in commit message of patch 2, added battery
  manager log
- Changed the arbitrary 10 second timeout to 5... Ought to be enough for
  anybody.
- Added a small sleep in the send-loop in patch 2, and by that
  refactored the loop completely.
- Link to v1: https://lore.kernel.org/r/20241022-pmic-glink-ecancelled-v1-0-9e26fc74e0a3@oss.qualcomm.com

---
Bjorn Andersson (2):
      rpmsg: glink: Handle rejected intent request better
      soc: qcom: pmic_glink: Handle GLINK intent allocation rejections

 drivers/rpmsg/qcom_glink_native.c | 10 +++++++---
 drivers/soc/qcom/pmic_glink.c     | 25 ++++++++++++++++++++++---
 2 files changed, 29 insertions(+), 6 deletions(-)
---
base-commit: 42f7652d3eb527d03665b09edac47f85fb600924
change-id: 20241022-pmic-glink-ecancelled-d899a9ca0358

Best regards,

Comments

Bjorn Andersson Oct. 24, 2024, 6:56 p.m. UTC | #1 
On Wed, 23 Oct 2024 17:24:31 +0000, Bjorn Andersson wrote:
> With the transition of pd-mapper into the kernel, the timing was altered
> such that on some targets the initial rpmsg_send() requests from
> pmic_glink clients would be attempted before the firmware had announced
> intents, and the firmware reject intent requests.
> 
> Fix this
> 
> [...]

Applied, thanks!

[1/2] rpmsg: glink: Handle rejected intent request better
      commit: a387e73fedd6307c0e194deaa53c42b153ff0bd6
[2/2] soc: qcom: pmic_glink: Handle GLINK intent allocation rejections
      commit: f8c879192465d9f328cb0df07208ef077c560bb1

Best regards,