| Message ID | 20210923023448.4190-2-akinobu.mita@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/2] hwmon: (pwm-fan) add option to leave fan on shutdown | expand |
On 23/09/2021 04:34, Akinobu Mita wrote: > Document new retain-state-shutdown property. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Billy Tsai <billy_tsai@aspeedtech.com> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> You develop on some very old kernel, please don't and rather use mainline. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
On 25/10/2024 10:28, Krzysztof Kozlowski wrote: > On 23/09/2021 04:34, Akinobu Mita wrote: >> Document new retain-state-shutdown property. >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Billy Tsai <billy_tsai@aspeedtech.com> >> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > > You develop on some very old kernel, please don't and rather use mainline. And I need to start checking dates of messages which lei brings to me. Sorry for the noise, although missing cc to DT is still valid argument. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt index 4509e688623a..c1b2c3ff7ba8 100644 --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt @@ -19,6 +19,8 @@ Optional properties: interrupts per revolution). The value must be greater than zero. +- retain-state-shutdown: Retain the state of the PWM on shutdown. + Example: fan0: pwm-fan { compatible = "pwm-fan";
Document new retain-state-shutdown property. Cc: Rob Herring <robh+dt@kernel.org> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Billy Tsai <billy_tsai@aspeedtech.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> --- Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 2 ++ 1 file changed, 2 insertions(+)