| Message ID | 20241011-sa8775p-mm-v4-resend-patches-v5-7-4a9f17dc683a@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for videocc, camcc, dispcc0 and dispcc1 on Qualcomm SA8775P platform. | expand |
On Fri, Oct 11, 2024 at 12:28:37AM GMT, Taniya Das wrote: > The HW supported sleep_clk frequency on SA8775P is 32000, hence > update the sleep_clk frequency with the correct value on SA8775P. > > Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride") > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Taniya Das <quic_tdas@quicinc.com> It's generally expected that bug fixes are sent first in patch series, but perhaps it's fine as this is the first DT-patch in the series. That said, the only relationship between this patch and the rest of this series is...you. There's no reason for sending this together with the multimedia clock drivers. Further, the patch subject doesn't match the expected format. It's too long (not a summary) and it doesn't have the expected subject prefix for changes to this file. Please correct this. Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > index 0c1b21def4b62cc65a693552983ec0bc7eec697d..adb71aeff339b564eb3acc42a38bba2f03507508 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > @@ -517,7 +517,7 @@ &serdes1 { > }; > > &sleep_clk { > - clock-frequency = <32764>; > + clock-frequency = <32000>; > }; > > &spi16 { > > -- > 2.45.2 >
On 10/23/2024 4:01 AM, Bjorn Andersson wrote: > On Fri, Oct 11, 2024 at 12:28:37AM GMT, Taniya Das wrote: >> The HW supported sleep_clk frequency on SA8775P is 32000, hence >> update the sleep_clk frequency with the correct value on SA8775P. >> >> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride") >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> > > It's generally expected that bug fixes are sent first in patch series, > but perhaps it's fine as this is the first DT-patch in the series. > > That said, the only relationship between this patch and the rest of this > series is...you. There's no reason for sending this together with the > multimedia clock drivers. > > > Further, the patch subject doesn't match the expected format. It's too > long (not a summary) and it doesn't have the expected subject prefix for > changes to this file. > > Please correct this. > Sure, Bjorn, will update in the next series of the patch. > Regards, > Bjorn > >> --- >> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> index 0c1b21def4b62cc65a693552983ec0bc7eec697d..adb71aeff339b564eb3acc42a38bba2f03507508 100644 >> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> @@ -517,7 +517,7 @@ &serdes1 { >> }; >> >> &sleep_clk { >> - clock-frequency = <32764>; >> + clock-frequency = <32000>; >> }; >> >> &spi16 { >> >> -- >> 2.45.2 >>
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi index 0c1b21def4b62cc65a693552983ec0bc7eec697d..adb71aeff339b564eb3acc42a38bba2f03507508 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi @@ -517,7 +517,7 @@ &serdes1 { }; &sleep_clk { - clock-frequency = <32764>; + clock-frequency = <32000>; }; &spi16 {
The HW supported sleep_clk frequency on SA8775P is 32000, hence update the sleep_clk frequency with the correct value on SA8775P. Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)