| Message ID | 20241025075630.3917458-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] arm64: dts: mediatek: mt8183: Disable DPI display output by default | expand |
On Fri, Oct 25, 2024 at 3:56 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > This reverts commit 377548f05bd0905db52a1d50e5b328b9b4eb049d. > > Most SoC dtsi files have the display output interfaces disabled by > default, and only enabled on boards that utilize them. The MT8183 > has it backwards: the display outputs are left enabled by default, > and only disabled at the board level. > > Reverse the situation for the DPI output so that it follows the > normal scheme. For ease of backporting the DSI output is handled > in a separate patch. > > Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183") > Fixes: 377548f05bd0 ("arm64: dts: mediatek: mt8183-kukui: Disable DPI display interface") > Cc: <stable@vger.kernel.org> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Fei Shao <fshao@chromium.org>
On Fri, 25 Oct 2024 15:56:27 +0800, Chen-Yu Tsai wrote: > This reverts commit 377548f05bd0905db52a1d50e5b328b9b4eb049d. > > Most SoC dtsi files have the display output interfaces disabled by > default, and only enabled on boards that utilize them. The MT8183 > has it backwards: the display outputs are left enabled by default, > and only disabled at the board level. > > [...] Applied to v6.13-next/dts64, thanks! [1/2] arm64: dts: mediatek: mt8183: Disable DPI display output by default commit: 93a680af46436780fd64f4e856a4cfa8b393be6e [2/2] arm64: dts: mediatek: mt8183: Disable DSI display output by default commit: 26f6e91fa29a58fdc76b47f94f8f6027944a490c Cheers, Angelo
On Tue, Dec 10, 2024 at 4:28 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > On Fri, 25 Oct 2024 15:56:27 +0800, Chen-Yu Tsai wrote: > > This reverts commit 377548f05bd0905db52a1d50e5b328b9b4eb049d. > > > > Most SoC dtsi files have the display output interfaces disabled by > > default, and only enabled on boards that utilize them. The MT8183 > > has it backwards: the display outputs are left enabled by default, > > and only disabled at the board level. > > > > [...] > > Applied to v6.13-next/dts64, thanks! > > [1/2] arm64: dts: mediatek: mt8183: Disable DPI display output by default > commit: 93a680af46436780fd64f4e856a4cfa8b393be6e > [2/2] arm64: dts: mediatek: mt8183: Disable DSI display output by default > commit: 26f6e91fa29a58fdc76b47f94f8f6027944a490c Thanks! It seems you haven't updated the for-next branch, so it isn't appearing in linux-next yet. ChenYu
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi index 07ae3c8e897b..22924f61ec9e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi @@ -290,11 +290,6 @@ dsi_out: endpoint { }; }; -&dpi0 { - /* TODO Re-enable after DP to Type-C port muxing can be described */ - status = "disabled"; -}; - &gic { mediatek,broken-save-restore-fw; }; diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 1afeeb1155f5..8f31fc9050ec 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -1845,6 +1845,7 @@ dpi0: dpi@14015000 { <&mmsys CLK_MM_DPI_MM>, <&apmixedsys CLK_APMIXED_TVDPLL>; clock-names = "pixel", "engine", "pll"; + status = "disabled"; port { dpi_out: endpoint { };
This reverts commit 377548f05bd0905db52a1d50e5b328b9b4eb049d. Most SoC dtsi files have the display output interfaces disabled by default, and only enabled on boards that utilize them. The MT8183 has it backwards: the display outputs are left enabled by default, and only disabled at the board level. Reverse the situation for the DPI output so that it follows the normal scheme. For ease of backporting the DSI output is handled in a separate patch. Fixes: 009d855a26fd ("arm64: dts: mt8183: add dpi node to mt8183") Fixes: 377548f05bd0 ("arm64: dts: mediatek: mt8183-kukui: Disable DPI display interface") Cc: <stable@vger.kernel.org> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 5 ----- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + 2 files changed, 1 insertion(+), 5 deletions(-)