| Message ID | 20241025122146.17925-1-iulia.tanasescu@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bap: Add support for Broadcast Sink AC 13 | expand |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Fri, 25 Oct 2024 15:21:32 +0300 you wrote: > This patch adds support for Audio Configuration 13 for a > Broadcast Sink: A Broadcast Sink can synchronize to > multiple BISes transmitted by a Source. > > Broadcast Sink streams are selected linked together. > > The bluetoothctl log below shows a Broadcast Sink detecting > 2 streams from a source and selecting both of them. After the > first transport is acquired, the link is created and the first > transport goes active. > > [...] Here is the summary with links: - [BlueZ,v2,01/14] shared/bap: Allow multiple links per stream https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7ff51d684956 - [BlueZ,v2,02/14] shared/bap: Add support for handling broadcast links https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=85bee521c737 - [BlueZ,v2,03/14] shared/bap: Fix broadcast set state https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=71d19c6c8416 - [BlueZ,v2,04/14] shared/bap: Use enabling state for bcast sink streams https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=eaff473cd263 - [BlueZ,v2,05/14] bap: Add support for syncing to multiple BISes https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0b5cfc1badf0 - [BlueZ,v2,06/14] shared/bap: Handle multiple bcast sink streams https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b92b857f2fb0 - [BlueZ,v2,07/14] transport: Unset transport owner before owner free https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=47da1efdc584 - [BlueZ,v2,08/14] transport: Add Links property for broadcast transports https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e0e3c922f715 - [BlueZ,v2,09/14] doc/media: Document Links property for broadcast https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5b1dfd2721e2 - [BlueZ,v2,10/14] transport: Set bap_update_links as transport op https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3bafab446636 - [BlueZ,v2,11/14] transport: Make transport_bap_set_state part of BAP_OPS https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2ec04e02601f - [BlueZ,v2,12/14] client/player: Handle acquiring broadcast links https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7b63fe6bd4d0 - [BlueZ,v2,13/14] client/player: Add support to select multiple transports https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3075a9c17d16 - [BlueZ,v2,14/14] transport: Unlink broadcast transport at release https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=06c94f0ac055 You are awesome, thank you!
This patch adds support for Audio Configuration 13 for a Broadcast Sink: A Broadcast Sink can synchronize to multiple BISes transmitted by a Source. Broadcast Sink streams are selected linked together. The bluetoothctl log below shows a Broadcast Sink detecting 2 streams from a source and selecting both of them. After the first transport is acquired, the link is created and the first transport goes active. client/bluetoothctl [bluetooth]# endpoint.register 00001851-0000-1000-8000-00805f9b34fb 0x06 [/local/endpoint/ep0] Auto Accept (yes/no): y [/local/endpoint/ep0] Max Transports (auto/value): a [/local/endpoint/ep0] Locations: 1 [/local/endpoint/ep0] Supported Context (value): 1 Capabilities: 03 01 ff 00 02 02 03 05 04 1a 00 f0 00 02 03 01 Metadata: [bluetooth]# Endpoint /local/endpoint/ep0 registered [bluetooth]# scan on [bluetooth]# [NEW] Device 17:7A:80:64:A7:93 17-7A-80-64-A7-93 [17-7A-80-64-A7-93]# [NEW] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# [NEW] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 [17-7A-80-64-A7-93]# transport.select /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 State: broadcasting [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 State: broadcasting [17-7A-80-64-A7-93]# transport.acquire /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 Links: /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 [17-7A-80-64-A7-93]# Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 acquiring complete [17-7A-80-64-A7-93]# Acquire successful: fd 8 MTU 40:0 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 State: active The btmon log shows that sync has been established with both BISes: < HCI Command: LE Broadcast Isochronous Group Create Sync (0x08|0x006b) BIG Handle: 0x00 BIG Sync Handle: 0x0000 Encryption: Unencrypted (0x00) Broadcast Code[16]: 00000000000000000000000000000000 Maximum Number Subevents: 0x00 Timeout: 20000 ms (0x07d0) Number of BIS: 2 BIS ID: 0x01 BIS ID: 0x02 > HCI Event: Command Status (0x0f) plen 4 LE Broadcast Isochronous Group Create Sync (0x08|0x006b) ncmd 1 Status: Success (0x00) > HCI Event: LE Meta Event (0x3e) plen 19 LE Broadcast Isochronous Group Sync Estabilished (0x1d) Status: Success (0x00) BIG Handle: 0x00 Transport Latency: 0 us (0x000000) NSE: 3 BN: 1 PTO: 1 IRC: 3 Maximum PDU: 40 ISO Interval: 10.00 msec (0x0008) Connection Handle #0: 6 Connection Handle #1: 7 < HCI Command: LE Setup Isochronous Data Path (0x08|0x006e) plen 13 Handle: 6 Data Path Direction: Output (Controller to Host) (0x01) Data Path: HCI (0x00) Coding Format: Transparent (0x03) Company Codec ID: Ericsson Technology Licensing (0) Vendor Codec ID: 0 Controller Delay: 0 us (0x000000) Codec Configuration Length: 0 Codec Configuration[0]: > HCI Event: Command Complete (0x0e) plen 6 LE Setup Isochronous Data Path (0x08|0x006e) ncmd 1 Status: Success (0x00) Handle: 6 < HCI Command: LE Setup Isochronous Data Path (0x08|0x006e) plen 13 Handle: 7 Data Path Direction: Output (Controller to Host) (0x01) Data Path: HCI (0x00) Coding Format: Transparent (0x03) Company Codec ID: Ericsson Technology Licensing (0) Vendor Codec ID: 0 Controller Delay: 0 us (0x000000) Codec Configuration Length: 0 Codec Configuration[0]: > HCI Event: Command Complete (0x0e) plen 6 LE Setup Isochronous Data Path (0x08|0x006e) ncmd 1 Status: Success (0x00) Handle: 7 The second transport can then be acquired and it will go straight to active, since the fd has already been set: [17-7A-80-64-A7-93]# transport.acquire /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 Links: /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 acquiring complete [17-7A-80-64-A7-93]# Acquire successful: fd 9 MTU 40:0 [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 State: active The transports can them be released one by one: [17-7A-80-64-A7-93]# transport.release /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 [17-7A-80-64-A7-93]# Transport fd disconnected [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis1/fd0 State: idle [17-7A-80-64-A7-93]# Release successful [17-7A-80-64-A7-93]# transport.release /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 [17-7A-80-64-A7-93]# Transport fd disconnected [17-7A-80-64-A7-93]# [CHG] Transport /org/bluez/hci0/dev_17_7A_80_64_A7_93/bis2/fd1 State: idle [17-7A-80-64-A7-93]# Release successful Iulia Tanasescu (14): shared/bap: Allow multiple links per stream shared/bap: Add support for handling broadcast links shared/bap: Fix broadcast set state shared/bap: Use enabling state for bcast sink streams bap: Add support for syncing to multiple BISes shared/bap: Handle multiple bcast sink streams transport: Unset transport owner before owner free transport: Add Links property for broadcast transports doc/media: Document Links property for broadcast transport: Set bap_update_links as transport op transport: Make transport_bap_set_state part of BAP_OPS client/player: Handle acquiring broadcast links client/player: Add support to select multiple transports transport: Unlink broadcast transport at release client/player.c | 75 +++-- doc/org.bluez.MediaTransport.rst | 17 +- profiles/audio/bap.c | 180 +++++++---- profiles/audio/transport.c | 192 ++++++++++-- src/shared/bap.c | 498 +++++++++++++++++++++++++++---- src/shared/bap.h | 4 +- unit/test-bap.c | 7 +- 7 files changed, 788 insertions(+), 185 deletions(-) base-commit: 806a552d53c787c0ddea9328a09b0ef124bca26e