mbox series

[v2,0/5] arm64: dts: exynos8895: Add cmu, mct, serial_0/1 and spi_0/1

Message ID 20241023091734.538682-1-ivo.ivanov.ivanov1@gmail.com (mailing list archive)
Headers show
Series arm64: dts: exynos8895: Add cmu, mct, serial_0/1 and spi_0/1 | expand

Message

Ivaylo Ivanov Oct. 23, 2024, 9:17 a.m. UTC
Hey folks,

This patchset adds device tree nodes for multiple clock management unit
blocks, MCT, SPI and UART for Exynos8895.

Exynos8895 uses USIv1 for most of its serial buses, except a few that
have been implemented in this series. Support for USIv1 and HSI2C will
be added in the future.

This patchset is dependent on [1] and [2], which add driver support for
CMU and UART.

[1] https://lore.kernel.org/all/20241023090136.537395-1-ivo.ivanov.ivanov1@gmail.com/
[2] https://lore.kernel.org/all/20241023090902.538040-1-ivo.ivanov.ivanov1@gmail.com/

Changes in v2:
 - Add r-b from Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
 - Change clock-names according to the v2 changes for clk bindings

Ivaylo Ivanov (5):
  dt-bindings: timer: exynos4210-mct: Add samsung,exynos8895-mct
    compatible
  arm64: dts: exynos8895: Add clock management unit nodes
  arm64: dts: exynos8895: Add Multi Core Timer (MCT) node
  arm64: dts: exynos8895: Add serial_0/1 nodes
  arm64: dts: exynos8895: Add spi_0/1 nodes

 .../timer/samsung,exynos4210-mct.yaml         |   2 +
 arch/arm64/boot/dts/exynos/exynos8895.dtsi    | 161 ++++++++++++++++++
 2 files changed, 163 insertions(+)

Comments

Ivaylo Ivanov Oct. 23, 2024, 11:59 a.m. UTC | #1
On 10/23/24 12:17, Ivaylo Ivanov wrote:
> Hey folks,
>
> This patchset adds device tree nodes for multiple clock management unit
> blocks, MCT, SPI and UART for Exynos8895.
>
> Exynos8895 uses USIv1 for most of its serial buses, except a few that
> have been implemented in this series. Support for USIv1 and HSI2C will
> be added in the future.
>
> This patchset is dependent on [1] and [2], which add driver support for
> CMU and UART.
>
> [1] https://lore.kernel.org/all/20241023090136.537395-1-ivo.ivanov.ivanov1@gmail.com/
> [2] https://lore.kernel.org/all/20241023090902.538040-1-ivo.ivanov.ivanov1@gmail.com/
>
> Changes in v2:
>  - Add r-b from Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>  - Change clock-names according to the v2 changes for clk bindings

Forgot to mention that I dropped the SPI patch due to it getting applied.

Best regards, Ivo.

>
> Ivaylo Ivanov (5):
>   dt-bindings: timer: exynos4210-mct: Add samsung,exynos8895-mct
>     compatible
>   arm64: dts: exynos8895: Add clock management unit nodes
>   arm64: dts: exynos8895: Add Multi Core Timer (MCT) node
>   arm64: dts: exynos8895: Add serial_0/1 nodes
>   arm64: dts: exynos8895: Add spi_0/1 nodes
>
>  .../timer/samsung,exynos4210-mct.yaml         |   2 +
>  arch/arm64/boot/dts/exynos/exynos8895.dtsi    | 161 ++++++++++++++++++
>  2 files changed, 163 insertions(+)
>
Krzysztof Kozlowski Oct. 26, 2024, 11:53 a.m. UTC | #2
On 23/10/2024 11:17, Ivaylo Ivanov wrote:
> Hey folks,
> 
> This patchset adds device tree nodes for multiple clock management unit
> blocks, MCT, SPI and UART for Exynos8895.
> 
> Exynos8895 uses USIv1 for most of its serial buses, except a few that
> have been implemented in this series. Support for USIv1 and HSI2C will
> be added in the future.
> 
> This patchset is dependent on [1] and [2], which add driver support for
> CMU and UART.
> 
> [1] https://lore.kernel.org/all/20241023090136.537395-1-ivo.ivanov.ivanov1@gmail.com/

I cannot merge driver changes into DTS. Are you sure you have driver
dependency?

> [2] https://lore.kernel.org/all/20241023090902.538040-1-ivo.ivanov.ivanov1@gmail.com/

I cannot merge this either. This is serial tree.

Maybe you these are not really dependencies? What is here depending on
what, specifically? What prevents me from applying it?

Best regards,
Krzysztof
Ivaylo Ivanov Oct. 26, 2024, 11:59 a.m. UTC | #3
On 10/26/24 14:53, Krzysztof Kozlowski wrote:
> On 23/10/2024 11:17, Ivaylo Ivanov wrote:
>> Hey folks,
>>
>> This patchset adds device tree nodes for multiple clock management unit
>> blocks, MCT, SPI and UART for Exynos8895.
>>
>> Exynos8895 uses USIv1 for most of its serial buses, except a few that
>> have been implemented in this series. Support for USIv1 and HSI2C will
>> be added in the future.
>>
>> This patchset is dependent on [1] and [2], which add driver support for
>> CMU and UART.
>>
>> [1] https://lore.kernel.org/all/20241023090136.537395-1-ivo.ivanov.ivanov1@gmail.com/
> I cannot merge driver changes into DTS. Are you sure you have driver
> dependency?
>
>> [2] https://lore.kernel.org/all/20241023090902.538040-1-ivo.ivanov.ivanov1@gmail.com/
> I cannot merge this either. This is serial tree.
>
> Maybe you these are not really dependencies? What is here depending on
> what, specifically? What prevents me from applying it?

The specified patchsets add driver functionality, as well as bindings,
for serial and clocks. This patchset makes 8895's device tree a user
of them. I guess it's not really a dependency, as 8895 devices should
still function without the driver compatibles merged, but there's gonna
be missing bindings.

Best regards, Ivo.

> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Oct. 26, 2024, 12:02 p.m. UTC | #4
On 26/10/2024 13:59, Ivaylo Ivanov wrote:
> 
> 
> 
> On 10/26/24 14:53, Krzysztof Kozlowski wrote:
>> On 23/10/2024 11:17, Ivaylo Ivanov wrote:
>>> Hey folks,
>>>
>>> This patchset adds device tree nodes for multiple clock management unit
>>> blocks, MCT, SPI and UART for Exynos8895.
>>>
>>> Exynos8895 uses USIv1 for most of its serial buses, except a few that
>>> have been implemented in this series. Support for USIv1 and HSI2C will
>>> be added in the future.
>>>
>>> This patchset is dependent on [1] and [2], which add driver support for
>>> CMU and UART.
>>>
>>> [1] https://lore.kernel.org/all/20241023090136.537395-1-ivo.ivanov.ivanov1@gmail.com/
>> I cannot merge driver changes into DTS. Are you sure you have driver
>> dependency?
>>
>>> [2] https://lore.kernel.org/all/20241023090902.538040-1-ivo.ivanov.ivanov1@gmail.com/
>> I cannot merge this either. This is serial tree.
>>
>> Maybe you these are not really dependencies? What is here depending on
>> what, specifically? What prevents me from applying it?
> 
> The specified patchsets add driver functionality, as well as bindings,
> for serial and clocks. This patchset makes 8895's device tree a user
> of them. I guess it's not really a dependency, as 8895 devices should
> still function without the driver compatibles merged, but there's gonna
> be missing bindings.

So the only dependency is on clock bindings? If so, that's the only
message expected here. There are no other dependencies.

Best regards,
Krzysztof
Krzysztof Kozlowski Oct. 26, 2024, 12:12 p.m. UTC | #5
On Wed, 23 Oct 2024 12:17:29 +0300, Ivaylo Ivanov wrote:
> Hey folks,
> 
> This patchset adds device tree nodes for multiple clock management unit
> blocks, MCT, SPI and UART for Exynos8895.
> 
> Exynos8895 uses USIv1 for most of its serial buses, except a few that
> have been implemented in this series. Support for USIv1 and HSI2C will
> be added in the future.
> 
> [...]

NOT applied patch 4/5 - I wait for bindings to be accepted by Greg.

Applied, thanks!

[1/5] dt-bindings: timer: exynos4210-mct: Add samsung,exynos8895-mct compatible
      https://git.kernel.org/krzk/linux/c/e54eb0465e548a7c6115e336ec5cfec04bbe8747
[2/5] arm64: dts: exynos8895: Add clock management unit nodes
      https://git.kernel.org/krzk/linux/c/fa986d1073805154888a788eda38d46a796346e8
[3/5] arm64: dts: exynos8895: Add Multi Core Timer (MCT) node
      https://git.kernel.org/krzk/linux/c/9ad6c3bd1bcbb73e2a5723e13b9d06e2296b07e4
[5/5] arm64: dts: exynos8895: Add spi_0/1 nodes
      https://git.kernel.org/krzk/linux/c/a5541d737c8de71948bcdaee912bcb6b0781af7e

Best regards,
Ivaylo Ivanov Oct. 26, 2024, 12:18 p.m. UTC | #6
On 10/26/24 15:12, Krzysztof Kozlowski wrote:
> On Wed, 23 Oct 2024 12:17:29 +0300, Ivaylo Ivanov wrote:
>> Hey folks,
>>
>> This patchset adds device tree nodes for multiple clock management unit
>> blocks, MCT, SPI and UART for Exynos8895.
>>
>> Exynos8895 uses USIv1 for most of its serial buses, except a few that
>> have been implemented in this series. Support for USIv1 and HSI2C will
>> be added in the future.
>>
>> [...]
> NOT applied patch 4/5 - I wait for bindings to be accepted by Greg.

Alright, thanks for applying the rest!

Best regards, Ivo.

>
> Applied, thanks!
>
> [1/5] dt-bindings: timer: exynos4210-mct: Add samsung,exynos8895-mct compatible
>       https://git.kernel.org/krzk/linux/c/e54eb0465e548a7c6115e336ec5cfec04bbe8747
> [2/5] arm64: dts: exynos8895: Add clock management unit nodes
>       https://git.kernel.org/krzk/linux/c/fa986d1073805154888a788eda38d46a796346e8
> [3/5] arm64: dts: exynos8895: Add Multi Core Timer (MCT) node
>       https://git.kernel.org/krzk/linux/c/9ad6c3bd1bcbb73e2a5723e13b9d06e2296b07e4
> [5/5] arm64: dts: exynos8895: Add spi_0/1 nodes
>       https://git.kernel.org/krzk/linux/c/a5541d737c8de71948bcdaee912bcb6b0781af7e
>
> Best regards,
Ivaylo Ivanov Nov. 7, 2024, 4:02 p.m. UTC | #7
On 10/26/24 15:18, Ivaylo Ivanov wrote:
>
>
> On 10/26/24 15:12, Krzysztof Kozlowski wrote:
>> On Wed, 23 Oct 2024 12:17:29 +0300, Ivaylo Ivanov wrote:
>>> Hey folks,
>>>
>>> This patchset adds device tree nodes for multiple clock management unit
>>> blocks, MCT, SPI and UART for Exynos8895.
>>>
>>> Exynos8895 uses USIv1 for most of its serial buses, except a few that
>>> have been implemented in this series. Support for USIv1 and HSI2C will
>>> be added in the future.
>>>
>>> [...]
>> NOT applied patch 4/5 - I wait for bindings to be accepted by Greg.
> Alright, thanks for applying the rest!
>
> Best regards, Ivo.

Bump - now that the uart patches are merged, are you gonna merge the DT
changes after the merge window? If not, I can send a new patchset that
includes them and also adds PMU compatible node for the mongoose cores,
since that got merged with exynos9810.

Best regards, Ivo.

>
>> Applied, thanks!
>>
>> [1/5] dt-bindings: timer: exynos4210-mct: Add samsung,exynos8895-mct compatible
>>       https://git.kernel.org/krzk/linux/c/e54eb0465e548a7c6115e336ec5cfec04bbe8747
>> [2/5] arm64: dts: exynos8895: Add clock management unit nodes
>>       https://git.kernel.org/krzk/linux/c/fa986d1073805154888a788eda38d46a796346e8
>> [3/5] arm64: dts: exynos8895: Add Multi Core Timer (MCT) node
>>       https://git.kernel.org/krzk/linux/c/9ad6c3bd1bcbb73e2a5723e13b9d06e2296b07e4
>> [5/5] arm64: dts: exynos8895: Add spi_0/1 nodes
>>       https://git.kernel.org/krzk/linux/c/a5541d737c8de71948bcdaee912bcb6b0781af7e
>>
>> Best regards,
Krzysztof Kozlowski Nov. 8, 2024, 11:11 a.m. UTC | #8
On 07/11/2024 17:02, Ivaylo Ivanov wrote:
> 
> 
> 
> On 10/26/24 15:18, Ivaylo Ivanov wrote:
>>
>>
>> On 10/26/24 15:12, Krzysztof Kozlowski wrote:
>>> On Wed, 23 Oct 2024 12:17:29 +0300, Ivaylo Ivanov wrote:
>>>> Hey folks,
>>>>
>>>> This patchset adds device tree nodes for multiple clock management unit
>>>> blocks, MCT, SPI and UART for Exynos8895.
>>>>
>>>> Exynos8895 uses USIv1 for most of its serial buses, except a few that
>>>> have been implemented in this series. Support for USIv1 and HSI2C will
>>>> be added in the future.
>>>>
>>>> [...]
>>> NOT applied patch 4/5 - I wait for bindings to be accepted by Greg.
>> Alright, thanks for applying the rest!
>>
>> Best regards, Ivo.
> 
> Bump - now that the uart patches are merged, are you gonna merge the DT
> changes after the merge window? If not, I can send a new patchset that
> includes them and also adds PMU compatible node for the mongoose cores,
> since that got merged with exynos9810.
> 
> Best regards, Ivo.

It is too late in the cycle for me to pick it up. I will take it after
the merge window, so feel free to send new version with some other changes.


Best regards,
Krzysztof