| Message ID | 20241025141130.3179166-2-r.czerwinski@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Fri, Oct 25, 2024 at 04:11:28PM +0200, Rouven Czerwinski wrote: A nit, subject: drop second/last, redundant "YAML schema for". The "dt-bindings" prefix is already stating that these are bindings in schema and YAML. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > +++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: LXD M9189A DSI Display Panel > + > +maintainers: > + - Rouven Czerwinski <r.czerwinski@pengutronix.de> > + > +properties: > + compatible: > + const: lxd,m9189a > + > + reg: > + maxItems: 1 > + > + standby-gpios: > + description: GPIO used for the standby pin > + maxItems: 1 > + > + reset-gpios: > + description: GPIO used for the reset pin > + maxItems: 1 > + > + vdd-supply: > + description: Power regulator > + > + backlight: > + description: Backlight used by the panel > + $ref: /schemas/types.yaml#/definitions/phandle > + > + port: true This misses it's definition. You should reference proper panel schema in top-level. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml new file mode 100644 index 0000000000000..2f14213801a48 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml @@ -0,0 +1,68 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/lxd,m9189a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LXD M9189A DSI Display Panel + +maintainers: + - Rouven Czerwinski <r.czerwinski@pengutronix.de> + +properties: + compatible: + const: lxd,m9189a + + reg: + maxItems: 1 + + standby-gpios: + description: GPIO used for the standby pin + maxItems: 1 + + reset-gpios: + description: GPIO used for the reset pin + maxItems: 1 + + vdd-supply: + description: Power regulator + + backlight: + description: Backlight used by the panel + $ref: /schemas/types.yaml#/definitions/phandle + + port: true + +required: + - compatible + - reg + - standby-gpios + - reset-gpios + - vdd-supply + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "lxd,m9189a"; + reg = <0>; + backlight = <&backlight>; + reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>; + standby-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>; + vdd-supply = <®_display_3v3>; + + port { + mipi_panel_in: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + };
The LXD M9189A is a 1024x600 MIPI-DSI panel. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de> --- v2: - add missing port property - fix example to use vdd supply found by running make dt_binding_check as suggested by the bot - fix missing A in M9189A title - fix compatible found after v1 submission .../bindings/display/panel/lxd,m9189a.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/lxd,m9189a.yaml