| Message ID | 20241021195316.58911-3-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | : chemical: bme680: 2nd set of cleanup | expand |
On Mon, 21 Oct 2024 21:53:05 +0200 Vasileios Amoiridis <vassilisamir@gmail.com> wrote: > According to datasheet's Section 1.1, Table 1, the startup time for the > device is 2ms and not 5ms. Ok. If this were just in the probe path (which it is today) I would not bother with the risk for a 3msec potential saving. However, you are going to reuse it in runtime resume where the effects will be more obvious. Hence applied to the togreg branch of iio.git and pushed out as testing. *fingers crossed* no one has out of spec wiring that needs a little longer than the spec says. Jonathan > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > drivers/iio/chemical/bme680.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h > index dc9ff477da34..f5be4516dde7 100644 > --- a/drivers/iio/chemical/bme680.h > +++ b/drivers/iio/chemical/bme680.h > @@ -65,7 +65,8 @@ > > #define BME680_MEAS_TRIM_MASK GENMASK(24, 4) > > -#define BME680_STARTUP_TIME_US 5000 > +/* Datasheet Section 1.1, Table 1 */ > +#define BME680_STARTUP_TIME_US 2000 > > /* Calibration Parameters */ > #define BME680_T2_LSB_REG 0x8A
diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h index dc9ff477da34..f5be4516dde7 100644 --- a/drivers/iio/chemical/bme680.h +++ b/drivers/iio/chemical/bme680.h @@ -65,7 +65,8 @@ #define BME680_MEAS_TRIM_MASK GENMASK(24, 4) -#define BME680_STARTUP_TIME_US 5000 +/* Datasheet Section 1.1, Table 1 */ +#define BME680_STARTUP_TIME_US 2000 /* Calibration Parameters */ #define BME680_T2_LSB_REG 0x8A
According to datasheet's Section 1.1, Table 1, the startup time for the device is 2ms and not 5ms. Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- drivers/iio/chemical/bme680.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)