| Message ID | 20241024222944.473d88c5@rorschach.local.home (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a574e7f80e86c740e241c762923f50077b2c2a30 |
| Headers | show |
| Series | fgraph: Change the name of cpuhp state to "fgraph:online" | expand |
On Thu, 24 Oct 2024 22:29:44 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > From: Steven Rostedt <rostedt@goodmis.org> > > The cpuhp state name given to cpuhp_setup_state() is "fgraph_idle_init" > which doesn't really conform to the names that are used for cpu hotplug > setups. Instead rename it to "fgraph:online" to be in line with other > states. > > Suggested-by: Masami Hiramatsu <mhiramat@kernel.org> > Fixes: 2c02f7375e658 ("fgraph: Use CPU hotplug mechanism to initialize idle shadow stacks") > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> Looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thank you! > --- > kernel/trace/fgraph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c > index cd1c2946018c..69e226a48daa 100644 > --- a/kernel/trace/fgraph.c > +++ b/kernel/trace/fgraph.c > @@ -1255,7 +1255,7 @@ int register_ftrace_graph(struct fgraph_ops *gops) > guard(mutex)(&ftrace_lock); > > if (!fgraph_initialized) { > - ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "fgraph_idle_init", > + ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "fgraph:online", > fgraph_cpu_init, NULL); > if (ret < 0) { > pr_warn("fgraph: Error to init cpu hotplug support\n"); > -- > 2.45.2 >
diff --git a/kernel/trace/fgraph.c b/kernel/trace/fgraph.c index cd1c2946018c..69e226a48daa 100644 --- a/kernel/trace/fgraph.c +++ b/kernel/trace/fgraph.c @@ -1255,7 +1255,7 @@ int register_ftrace_graph(struct fgraph_ops *gops) guard(mutex)(&ftrace_lock); if (!fgraph_initialized) { - ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "fgraph_idle_init", + ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "fgraph:online", fgraph_cpu_init, NULL); if (ret < 0) { pr_warn("fgraph: Error to init cpu hotplug support\n");