| Message ID | 20241025104548.1220076-4-fshao@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Update properties in two ASoC DT bindings | expand |
On Fri, Oct 25, 2024 at 06:44:43PM +0800, Fei Shao wrote: > Reference dai-common.yaml schema to support '#sound-dai-cells' and > 'sound-name-prefix' properties. Why? Is this a DAI? > > Signed-off-by: Fei Shao <fshao@chromium.org> > --- > > Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > index deaa6886c42f..5bd235cf15e6 100644 > --- a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > @@ -9,6 +9,9 @@ title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speak > maintainers: > - Steve Lee <steves.lee@maximintegrated.com> > > +allOf: > + - $ref: dai-common.yaml# > + > properties: > compatible: > const: maxim,max98390 Missing dai cells - how many DAIs are there? Best regards, Krzysztof
On Mon, Oct 28, 2024 at 4:55 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Fri, Oct 25, 2024 at 06:44:43PM +0800, Fei Shao wrote: > > Reference dai-common.yaml schema to support '#sound-dai-cells' and > > 'sound-name-prefix' properties. > > Why? Is this a DAI? I'll add a line to say this is a DAI and the patch fixes dtbs_check errors. > > > > > Signed-off-by: Fei Shao <fshao@chromium.org> > > --- > > > > Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > index deaa6886c42f..5bd235cf15e6 100644 > > --- a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > @@ -9,6 +9,9 @@ title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speak > > maintainers: > > - Steve Lee <steves.lee@maximintegrated.com> > > > > +allOf: > > + - $ref: dai-common.yaml# > > + > > properties: > > compatible: > > const: maxim,max98390 > > Missing dai cells - how many DAIs are there? Acked. Will add "#sound-dai-cells": const 0 > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml index deaa6886c42f..5bd235cf15e6 100644 --- a/Documentation/devicetree/bindings/sound/maxim,max98390.yaml +++ b/Documentation/devicetree/bindings/sound/maxim,max98390.yaml @@ -9,6 +9,9 @@ title: Maxim Integrated MAX98390 Speaker Amplifier with Integrated Dynamic Speak maintainers: - Steve Lee <steves.lee@maximintegrated.com> +allOf: + - $ref: dai-common.yaml# + properties: compatible: const: maxim,max98390 @@ -36,7 +39,7 @@ required: - compatible - reg -additionalProperties: false +unevaluatedProperties: false examples: - |
Reference dai-common.yaml schema to support '#sound-dai-cells' and 'sound-name-prefix' properties. Signed-off-by: Fei Shao <fshao@chromium.org> --- Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)