| Message ID | 20241011074619.796580-3-quic_kriskura@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add Devicetree support for USB controllers on QCS8300 | expand |
On Fri, Oct 11, 2024 at 01:16:19PM +0530, Krishna Kurapati wrote: > Enable primary USB controller on QCS8300 Ride platform. The primary USB > controller is made "peripheral", as this is intended to be connected to > a host for debugging use cases. > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > index 7eed19a694c3..3e925228379c 100644 > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > @@ -265,3 +265,26 @@ &ufs_mem_phy { > vdda-pll-supply = <&vreg_l5a>; > status = "okay"; > }; > + > +&usb_1_hsphy { > + vdda-pll-supply = <&vreg_l7a>; > + vdda18-supply = <&vreg_l7c>; > + vdda33-supply = <&vreg_l9a>; > + > + status = "okay"; > +}; > + > +&usb_qmpphy { > + vdda-phy-supply = <&vreg_l7a>; > + vdda-pll-supply = <&vreg_l5a>; > + > + status = "okay"; > +}; > + > +&usb_1 { > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + dr_mode = "peripheral"; > +}; So, can it be used as a USB host controller / connector? What needs to be done in such a case?
On 10/26/2024 11:06 PM, Dmitry Baryshkov wrote: > On Fri, Oct 11, 2024 at 01:16:19PM +0530, Krishna Kurapati wrote: >> Enable primary USB controller on QCS8300 Ride platform. The primary USB >> controller is made "peripheral", as this is intended to be connected to >> a host for debugging use cases. >> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> index 7eed19a694c3..3e925228379c 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> @@ -265,3 +265,26 @@ &ufs_mem_phy { >> vdda-pll-supply = <&vreg_l5a>; >> status = "okay"; >> }; >> + >> +&usb_1_hsphy { >> + vdda-pll-supply = <&vreg_l7a>; >> + vdda18-supply = <&vreg_l7c>; >> + vdda33-supply = <&vreg_l9a>; >> + >> + status = "okay"; >> +}; >> + >> +&usb_qmpphy { >> + vdda-phy-supply = <&vreg_l7a>; >> + vdda-pll-supply = <&vreg_l5a>; >> + >> + status = "okay"; >> +}; >> + >> +&usb_1 { >> + status = "okay"; >> +}; >> + >> +&usb_1_dwc3 { >> + dr_mode = "peripheral"; >> +}; > > So, can it be used as a USB host controller / connector? What needs to > be done in such a case? > Adding vbus boost pinctrl and changing dr_mode to host must be enough for this case. Regards, Krishna,
On Sun, Oct 27, 2024 at 11:59:44AM +0530, Krishna Kurapati wrote: > > > On 10/26/2024 11:06 PM, Dmitry Baryshkov wrote: > > On Fri, Oct 11, 2024 at 01:16:19PM +0530, Krishna Kurapati wrote: > > > Enable primary USB controller on QCS8300 Ride platform. The primary USB > > > controller is made "peripheral", as this is intended to be connected to > > > a host for debugging use cases. > > > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > > --- > > > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++ > > > 1 file changed, 23 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > > index 7eed19a694c3..3e925228379c 100644 > > > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > > @@ -265,3 +265,26 @@ &ufs_mem_phy { > > > vdda-pll-supply = <&vreg_l5a>; > > > status = "okay"; > > > }; > > > + > > > +&usb_1_hsphy { > > > + vdda-pll-supply = <&vreg_l7a>; > > > + vdda18-supply = <&vreg_l7c>; > > > + vdda33-supply = <&vreg_l9a>; > > > + > > > + status = "okay"; > > > +}; > > > + > > > +&usb_qmpphy { > > > + vdda-phy-supply = <&vreg_l7a>; > > > + vdda-pll-supply = <&vreg_l5a>; > > > + > > > + status = "okay"; > > > +}; > > > + > > > +&usb_1 { > > > + status = "okay"; > > > +}; > > > + > > > +&usb_1_dwc3 { > > > + dr_mode = "peripheral"; > > > +}; > > > > So, can it be used as a USB host controller / connector? What needs to > > be done in such a case? > > > Adding vbus boost pinctrl and changing dr_mode to host must be enough for > this case. Could you please mention those either in the commie message or in the comment before the board DT file?
On 10/27/2024 11:14 PM, Dmitry Baryshkov wrote: > On Sun, Oct 27, 2024 at 11:59:44AM +0530, Krishna Kurapati wrote: >> >> >> On 10/26/2024 11:06 PM, Dmitry Baryshkov wrote: >>> On Fri, Oct 11, 2024 at 01:16:19PM +0530, Krishna Kurapati wrote: >>>> Enable primary USB controller on QCS8300 Ride platform. The primary USB >>>> controller is made "peripheral", as this is intended to be connected to >>>> a host for debugging use cases. >>>> >>>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++ >>>> 1 file changed, 23 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>>> index 7eed19a694c3..3e925228379c 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>>> @@ -265,3 +265,26 @@ &ufs_mem_phy { >>>> vdda-pll-supply = <&vreg_l5a>; >>>> status = "okay"; >>>> }; >>>> + >>>> +&usb_1_hsphy { >>>> + vdda-pll-supply = <&vreg_l7a>; >>>> + vdda18-supply = <&vreg_l7c>; >>>> + vdda33-supply = <&vreg_l9a>; >>>> + >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&usb_qmpphy { >>>> + vdda-phy-supply = <&vreg_l7a>; >>>> + vdda-pll-supply = <&vreg_l5a>; >>>> + >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&usb_1 { >>>> + status = "okay"; >>>> +}; >>>> + >>>> +&usb_1_dwc3 { >>>> + dr_mode = "peripheral"; >>>> +}; >>> >>> So, can it be used as a USB host controller / connector? What needs to >>> be done in such a case? >>> >> Adding vbus boost pinctrl and changing dr_mode to host must be enough for >> this case. > > Could you please mention those either in the commie message or in the > comment before the board DT file? > Sure, I can update commit text to add something like the following: "In case first controller needs to be configured in host mode, X-GPIO to be enabled and dr_mode to be changed accordingly." But when we add second controller (which I will after SPMI node is done), this commit text would be redundant as the same file would show example for host mode as well. Regards, Krishna,
On Mon, Oct 28, 2024 at 12:32:02AM +0530, Krishna Kurapati wrote: > > > On 10/27/2024 11:14 PM, Dmitry Baryshkov wrote: > > On Sun, Oct 27, 2024 at 11:59:44AM +0530, Krishna Kurapati wrote: > > > > > > > > > On 10/26/2024 11:06 PM, Dmitry Baryshkov wrote: > > > > On Fri, Oct 11, 2024 at 01:16:19PM +0530, Krishna Kurapati wrote: > > > > > Enable primary USB controller on QCS8300 Ride platform. The primary USB > > > > > controller is made "peripheral", as this is intended to be connected to > > > > > a host for debugging use cases. > > > > > > > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> > > > > > --- > > > > > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++ > > > > > 1 file changed, 23 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > > > > index 7eed19a694c3..3e925228379c 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > > > > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > > > > @@ -265,3 +265,26 @@ &ufs_mem_phy { > > > > > vdda-pll-supply = <&vreg_l5a>; > > > > > status = "okay"; > > > > > }; > > > > > + > > > > > +&usb_1_hsphy { > > > > > + vdda-pll-supply = <&vreg_l7a>; > > > > > + vdda18-supply = <&vreg_l7c>; > > > > > + vdda33-supply = <&vreg_l9a>; > > > > > + > > > > > + status = "okay"; > > > > > +}; > > > > > + > > > > > +&usb_qmpphy { > > > > > + vdda-phy-supply = <&vreg_l7a>; > > > > > + vdda-pll-supply = <&vreg_l5a>; > > > > > + > > > > > + status = "okay"; > > > > > +}; > > > > > + > > > > > +&usb_1 { > > > > > + status = "okay"; > > > > > +}; > > > > > + > > > > > +&usb_1_dwc3 { > > > > > + dr_mode = "peripheral"; > > > > > +}; > > > > > > > > So, can it be used as a USB host controller / connector? What needs to > > > > be done in such a case? > > > > > > > Adding vbus boost pinctrl and changing dr_mode to host must be enough for > > > this case. > > > > Could you please mention those either in the commie message or in the > > comment before the board DT file? > > > > Sure, I can update commit text to add something like the following: > > "In case first controller needs to be configured in host mode, X-GPIO to be > enabled and dr_mode to be changed accordingly." > > But when we add second controller (which I will after SPMI node is done), > this commit text would be redundant as the same file would show example for > host mode as well. My point was that it might be not obvious that the controller isn't designated to be peripheral on a board level and can be easily switched to work as a USB host.
diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts index 7eed19a694c3..3e925228379c 100644 --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts @@ -265,3 +265,26 @@ &ufs_mem_phy { vdda-pll-supply = <&vreg_l5a>; status = "okay"; }; + +&usb_1_hsphy { + vdda-pll-supply = <&vreg_l7a>; + vdda18-supply = <&vreg_l7c>; + vdda33-supply = <&vreg_l9a>; + + status = "okay"; +}; + +&usb_qmpphy { + vdda-phy-supply = <&vreg_l7a>; + vdda-pll-supply = <&vreg_l5a>; + + status = "okay"; +}; + +&usb_1 { + status = "okay"; +}; + +&usb_1_dwc3 { + dr_mode = "peripheral"; +};
Enable primary USB controller on QCS8300 Ride platform. The primary USB controller is made "peripheral", as this is intended to be connected to a host for debugging use cases. Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com> --- arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)