| Message ID | 20241025213645.3464331-8-kbusch@meta.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | write hints with nvme fdp, scsi streams | expand |
On 10/25/24 2:36 PM, Keith Busch wrote: > From: Keith Busch <kbusch@kernel.org> > > The block limits exports the number of write hints, so set this limit if > the device reports support for the lifetime hints. Not only does this > inform the user of which hints are possible, it also allows scsi devices > supporting the feature to utilize the full range through raw block > device direct-io. > > Signed-off-by: Keith Busch <kbusch@kernel.org> > --- > drivers/scsi/sd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index ca4bc0ac76adc..235dd6e5b6688 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3768,6 +3768,8 @@ static int sd_revalidate_disk(struct gendisk *disk) > sd_config_protection(sdkp, &lim); > } > > + lim.max_write_hints = sdkp->permanent_stream_count; > + > /* > * We now have all cache related info, determine how we deal > * with flush requests. Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 10/25/24 23:36, Keith Busch wrote: > From: Keith Busch <kbusch@kernel.org> > > The block limits exports the number of write hints, so set this limit if > the device reports support for the lifetime hints. Not only does this > inform the user of which hints are possible, it also allows scsi devices > supporting the feature to utilize the full range through raw block > device direct-io. > > Signed-off-by: Keith Busch <kbusch@kernel.org> > --- > drivers/scsi/sd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index ca4bc0ac76adc..235dd6e5b6688 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -3768,6 +3768,8 @@ static int sd_revalidate_disk(struct gendisk *disk) > sd_config_protection(sdkp, &lim); > } > > + lim.max_write_hints = sdkp->permanent_stream_count; > + > /* > * We now have all cache related info, determine how we deal > * with flush requests. Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index ca4bc0ac76adc..235dd6e5b6688 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -3768,6 +3768,8 @@ static int sd_revalidate_disk(struct gendisk *disk) sd_config_protection(sdkp, &lim); } + lim.max_write_hints = sdkp->permanent_stream_count; + /* * We now have all cache related info, determine how we deal * with flush requests.