| Message ID | 20241028154805.1394611-1-leitao@debian.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] net: netconsole: selftests: Change the IP subnet | expand |
Hi Breno, On 28/10/2024 16:48, Breno Leitao wrote: > Use a less populated IP range to run the tests, as suggested by Petr in > Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/. It looks like this is the same version as the one you sent on Friday, without the modification suggested by Petr: https://lore.kernel.org/20241025161415.238215-1-leitao@debian.org I supposed these new patches have been sent by accident, right? (BTW: it is often better to include a cover letter when there is more than one patch: some CIs might not take patches sent without it.) Cheers, Matt
Hello Matthieu, On Mon, Oct 28, 2024 at 06:57:29PM +0100, Matthieu Baerts wrote: > Hi Breno, > > On 28/10/2024 16:48, Breno Leitao wrote: > > Use a less populated IP range to run the tests, as suggested by Petr in > > Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/. > > It looks like this is the same version as the one you sent on Friday, > without the modification suggested by Petr: > > https://lore.kernel.org/20241025161415.238215-1-leitao@debian.org > > I supposed these new patches have been sent by accident, right? Right. I've resent the v1 instead of the v2. :-| I've just sent v2 now. https://lore.kernel.org/all/20241029090030.1793551-1-leitao@debian.org/ Thanks for the heads-up, --breno
diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh index 06021b2059b7..4ad1e216c6b0 100755 --- a/tools/testing/selftests/drivers/net/netcons_basic.sh +++ b/tools/testing/selftests/drivers/net/netcons_basic.sh @@ -20,9 +20,9 @@ SCRIPTDIR=$(dirname "$(readlink -e "${BASH_SOURCE[0]}")") # Simple script to test dynamic targets in netconsole SRCIF="" # to be populated later -SRCIP=192.168.1.1 +SRCIP=192.168.2.1 DSTIF="" # to be populated later -DSTIP=192.168.1.2 +DSTIP=192.168.2.2 PORT="6666" MSG="netconsole selftest"
Use a less populated IP range to run the tests, as suggested by Petr in Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/. Suggested-by: Petr Machata <petrm@nvidia.com> Signed-off-by: Breno Leitao <leitao@debian.org> --- tools/testing/selftests/drivers/net/netcons_basic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)